Conversation
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-gencheck |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
/pj-rehearse auto-ack |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
...icemesh/hypershift/hostedcluster/create/servicemesh-hypershift-hostedcluster-create-ref.yaml
Outdated
Show resolved
Hide resolved
…/create/servicemesh-hypershift-hostedcluster-create-ref.yaml Co-authored-by: Yuanlin Xu <xuyuanlin_00@hotmail.com>
| - name: OLM_CATALOG_PLACEMENT | ||
| default: "management" | ||
| documentation: "The OLM catalog placement. Supported options: management, guest, default management" | ||
| - name: POWERVS_REGION |
There was a problem hiding this comment.
Do we need all those empty default value environment variables such as those Powervs ones listed in our step ref ?
Are those just place holders when we don't want to modify their provision script ?
There was a problem hiding this comment.
THose are just placeholders to avoid modify their script. I don't want to add another script to mantain in our side xD
|
[REHEARSALNOTIFIER]
A total of 54 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
| steps: | ||
| pre: | ||
| - chain: hypershift-hostedcluster-create | ||
| - chain: servicemesh-hypershift-hostedcluster-create |
There was a problem hiding this comment.
I see you are adding a new chain here.
There is another option for replacing that new chain with all the two steps refs in that new chain here. That will reduce the number of metadata.json files in this PR.
It's an optional change. If you think adding a new chain is more clear, then this is also fine.
There was a problem hiding this comment.
I think it is clearer. At least to me
There was a problem hiding this comment.
I'll rerun the rehearsal. THey were stopped after the commit
|
/pj-rehearse auto-ack |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjglira, yxun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
@yxun: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-pilot |
|
@yxun: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@fjglira: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Reusing the same scripts but creating our own step to tied the creation quota to our own ossm quota