OCPQE-31700: Migrate hypershift-mce-agent-metal3-conformance-calico/cilium workflows to baremetalds-ofcir-pre chain

[zhfeng]

Summary

• Migrate hypershift-mce-agent-metal3-conformance-calico and hypershift-mce-agent-metal3-conformance-cilium workflows from legacy baremetalds-packet-setup to baremetalds-ofcir-pre chain
• These were the last two hypershift workflows with equinix-ocp-hcp cluster profile not yet migrated to ofcir

Changes

• Replace individual pre steps (baremetalds-packet-setup, ipi-install-rbac, baremetalds-devscripts-proxy, ipi-install-hosted-loki, baremetalds-devscripts-setup) with baremetalds-ofcir-pre chain
• Move calico-conf/cilium-conf ref before the chain (these only write manifests to SHARED_DIR with no host dependency)
• Remove PACKET_METRO: dc env var (ofcir handles host selection)

Jira

• https://issues.redhat.com/browse/OCPQE-31700
• Related: https://issues.redhat.com/browse/OCPSTRAT-2832

[openshift-ci-robot]

@zhfeng: This pull request references OCPQE-31700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Migrate hypershift-mce-agent-metal3-conformance-calico and hypershift-mce-agent-metal3-conformance-cilium workflows from legacy baremetalds-packet-setup to baremetalds-ofcir-pre chain
• These were the last two hypershift workflows with equinix-ocp-hcp cluster profile not yet migrated to ofcir

Changes

• Replace individual pre steps (baremetalds-packet-setup, ipi-install-rbac, baremetalds-devscripts-proxy, ipi-install-hosted-loki, baremetalds-devscripts-setup) with baremetalds-ofcir-pre chain
• Move calico-conf/cilium-conf ref before the chain (these only write manifests to SHARED_DIR with no host dependency)
• Remove PACKET_METRO: dc env var (ofcir handles host selection)

Jira

• https://issues.redhat.com/browse/OCPQE-31700
• Related: https://issues.redhat.com/browse/OCPSTRAT-2832

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhfeng
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/mce/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@zhfeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-cilium-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-cilium-ipv4-metal-conformance	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-cilium-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-cilium-ipv4-metal-conformance

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@zhfeng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zhfeng]

/pj-rehearse ack

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/hold

[mgencur]

This is already waiting for review in these two PRs:
#73983
#73985
The baremetalds-ofcir-pre chain can't be run as a whole as cilium-conf (or calico-conf) is missing in it. So, I have pulled individual steps and called them on by one, and called cilium-conf as well.

[zhfeng]

Thanks @mgencur and I will close my PR.

[mgencur]

The baremetalds-ofcir-pre chain can't be run as a whole as cilium-conf (or calico-conf) is missing in it. So, I have pulled individual steps and called them on by one, and called cilium-conf as well.

Actually, this is not right. Your solution is better and it works, the step just generates files in SHARED_DIR. I will include this in my PRs. Thanks for the tip!