Skip to content

OCPQE-31708: Add all hosted cluster service NodePorts to squid allowed_ssl_ports#75701

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
zhfeng:fix-squid-proxy-oauth-port
Mar 5, 2026
Merged

OCPQE-31708: Add all hosted cluster service NodePorts to squid allowed_ssl_ports#75701
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
zhfeng:fix-squid-proxy-oauth-port

Conversation

@zhfeng
Copy link
Copy Markdown
Contributor

@zhfeng zhfeng commented Mar 4, 2026

Summary

  • Fix squid proxy to allow all hosted cluster service NodePorts (oauth-openshift, konnectivity-server, ignition-server-proxy) in addition to the kube-apiserver port
  • The hypershift-agent-create-proxy step now reads SHARED_DIR/hosted_*_port files written by the hypershift-mce-agent-create-hostedcluster step and passes them to the remote squid configuration
  • Fixes [sig-auth][Feature:OAuthServer] well-known endpoint should be reachable conformance test failures across 4.16-4.21

Root Cause

The squid proxy's allowed_ssl_ports ACL only included the kube-apiserver NodePort (added by PR #75256). Other hosted cluster service NodePorts (e.g., oauth-openshift port 31846) were blocked, causing TCP_DENIED/403 when conformance tests tried to authenticate via the OAuth server through the proxy.

Evidence

From 4.16 build 2029114548413272064:

  • Squid access log: TCP_DENIED/403 CONNECT api...ostest.test.metalkube.org:31846 (OAuth port)
  • allowed_ssl_ports only had: 443 5000 6443 31778 (KAS port)
  • Squid DENIED timestamp exactly matches the test failure time

JIRA

https://issues.redhat.com/browse/OCPQE-31708

Test plan

  • Rehearse against a hypershift agent metal conformance job
  • Verify squid config includes all hosted cluster service NodePorts in allowed_ssl_ports
  • Verify [sig-auth][Feature:OAuthServer] well-known endpoint should be reachable test passes

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2026

@zhfeng: This pull request references OCPQE-31708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Fix squid proxy to allow all hosted cluster service NodePorts (oauth-openshift, konnectivity-server, ignition-server-proxy) in addition to the kube-apiserver port
  • The hypershift-agent-create-proxy step now reads SHARED_DIR/hosted_*_port files written by the hypershift-mce-agent-create-hostedcluster step and passes them to the remote squid configuration
  • Fixes [sig-auth][Feature:OAuthServer] well-known endpoint should be reachable conformance test failures across 4.16-4.21

Root Cause

The squid proxy's allowed_ssl_ports ACL only included the kube-apiserver NodePort (added by PR #75256). Other hosted cluster service NodePorts (e.g., oauth-openshift port 31846) were blocked, causing TCP_DENIED/403 when conformance tests tried to authenticate via the OAuth server through the proxy.

Evidence

From 4.16 build 2029114548413272064:

  • Squid access log: TCP_DENIED/403 CONNECT api...ostest.test.metalkube.org:31846 (OAuth port)
  • allowed_ssl_ports only had: 443 5000 6443 31778 (KAS port)
  • Squid DENIED timestamp exactly matches the test failure time

JIRA

https://issues.redhat.com/browse/OCPQE-31708

Test plan

  • Rehearse against a hypershift agent metal conformance job
  • Verify squid config includes all hosted cluster service NodePorts in allowed_ssl_ports
  • Verify [sig-auth][Feature:OAuthServer] well-known endpoint should be reachable test passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2026
@zhfeng zhfeng force-pushed the fix-squid-proxy-oauth-port branch from fa07f3f to 20c4f9a Compare March 4, 2026 23:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2026
@openshift-ci openshift-ci bot requested review from eranco74 and sjenning March 4, 2026 23:45
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zhfeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-release-4.16-e2e-agent-disconnected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-ipv4-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-guest-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-baremetalds-agent-hypershift-mce-compact-full-inplace-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-critical N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-compact-full-inplace-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-critical N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-inplace-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-critical N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-baremetalds-hypershift-agent-mce-n1minor-mgmt-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-eus-upgrade-from-4.16-baremetalds-agent-hypershift-mce-compact-full-inplace-f28 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-upgrade-from-stable-4.17-baremetalds-agent-hypershift-mce-compact-full-inplace-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-baremetalds-hypershift-agent-mce-n1minor-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-baremetalds-hypershift-agent-mce-disconnected-guest-f14-des N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-mgmt-f14 N/A periodic Registry content changed

A total of 119 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zhfeng
Copy link
Copy Markdown
Contributor Author

zhfeng commented Mar 4, 2026

/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zhfeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-release-4.16-e2e-agent-disconnected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-ipv4-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-guest-f14-des N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-critical N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-baremetalds-agent-hypershift-mce-compact-full-inplace-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-baremetalds-hypershift-agent-mce-n1minor-mgmt-f28 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-baremetalds-hypershift-agent-mce-disconnected-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-inplace-f60 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-guest-f14-des N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-disconnected-guest-f14-des N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-4.20-upgrade-from-stable-4.20-baremetalds-agent-hypershift-mce-inplace-f60 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-baremetalds-hypershift-agent-mce-guest-f14 N/A periodic Registry content changed

A total of 119 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zhfeng
Copy link
Copy Markdown
Contributor Author

zhfeng commented Mar 5, 2026

pj-rehearse ack

@zhfeng
Copy link
Copy Markdown
Contributor Author

zhfeng commented Mar 5, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 5, 2026
@heliubj18
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, zhfeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 903cee5 into openshift:main Mar 5, 2026
10 checks passed
coleenquadros pushed a commit to coleenquadros/release that referenced this pull request Mar 5, 2026
sdodson pushed a commit to sdodson/release that referenced this pull request Mar 8, 2026
SeanZhao-redhat pushed a commit to SeanZhao-redhat/openshift-release that referenced this pull request Mar 9, 2026
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Mar 11, 2026
amp-rh pushed a commit to amp-rh/openshift-release that referenced this pull request Mar 12, 2026
tareqalayan pushed a commit to tareqalayan/release that referenced this pull request Mar 13, 2026
qiliRedHat pushed a commit to qiliRedHat/release that referenced this pull request Mar 13, 2026
MayXuQQ pushed a commit to MayXuQQ/release that referenced this pull request Mar 17, 2026
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Mar 17, 2026
sairameshv pushed a commit to sairameshv/release that referenced this pull request Mar 23, 2026
zhouying7780 pushed a commit to zhouying7780/release that referenced this pull request Mar 25, 2026
rrasouli pushed a commit to rrasouli/release that referenced this pull request Mar 25, 2026
anpingli pushed a commit to anpingli/release that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants