e2e-upi template: gcp enable 02_lb_int.py workflow#7571
e2e-upi template: gcp enable 02_lb_int.py workflow#7571openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
|
/cc @patrickdillon |
|
/retest |
1 similar comment
|
/retest |
|
/hold for e2e-gcp-upi |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
size/L
jstuever
force-pushed
the
cors1394
branch
2 times, most recently
from
f9f3dea to
1c06884
Compare
|
/test pj-rehearse |
|
/retest |
jstuever
force-pushed
the
cors1394
branch
2 times, most recently
from
19d703f to
1bc6105
Compare
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
Generally LGTM. Let's see if the tests turn anything up, or ping me for LGTM. |
|
Why is azure trying to pull |
|
e2e-gcp-upi passed. All changes are inside of https://github.com/openshift/release/pull/7571/files#diff-2b1b845b92f8062711789a2bfdb27290L1525 |
|
/lgtm |
I am guessing that the vhd is created just using the cluster name and the rest of the resources use the infra id which includes a random string.
azure upi source is in this very template. |
This appears to be originating from [1] [2] [3] |
|
@angelofdeauth I would recommend reaching out to @fabianofranz with azure upi questions in slack forum-installer |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
Show resolved
Hide resolved
|
No change required for destroy ? |
Destroy changes are here: |
that's bootstrap destroy, part of setup, i was more concerned about the teardown. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Nothing special in destroy... it uses the |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jstuever: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jstuever: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@patrickdillon Awesome, thanks. Still getting my bearings on the installer but I'm hoping to help with development in the near future. I'm not currently on an engagement utilizing Azure, so I most likely won't be doing much with that as of right now, but I noticed the test was failing and that seemed to be the rabbit hole where the issue started. My current client is one of the largest GCP + OCP customers -- I will be doing custom work with them, hopefully we're able to utilize it upstream.
@jstuever Thanks for the explanation, as well as links to the relevant lines. Aside from openshift/release and openshift/installer, what repos are relevant to the installer? Are there architecture/design/requirements/planning documents I can take a look at? Chat chans I can join? BlueJeans meetings? I've wanted to add features before, however I'm hesitant to make changes without looking at the contract and existing/planned obligations for the install-config and the existing roadmap for the installer. |
If you need intro on these CI templates ping me on slack. I think it would save you a lot of time rather than trying to figure it out yourself. These CI templates will be moving to a new system which should make them easier to digest. |
7 participants
This change is required to assist with the modified GCP UPI workflow
defined by openshift/installer#3270. It also fixes a typo to enable openshift/installer#2574.
Note:
if [ -f 02_lb_int.py ]is used throughout to determine if the internal load balancer code is in play. This allows the various version to continue to work depending on what features they have available.