Skip to content

prow: add preset-ci-operator-image-pull preset#75830

Draft
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:preset-ci-operator-image-pull
Draft

prow: add preset-ci-operator-image-pull preset#75830
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:preset-ci-operator-image-pull

Conversation

@petr-muller
Copy link
Member

Summary

Proof of concept for using Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjob definitions.

This PR adds a preset to the Prow config that provides the pull-secret volume and volumeMount to any Prowjob labeled with preset-ci-operator-image-pull: "true".

Changes

  • core-services/prow/02_config/_config.yaml: Add preset-ci-operator-image-pull preset definition

Design

This is the first of several compositional, domain-specific presets — each covers one logical domain with its own label, and they compose independently. See the companion ci-tools PR for the full design.

Rollout

  1. This PR merges first — adds the preset definition. No behavior change since no jobs have the label yet.
  2. ci-tools PR merges — prowgen starts adding the label and stops inlining the volume/mount.
  3. make update run — regenerates all jobs, removing ~888K lines of boilerplate and adding the label.

Companion PR

Requires the prowgen change in openshift/ci-tools: openshift/ci-tools#4994

Test plan

  • make checkconfig passes with the preset defined
  • After ci-tools change: make update regenerates jobs correctly
  • Verify a sample regenerated job resolves the preset correctly at runtime

🤖 Generated with Claude Code

Add a Prow preset that provides the registry pull credentials
volume and volumeMount to Prowjobs labeled with
preset-ci-operator-image-pull: "true".

This is a proof of concept for using compositional Prow presets to
deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs.
Each preset covers one logical domain and can be independently composed.

The corresponding prowgen change adds this label to all generated jobs
and stops inlining the pull-secret volume/mount in the PodSpec.

Requires the corresponding prowgen change in openshift/ci-tools:
https://github.com/openshift/ci-tools/pull/XXXXX

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign liangxia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2026
petr-muller added a commit to petr-muller/release that referenced this pull request Mar 6, 2026
Regenerate all Prowjob definitions using the modified prowgen that
uses the preset-ci-operator-image-pull Prow preset instead of inlining
the pull-secret volume and volumeMount in every job PodSpec.

Per-job changes:
- Added label: preset-ci-operator-image-pull: "true"
- Removed: pull-secret volumeMount (3 lines)
- Removed: pull-secret volume definition (3 lines)
- Net: -5 lines per job

25,666 files changed, -633K lines net reduction.

Depends on:
- Preset definition: openshift#75830
- Prowgen change: openshift/ci-tools#4994

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@petr-muller
Copy link
Member Author

/test prow-config

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/prow-config 6fbb758 link true /test prow-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants