Skip to content

Add lint-backend to monitoring-plugin#76147

Open
simonpasquier wants to merge 1 commit intoopenshift:mainfrom
simonpasquier:monitoring-plugin-lint-go
Open

Add lint-backend to monitoring-plugin#76147
simonpasquier wants to merge 1 commit intoopenshift:mainfrom
simonpasquier:monitoring-plugin-lint-go

Conversation

@simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Mar 12, 2026

@simonpasquier
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

- as: lint
commands: |
make lint-frontend
make lint-frontend lint-backend && git diff --exit-code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint-frontend changes the current directory. We probably need to fix this from the makefile side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact I had to change the approach because we need a Go-based image so I'm creating a new test.

@simonpasquier simonpasquier force-pushed the monitoring-plugin-lint-go branch from 06d7dab to 0c8ba0d Compare March 12, 2026 13:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonpasquier
Once this PR has been reviewed and has the lgtm label, please assign jan--f for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026
@simonpasquier simonpasquier force-pushed the monitoring-plugin-lint-go branch from 0c8ba0d to 6304bd3 Compare March 12, 2026 14:36
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier force-pushed the monitoring-plugin-lint-go branch from 6304bd3 to 570f39f Compare March 12, 2026 14:49
@simonpasquier
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-monitoring-plugin-main-lint

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: job(s): pull-ci-openshift-monitoring-plugin-main-lint either don't exist or were not found to be affected, and cannot be rehearsed

@simonpasquier
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simonpasquier
Copy link
Contributor Author

/pj-rehearse list

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-monitoring-plugin-main-go-tests openshift/monitoring-plugin presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simonpasquier
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-monitoring-plugin-main-go-tests

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/monitoring-plugin/main/lint 06d7dab link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-main-lint
ci/rehearse/openshift/monitoring-plugin/main/go-tests 570f39f link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-main-go-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants