Add lint-backend to monitoring-plugin#76147
Add lint-backend to monitoring-plugin#76147simonpasquier wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
/pj-rehearse |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| - as: lint | ||
| commands: | | ||
| make lint-frontend | ||
| make lint-frontend lint-backend && git diff --exit-code |
There was a problem hiding this comment.
lint-frontend changes the current directory. We probably need to fix this from the makefile side
There was a problem hiding this comment.
in fact I had to change the approach because we need a Go-based image so I'm creating a new test.
06d7dab to
0c8ba0d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
0c8ba0d to
6304bd3
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
6304bd3 to
570f39f
Compare
|
/pj-rehearse pull-ci-openshift-monitoring-plugin-main-lint |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@simonpasquier: job(s): pull-ci-openshift-monitoring-plugin-main-lint either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse list |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-monitoring-plugin-main-go-tests |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@simonpasquier: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Will need openshift/monitoring-plugin#835 first