Add e2e-aws-spot periodic job for HyperShift spot instance verification (OCPSTRAT-1677)

[zhfeng]

Summary

Add CI infrastructure to verify AWS Spot Instance support in HyperShift NodePools (OCPSTRAT-1677 / CNTRLPLANE-1388).

New step registry components:

• hypershift-aws-spot-sqs-setup — Creates SQS queue and EventBridge rules for spot interruption events
• hypershift-aws-spot-sqs-cleanup — Best-effort cleanup of AWS resources
• hypershift-aws-spot-verify — Comprehensive spot feature verification step
• hypershift-aws-e2e-spot — Workflow combining setup, e2e test, verify, and cleanup

Periodic job: Weekly e2e-aws-spot for release-4.22, running TestSpotTerminationHandler.

Related HyperShift PRs:

• CNTRLPLANE-1388: Spot with termination handler hypershift#7567 — Spot with termination handler (infrastructure + controller)
• CNTRLPLANE-1388: Add Spot instance support in the API hypershift#7625 — Add Spot instance support in the API

Verification Checklist

The hypershift-aws-spot-verify step and the e2e test cover the following checks:

• aws-node-termination-handler image present in release payload
• terminationHandlerQueueURL set on HostedCluster
• aws-node-termination-handler deployment running in HCP namespace
• Termination handler runs management-side only (no daemonset in guest cluster)
• Web identity token auth via token-minter-kube sidecar
• Spot NodePool created with annotation-based spot enablement
• AWSMachineTemplate has spotMarketOptions configured
• MachineDeployment has interruptible-instance label
• <nodepool>-spot MachineHealthCheck exists with correct label selector
• MHC has 8m timeout, 100% maxUnhealthy, 20m nodeStartupTimeout
• CEL validation: Spot + CapacityReservation correctly rejected
• CEL validation: Spot + dedicated tenancy correctly rejected
• CEL validation: spot options without marketType=Spot correctly rejected
• E2E: Simulated SQS rebalance recommendation event taints the node

Test Plan

• Use /pj-rehearse to trigger the e2e-aws-spot periodic job
• Verify all checklist items pass in the verify step output

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhfeng
Once this PR has been reviewed and has the lgtm label, please assign jparrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS
• ci-operator/jobs/openshift/hypershift/OWNERS
• ci-operator/step-registry/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-upgrade

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@zhfeng: job(s): periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-upgrade either don't exist or were not found to be affected, and cannot be rehearsed

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[zhfeng]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@zhfeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@zhfeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot	3e76288	link	unknown	/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-spot

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.