Skip to content

replace milind to yuedong for qe members#76501

Open
huali9 wants to merge 1 commit intoopenshift:mainfrom
huali9:addyuedong
Open

replace milind to yuedong for qe members#76501
huali9 wants to merge 1 commit intoopenshift:mainfrom
huali9:addyuedong

Conversation

@huali9
Copy link
Contributor

@huali9 huali9 commented Mar 19, 2026

refer #31927, replace milind to yuedong as a secondary cherry pick approver. @sunzhaohua2 @lunarwhite PTAL, thanks.

liuhuali@Lius-MacBook-Pro release % make prow-config
false || docker pull --platform linux/amd64 quay.io/openshift/ci-public:ci_auto-config-brancher_latest
ci_auto-config-brancher_latest: Pulling from openshift/ci-public
1174ed37633c: Already exists 
1370def9c30e: Pull complete 
Digest: sha256:028ab448bed2947f8e474b68df192b6488dc0032096f76bf312934829c0b32da
Status: Downloaded newer image for quay.io/openshift/ci-public:ci_auto-config-brancher_latest
quay.io/openshift/ci-public:ci_auto-config-brancher_latest
docker run --platform linux/amd64 --user 501:20 --rm -v "/Users/liuhuali/project/release/core-services/prow/02_config:/config:z" --entrypoint=/usr/bin/determinize-prow-config quay.io/openshift/ci-public:ci_auto-config-brancher_latest --prow-config-dir /config --sharded-prow-config-base-dir /config --sharded-plugin-config-base-dir /config
liuhuali@Lius-MacBook-Pro release % 

@openshift-ci openshift-ci bot requested review from chrischdi and damdo March 19, 2026 02:23
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 19, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@huali9: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

@huali9: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huali9
Copy link
Contributor Author

huali9 commented Mar 19, 2026

/assign @damdo

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Welcome!

@lunarwhite
Copy link
Member

Thanks both!

I'm wondering if we can safely drop below section from each repo going forward, since cherry-pick-approved labeling restriction was included to support an old process

- allowed_users:
      - <QE member>
      assign_on:
      - label: backport-risk-assessed
      label: cherry-pick-approved

https://redhat-internal.slack.com/archives/GE2HQ9QP4/p1773910211759879

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damdo, huali9, JoelSpeed
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented Mar 19, 2026

We need approval from @elmiko

too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants