Skip to content

Add branch protection for medik8s org #76526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Mar 19, 2026
Merged

Add branch protection for medik8s org #76526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dffdc7
Add branch protection for medik8s org
razo7 Mar 19, 2026
5fd061b
Run make prow-config to determinize config
razo7 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core-services/prow/02_config/medik8s/_prowconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
branch-protection:
orgs:
medik8s:
enforce_admins: true
Copy link
Contributor

@mshitrit mshitrit Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that.
Don't we want to allow admins more flexibility ?

required_pull_request_reviews:
dismiss_stale_reviews: true
require_code_owner_reviews: true
required_approving_review_count: 1
Comment on lines +6 to +8
Copy link
Contributor

@mshitrit mshitrit Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this part is already enforced.
Is it because it's set on each repo individually , or am I missing something here ?

Copy link
Member Author

@razo7 razo7 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this part is already enforced.

Please elaborate on how

Copy link
Contributor

@mshitrit mshitrit Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure,
For example taking this dismiss_stale_reviews: true
IIUC this means that pushing will prevent a previous confirmation.
ATM when we push new code it'll indeed remove the lgtm label.

tide:
queries:
- labels:
Expand Down