Skip to content

DPTP-4733: Unify pod scaler admission configs#76589

Open
liangxia wants to merge 1 commit intoopenshift:mainfrom
liangxia:pod-scaler
Open

DPTP-4733: Unify pod scaler admission configs#76589
liangxia wants to merge 1 commit intoopenshift:mainfrom
liangxia:pod-scaler

Conversation

@liangxia
Copy link
Member

$ find ../release -name pod-scaler-admission.yaml
../release/clusters/app.ci/pod-scaler/pod-scaler-admission.yaml
../release/clusters/build-clusters/common_except_app.ci/pod-scaler-admission.yaml
../release/clusters/build-clusters/vsphere02/pod-scaler-admission.yaml

$ diff ../release/clusters/build-clusters/common_except_app.ci/pod-scaler-admission.yaml ../release/clusters/app.ci/pod-scaler/pod-scaler-admission.yaml
62c62
<     keel.sh/pollSchedule: "@hourly"
---
>     keel.sh/pollSchedule: "@every 5m"
79a80,82
>       tolerations:
>       - key: manual-provision
>         operator: Exists
82d84
<         imagePullPolicy: Always
83a86
>         imagePullPolicy: Always
126,127d128
<           limits:
<             memory: "24Gi"
129c130
<             memory: "16Gi"
---
>             memory: "8Gi"
131,133d131
<       nodeSelector:
<         kubernetes.io/arch: amd64
<         kubernetes.io/os: linux

Verified the tolerations and nodeSelector changes does not harm.

$ oc --context app.ci get nodes --show-labels | grep manual | wc -l
0

$ oc --context app.ci get nodes --show-labels | grep 'arch=amd64' | grep 'os=linux' | wc -l
32

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2026

@liangxia: This pull request references DPTP-4733 which is a valid jira issue.

Details

In response to this:

$ find ../release -name pod-scaler-admission.yaml
../release/clusters/app.ci/pod-scaler/pod-scaler-admission.yaml
../release/clusters/build-clusters/common_except_app.ci/pod-scaler-admission.yaml
../release/clusters/build-clusters/vsphere02/pod-scaler-admission.yaml

$ diff ../release/clusters/build-clusters/common_except_app.ci/pod-scaler-admission.yaml ../release/clusters/app.ci/pod-scaler/pod-scaler-admission.yaml
62c62
<     keel.sh/pollSchedule: "@hourly"
---
>     keel.sh/pollSchedule: "@every 5m"
79a80,82
>       tolerations:
>       - key: manual-provision
>         operator: Exists
82d84
<         imagePullPolicy: Always
83a86
>         imagePullPolicy: Always
126,127d128
<           limits:
<             memory: "24Gi"
129c130
<             memory: "16Gi"
---
>             memory: "8Gi"
131,133d131
<       nodeSelector:
<         kubernetes.io/arch: amd64
<         kubernetes.io/os: linux

Verified the tolerations and nodeSelector changes does not harm.

$ oc --context app.ci get nodes --show-labels | grep manual | wc -l
0

$ oc --context app.ci get nodes --show-labels | grep 'arch=amd64' | grep 'os=linux' | wc -l
32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026
@openshift-ci openshift-ci bot requested review from droslean and psalajova March 20, 2026 10:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liangxia: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@liangxia
Copy link
Member Author

/hold
no mean to merge it on Friday.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@liangxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants