Refactor cost-onprem-chart job config to avoid long running tests on PRs#77270
Refactor cost-onprem-chart job config to avoid long running tests on PRs#77270testetson22 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: testetson22 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Review feedback1. Commit message is misleading The commit message says:
This describes the opposite of what the PR does. With
2. When should these be manually triggered? After this change, extended/stable/full only run if someone remembers to 3. Periodic/postsubmit coverage? With presubmits now manual-only, is there a periodic or postsubmit job that runs these profiles against |
Yes, the PR summary should have an accurate statement on this now; Claude generated an incorrect commit message that I did not catch.
Never. Until IQE work I've previously discussed is merged. Once that is merged, they can be triggered nightly, ad-hoc, and maybe on PRs, but anything above the smoke profile may hit all of the aforementioned issues in the documentation and will just time out right now. I'll clarify any guidance when they're actually runnable. If anything, I'm going to delete the additional jobs to avoid confusion until everything is aligned.
e2e with IQE smoke profile still runs on PRs. The other profiles were not intended to be ran automatically until my fixes and enhancements to IQE are merged. |
The e2e-iqe-extended, e2e-iqe-stable, and e2e-iqe-full jobs were misconfigured with skip_if_only_changed, causing them to run automatically on PRs with code changes instead of being on-demand. Removing these jobs until they can be properly configured as on-demand tests triggered only via /test commands. The main e2e job (with IQE smoke profile) remains unchanged and will continue to run on relevant code changes. Made-with: Cursor
093efdf to
230c254
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@testetson22: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e2e-iqe-extended,e2e-iqe-stable,e2e-iqe-full) that were unintentionally triggering on PRs due toskip_if_only_changedmisconfiguration. These will be enabled once supported. IQE changes are in the publish pipeline.e2ejob with IQE smoke tests continues to run on relevant code changes