Skip to content

feat: add ability to deploy plugin integration pieces alongside rhdh#77284

Open
PatAKnight wants to merge 1 commit intoopenshift:mainfrom
PatAKnight:rhdh-test-instance-plugin-config
Open

feat: add ability to deploy plugin integration pieces alongside rhdh#77284
PatAKnight wants to merge 1 commit intoopenshift:mainfrom
PatAKnight:rhdh-test-instance-plugin-config

Conversation

@PatAKnight
Copy link
Copy Markdown
Contributor

Description

Adds support for the --plugins flag being introduced in the companion PR #30, which deploys optional plugin integrations alongside an RHDH test instance. This allows users to deploy an RHDH instance with whichever plugins they want to test against.

Also included is a redeploy action, which allows users to switch to a new set of plugins without manually tearing down the cluster first. Under the hood, it looks up the previously deployed plugins, calls teardown.sh to cleanly remove those plugin integrations and the existing RHDH instance, and then redeploys fresh with the new plugin configuration.

Made with Cursor

/cc @subhashkhileri

Signed-off-by: Patrick Knight <pknight@redhat.com>
@openshift-ci openshift-ci bot requested a review from subhashkhileri April 2, 2026 02:25
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

Hi @PatAKnight. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PatAKnight
Once this PR has been reviewed and has the lgtm label, please assign zdrapela for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@PatAKnight: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-redhat-developer-rhdh-test-instance-main-deploy redhat-developer/rhdh-test-instance presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants