Skip to content

OCPEDGE-2397: Add resource-agents steps for TNF topology#77329

Draft
vimauro wants to merge 1 commit intoopenshift:mainfrom
vimauro:resource-agents-builder
Draft

OCPEDGE-2397: Add resource-agents steps for TNF topology#77329
vimauro wants to merge 1 commit intoopenshift:mainfrom
vimauro:resource-agents-builder

Conversation

@vimauro
Copy link
Copy Markdown
Contributor

@vimauro vimauro commented Apr 2, 2026

Summary

  • Add CI steps to optionally build resource-agents from source, create a custom RHCOS image via rpm-ostree, and apply it to cluster nodes before fencing tests run
  • Existing jobs are unaffected — default RHCOS mode reports the installed version and exits (no-op)
  • New nightly job variant repo-ra-techpreview for 4.22, 4.23, and 5.0

New Step Registry Refs

baremetalds-two-node-fencing-resource-agents-update-rhcos (test step)

  • Two modes via RESOURCE_AGENT_SOURCE env var:
    • RHCOS (default): reports installed resource-agents version and exits
    • REPO: clones resource-agents, builds RPM, creates layered RHCOS image with rpm-ostree, pushes to quay.io, applies MachineConfig, waits for rollout
  • Handles RHEL 9 vs 10 based on OCP minor version, with libqb source build fallback

baremetalds-two-node-fencing-resource-agents-delete-rhcos-image (post step)

  • Best-effort cleanup: deletes the job's image tag from quay.io and prunes stale tags >24h
  • Only runs when RESOURCE_AGENT_SOURCE=REPO

New Nightly Jobs

  • e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview for 4.22, 4.23, 5.0
  • Runs twice daily, uses RESOURCE_AGENT_SOURCE=REPO, requires nested-podman capability

Based on #75815

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 2, 2026

@vimauro: This pull request references OCPEDGE-2397 which is a valid jira issue.

Details

In response to this:

Summary

  • Add CI steps to optionally build resource-agents from source, create a custom RHCOS image via rpm-ostree, and apply it to cluster nodes before fencing tests run
  • Existing jobs are unaffected — default RHCOS mode reports the installed version and exits (no-op)
  • New nightly job variant repo-ra-techpreview for 4.22, 4.23, and 5.0

New Step Registry Refs

baremetalds-two-node-fencing-resource-agents-update-rhcos (test step)

  • Two modes via RESOURCE_AGENT_SOURCE env var:
    • RHCOS (default): reports installed resource-agents version and exits
    • REPO: clones resource-agents, builds RPM, creates layered RHCOS image with rpm-ostree, pushes to quay.io, applies MachineConfig, waits for rollout
  • Handles RHEL 9 vs 10 based on OCP minor version, with libqb source build fallback

baremetalds-two-node-fencing-resource-agents-delete-rhcos-image (post step)

  • Best-effort cleanup: deletes the job's image tag from quay.io and prunes stale tags >24h
  • Only runs when RESOURCE_AGENT_SOURCE=REPO

New Nightly Jobs

  • e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview for 4.22, 4.23, 5.0
  • Runs twice daily, uses RESOURCE_AGENT_SOURCE=REPO, requires nested-podman capability

Based on #75815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vimauro
Copy link
Copy Markdown
Contributor Author

vimauro commented Apr 2, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vimauro
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin, jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vimauro
Copy link
Copy Markdown
Contributor Author

vimauro commented Apr 2, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@vimauro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-5.0-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.23-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-validation-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-short-cert-rotation N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-gcp-graceful-shutdown N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4-rhcos10-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-serial-runc N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-ha-cert-rotation-shutdown-90d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-etcd-certrotation-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-runc-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-gcp-ovn-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ccm-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-azure-custom-dns-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-agent-ovn-two-node-arbiter N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ipi-serial-ovn-ipv4-techpreview-1of2 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-upi-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-ha-cert-rotation-suspend-360d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-azurestack-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d N/A periodic Ci-operator config changed

A total of 784 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@vimauro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview cf8c8df link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-recovery-repo-ra-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants