Skip to content

USHIFT-6776: Don't run update-versions-releases on 4.21, 4.22, 4.23#77774

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:microshift-update-rel-ver
Apr 14, 2026
Merged

USHIFT-6776: Don't run update-versions-releases on 4.21, 4.22, 4.23#77774
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmtk:microshift-update-rel-ver

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Apr 14, 2026 •
edited by coderabbitai Bot
Loading

We only want to run this script on a single, most recent branch that is tracking/mirroring main. Now it is 5.0.

Summary by CodeRabbit

  • Chores
    • Removed scheduled periodic version management jobs from the CI/CD pipeline for microshift releases 4.21, 4.22, and 4.23.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 14, 2026 •
edited by atlassian Bot
Loading

@pmtk: This pull request references USHIFT-6776 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

We only want to run this script on a single, most recent branch that is tracking/mirroring main. Now it is 5.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0456e93b-516a-4dfb-b414-5ae8af19c762

📥 Commits

Reviewing files that changed from the base of the PR and between c11caa4 and bec18c5.

📒 Files selected for processing (6)
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.21__periodics.yaml
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.23__periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.21-periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.22-periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.23-periodics.yaml
💤 Files with no reviewable changes (6)
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.21__periodics.yaml
  • ci-operator/config/openshift/microshift/openshift-microshift-release-4.23__periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.22-periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.21-periodics.yaml
  • ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.23-periodics.yaml

Walkthrough

Removed the periodic update-versions-releases job across all OpenShift microshift release configurations (4.21, 4.22, 4.23). Both the config test definitions and corresponding job declarations were deleted, eliminating the scheduled version management workflow.

Changes

Cohort / File(s) Summary
Config Periodic Test Definitions
ci-operator/config/openshift/microshift/openshift-microshift-release-4.2[1-3]__periodics.yaml		 Removed update-versions-releases test entry from three release version config files. Each deletion removed cron schedule, cluster profile configuration, EC2 instance type, and workflow reference.
Job Periodic Definitions
ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.2[1-3]-periodics.yaml		 Removed corresponding periodic-ci-openshift-microshift-release-4.2[1-3]-periodics-update-versions-releases job definitions. Each deletion removed the complete job spec including container configuration, environment variables, volumes, service account, and scheduling details.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: disabling the update-versions-releases job on three specific release branches (4.21, 4.22, 4.23).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Custom check is not applicable to this PR. The check validates Ginkgo test names in Go test files, but this PR only modifies CI/CD job configuration YAML files.
Test Structure And Quality ✅ Passed Pull request modifies only CI/CD configuration files in YAML format with no Ginkgo test code present, so custom check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only removes a periodic job configuration from CI files and does not add new test source code or Ginkgo test definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Pull request modifies only CI/CD configuration files (YAML) in ci-operator directories to remove periodic job definitions. No new Ginkgo e2e test code is introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI operator configuration files only, not deployment manifests or operator code running on clusters.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is not applicable to this PR. The PR modifies only YAML configuration files defining CI/CD periodic job schedules with no executable source code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only removes periodic CI job definitions from YAML configuration files; no new Ginkgo e2e tests are added, so IPv6 and disconnected network compatibility requirements are not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from eslutsky and pacevedom April 14, 2026 12:00
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 14, 2026 •
edited by atlassian Bot
Loading

@pmtk: This pull request references USHIFT-6776 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

We only want to run this script on a single, most recent branch that is tracking/mirroring main. Now it is 5.0.

Summary by CodeRabbit

  • Chores
  • Removed scheduled periodic version management jobs from the CI/CD pipeline for microshift releases 4.21, 4.22, and 4.23.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Apr 14, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 14, 2026

@pmtk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 14, 2026

[REHEARSALNOTIFIER]
@pmtk: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

pacevedom
pacevedom approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2026

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 4b2b5d4 into openshift:main Apr 14, 2026
16 checks passed
pmtk added a commit to pmtk/release that referenced this pull request Apr 15, 2026
@pmtk
Revert "Don't run update-versions-releases on 4.21, 4.22, 4.23 (opens…
cba4489 
…hift#77774)"

This reverts commit 4b2b5d4.
openshift-merge-bot Bot pushed a commit that referenced this pull request Apr 17, 2026
@pmtk
USHIFT-6859: Run update-versions-release on 5.0, 4.21, 4.22 (#77829)
3b89e0a 
* Run update-versions-release on 5.0

* Change version arg to major.minor

* Revert "Don't run update-versions-releases on 4.21, 4.22, 4.23 (#77774)"

This reverts commit 4b2b5d4.

* Skip GH release publish if no releases.json

* Correct args depending on the cloned branch

* Don't run update-versions-releases for 4.23
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
@pmtk @HarshwardhanPatil07
Don't run update-versions-releases on 4.21, 4.22, 4.23 (openshift#77774)
060e0f0
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
@pmtk @HarshwardhanPatil07
USHIFT-6859: Run update-versions-release on 5.0, 4.21, 4.22 (openshif…
9e32aa4 
…t#77829)

* Run update-versions-release on 5.0

* Change version arg to major.minor

* Revert "Don't run update-versions-releases on 4.21, 4.22, 4.23 (openshift#77774)"

This reverts commit 4b2b5d4.

* Skip GH release publish if no releases.json

* Correct args depending on the cloned branch

* Don't run update-versions-releases for 4.23
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
@pmtk @Prucek
Don't run update-versions-releases on 4.21, 4.22, 4.23 (openshift#77774)
697a60e
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
@pmtk @Prucek
USHIFT-6859: Run update-versions-release on 5.0, 4.21, 4.22 (openshif…
01de822 
…t#77829)

* Run update-versions-release on 5.0

* Change version arg to major.minor

* Revert "Don't run update-versions-releases on 4.21, 4.22, 4.23 (openshift#77774)"

This reverts commit 4b2b5d4.

* Skip GH release publish if no releases.json

* Correct args depending on the cloned branch

* Don't run update-versions-releases for 4.23
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
@pmtk @BATMAN-JD
USHIFT-6859: Run update-versions-release on 5.0, 4.21, 4.22 (openshif…
8ad5913 
…t#77829)

* Run update-versions-release on 5.0

* Change version arg to major.minor

* Revert "Don't run update-versions-releases on 4.21, 4.22, 4.23 (openshift#77774)"

This reverts commit 4b2b5d4.

* Skip GH release publish if no releases.json

* Correct args depending on the cloned branch

* Don't run update-versions-releases for 4.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eslutsky eslutsky Awaiting requested review from eslutsky

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmtk @openshift-ci-robot @pacevedom