Skip to content

o/release: bump some stray 4.22 occurences in 5.0 configs #77792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petr-muller wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

o/release: bump some stray 4.22 occurences in 5.0 configs #77792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,7 @@ tests:
steps:
env:
T5CI_JOB_TYPE: network-flow-matrix-bm
T5CI_VERSION: "4.22"
T5CI_VERSION: "5.0"
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

T5CI_VERSION: "5.0" is incompatible with current telco5g step scripts

This change can hard-fail these jobs. The current telco5g-origin-tests-commands.sh only has cases up to 4.22 and falls into Unsupported T5CI_VERSION for 5.0 (see ci-operator/step-registry/telco5g/origin/tests/telco5g-origin-tests-commands.sh, Line 116+). Additional 4.22-specific branch/image logic also exists in ci-operator/step-registry/telco5g/origin/tests/telco5g-origin-tests-commands.sh (Line 37+) and ci-operator/step-registry/telco5g/cnf/tests/telco5g-cnf-tests-commands.sh (Line 563+).

Please land/update those step-registry scripts in the same change (or keep this at 4.22 until they are updated) to avoid immediate job failures.

Suggested temporary guard (if script updates are not part of this PR) 
-      T5CI_VERSION: "5.0"
+      T5CI_VERSION: "4.22"
...
-      T5CI_VERSION: "5.0"
+      T5CI_VERSION: "4.22"

Also applies to: 1442-1442

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`
at line 1429, The T5CI_VERSION value "5.0" is incompatible with the telco5g step
scripts; either revert/set T5CI_VERSION back to "4.22" in the YAML or
concurrently update the step-registry scripts
(ci-operator/step-registry/telco5g/origin/tests/telco5g-origin-tests-commands.sh
and ci-operator/step-registry/telco5g/cnf/tests/telco5g-cnf-tests-commands.sh)
to handle "5.0" (add a new case in the version dispatch and adjust any
4.22-specific branch/image logic), and ensure the new branches/images are
covered in the same PR so jobs don’t hard-fail.

observers:
enable:
- observers-resource-watch
Expand All @@ -1439,7 +1439,7 @@ tests:
steps:
env:
T5CI_JOB_TYPE: network-flow-matrix-single-node-bm
T5CI_VERSION: "4.22"
T5CI_VERSION: "5.0"
observers:
enable:
- observers-resource-watch
Expand Down Expand Up @@ -2095,7 +2095,7 @@ tests:
cluster_profile: openshift-org-aws
env:
FIPS_ENABLED: "true"
MAJOR_MINOR: "4.22"
MAJOR_MINOR: "5.0"
test:
- ref: fips-check-node-scan
- ref: fips-check-art-fips
Expand Down