Skip to content

Revert "add github action 'Tests' to odh-dashboard tide contexts"#77797

Open
christianvogt wants to merge 1 commit intoopenshift:mainfrom
christianvogt:revert-odh-dashboard-gh-context-test
Open

Revert "add github action 'Tests' to odh-dashboard tide contexts"#77797
christianvogt wants to merge 1 commit intoopenshift:mainfrom
christianvogt:revert-odh-dashboard-gh-context-test

Conversation

@christianvogt
Copy link
Copy Markdown
Contributor

@christianvogt christianvogt commented Apr 14, 2026

reverts #73690 as it didn't solve out issue.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD system configuration for pull request management.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 79b227dc-6a7c-409a-a6ac-40af7090f786

📥 Commits

Reviewing files that changed from the base of the PR and between 81bf77c and 4188665.

📒 Files selected for processing (1)
  • core-services/prow/02_config/_config.yaml
💤 Files with no reviewable changes (1)
  • core-services/prow/02_config/_config.yaml

Walkthrough

Removed the required-if-present-contexts configuration containing Tests from the Prow tide context options for the odh-dashboard repository in the Prow configuration file.

Changes

Cohort / File(s) Summary
Prow Configuration
core-services/prow/02_config/_config.yaml
Removed required-if-present-contexts: [Tests] from tide.context_options.from-branch-protection for the opendatahub-io.repos.odh-dashboard entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: reverting a prior commit that added GitHub Action 'Tests' to odh-dashboard tide contexts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This custom check for stable and deterministic Ginkgo test names is not applicable to this pull request as the PR modifies only a Prow CI/CD configuration file with no Ginkgo test files being modified.
Test Structure And Quality ✅ Passed This PR contains only YAML configuration changes for Prow CI/CD infrastructure with no Ginkgo test code present, making the test quality assessment criteria inapplicable.
Microshift Test Compatibility ✅ Passed PR modifies only a Prow CI/CD configuration file, not adding any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR makes only configuration changes to Prow settings and does not add any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Prow CI configuration YAML, not deployment manifests or scheduling constraints. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed The custom check regarding OTE Binary Stdout Contract is not applicable to this pull request. This PR exclusively modifies a YAML configuration file, removing a required-if-present-contexts entry. Since there are no code changes, there are no stdout write violations.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a configuration file and does not add any Ginkgo e2e tests, so the custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from Prucek and danilo-gemoli April 14, 2026 17:30
@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 14, 2026
@christianvogt
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@christianvogt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@christianvogt: no rehearsable tests are affected by this change

@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, danilo-gemoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8d5fd75 and 2 for PR HEAD 4188665 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD e006344 and 1 for PR HEAD 4188665 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b040003 and 0 for PR HEAD 4188665 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/hold

Revision 4188665 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2026
…nshift#73690)"

This reverts the required-if-present-contexts addition for the 'Tests'
GitHub Action context on opendatahub-io/odh-dashboard.
@christianvogt christianvogt force-pushed the revert-odh-dashboard-gh-context-test branch from 4188665 to f42e32d Compare April 15, 2026 18:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

New changes are detected. LGTM label has been removed.

@christianvogt
Copy link
Copy Markdown
Contributor Author

christianvogt commented Apr 15, 2026

rebased
Not sure if this will help address the retests

@christianvogt
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@christianvogt: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@christianvogt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants