Open
Conversation
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maschmid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
WalkthroughThis pull request updates OpenShift release versions and CI job variant identifiers across multiple Knative project repositories. Changes include version bumps (4.14→4.16, 4.20→4.21, 4.20→4.22), image build trigger modifications, Prow job configuration updates, and release configuration changes to align with new release branches. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
|
[REHEARSALNOTIFIER]
A total of 239 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml (1)
385-399:⚠️ Potential issue | 🟠 MajorThe new
421periodics drop failure notifications.All four replacement
421lanes omitreporter_config.slack, unlike the neighboring periodic definitions above. That will silence#knative-eventing-cinotifications for e2e/reconciler/auth/keda failures and makes broken release lanes easier to miss. Please keep the reporter config unless notification routing was intentionally moved.Also applies to: 472-486, 559-573, 646-660
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml` around lines 385 - 399, The new periodic job definitions (e.g., periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-e2e-c) are missing reporter_config.slack and thus drop Slack failure notifications; restore the reporter config by adding the same reporter_config.slack block used by the neighboring periodic jobs (copy the Slack webhook/channel/fields from the jobs above) into each replacement 421 lane (and the similar 472-486, 559-573, 646-660 job blocks) so failures still post to `#knative-eventing-ci`.ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml (1)
106-120:⚠️ Potential issue | 🟠 MajorKeep Slack reporting on the replacement
421periodic.This
421lane no longer has areporter_config.slackblock, soe2e-tests-cfailures will stop notifying#knative-eventing-ci. If alerts were not intentionally moved elsewhere, please carry the reporter config forward with the variant bump.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml` around lines 106 - 120, The new periodic job periodic-ci-openshift-knative-eventing-istio-release-v1.17-421-e2e-tests-c (variant=421, target=e2e-tests-c) is missing the reporter_config.slack block from the previous lane; restore/copy the reporter_config.slack configuration into this job so e2e-tests-c failures continue to notify `#knative-eventing-ci`, ensuring the reporter_config and slack entries match the previous variant's settings and reference the same channel and webhook settings.
🧹 Nitpick comments (3)
ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-presubmits.yaml (1)
127-179: Verify missing--target=srcis intentional for the 422 variant.The 422-images job only has
--target=[images](Line 145) while the 421-images job has both--target=[images]and--target=src(Lines 85-86). Since this is a disabled variant (run_if_changed: ^non-existing$), this may be intentional, but worth confirming consistency when the variant becomes active.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-presubmits.yaml` around lines 127 - 179, The 422 variant job pull-ci-openshift-knative-backstage-plugins-release-v1.17-422-images currently only passes --target=[images] to ci-operator (and has run_if_changed: ^non-existing$); confirm whether --target=src should also be included for parity with the 421-images job and, if so, add a second - --target=src entry to the containers.args list so the job invokes both targets, otherwise leave as-is but add a brief comment near run_if_changed explaining the omission is intentional.ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml (1)
6-9: Consider updating base image tag when this variant becomes active.The base image
rhel-9-release-golang-1.24-openshift-4.20targets OCP 4.20 while this config targets OCP 4.22. This may be intentional for the disabled "next" variant, but should be updated (e.g., togolang-1.25-openshift-4.22or similar) when this variant is activated.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml` around lines 6 - 9, The tag value openshift_release_rhel-9-release-golang-1.24-openshift-4.20 targets OCP 4.20 while this config is for OCP 4.22; when enabling this "next" variant update the tag field (the YAML key tag under openshift_release_rhel-9-release-golang-1.24-openshift-4.20/name: release) to a matching base image for 4.22 (for example replace golang-1.24-openshift-4.20 with golang-1.25-openshift-4.22 or another approved 4.22 base image) so the base image and OCP target align.ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-postsubmits.yaml (1)
11-16: Consider addingjob-releaselabel for consistency.The first job (variant 421) is missing the
job-releaselabel, while the second job (variant 422, line 78) hasjob-release: "4.22". If the label is needed for job tracking or filtering, consider addingjob-release: "4.21"here for consistency.♻️ Suggested addition
labels: ci-operator.openshift.io/is-promotion: "true" ci-operator.openshift.io/variant: "421" ci.openshift.io/generator: prowgen + job-release: "4.21" max_concurrency: 1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-postsubmits.yaml` around lines 11 - 16, The labels block for the job named branch-ci-openshift-knative-kn-plugin-func-release-v1.17-421-images is missing the job-release label; add job-release: "4.21" to the labels section (alongside ci-operator.openshift.io/is-promotion, ci-operator.openshift.io/variant, and ci.openshift.io/generator) so it matches the other variant job that uses job-release: "4.22" for consistent tracking and filtering.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml`:
- Around line 289-295: The cluster_claim.timeout (the timeout field inside the
cluster_claim block) is too short (2h0m0s) and must be increased to exceed the
total job budget (main test step 4h0m0s plus ~1h post-gather); update the
timeout value in the cluster_claim blocks (the cluster_claim: -> timeout:
entries) to a safe value (for example 6h0m0s) so the cluster cannot be reclaimed
while tests/gather run; apply the same change to every occurrence of the
cluster_claim block mentioned in the review (the repeated cluster_claim timeout
entries at the other ranges).
In
`@ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml`:
- Around line 307-313: The cluster_claim timeout ("timeout" under the
cluster_claim block) is currently set to 2h0m0s and must be increased so the
claim does not expire before the main test + post-gather complete; update the
timeout value in the cluster_claim sections (the blocks containing cluster_claim
and timeout) to a value exceeding the job budget (e.g., >5h0m0s) so it covers
the 4h main test and ~1h post chain—apply this same change to every
cluster_claim occurrence noted in the file.
In
`@ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next__421.yaml`:
- Line 47: The Go builder image is still pinned to "openshift-4.20" while
runtime/test targets are set to version: "4.21"; update all occurrences of the
Go builder image reference from "openshift-4.20" to "openshift-4.21" so the
builder base image aligns with the declared version (search for the current
builder image string "openshift-4.20" and replace it to match "4.21" where
"version: \"4.21\"" is used).
In
`@ci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__422.yaml`:
- Around line 36-39: The e2e job is still pinned to OCP 4.16 while the
candidate/variant 422 and candidate.version are updated to "4.22"; update the
e2e-oncluster-test job's version field from "4.16" to "4.22" (and any other
occurrences of the old version within this file referenced in the diff) so the
generated __422 job validates against OCP 4.22—look for the candidate block, the
e2e-oncluster-test job, and any other version: "4.16" entries and make them
consistent with version: "4.22".
---
Outside diff comments:
In
`@ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml`:
- Around line 106-120: The new periodic job
periodic-ci-openshift-knative-eventing-istio-release-v1.17-421-e2e-tests-c
(variant=421, target=e2e-tests-c) is missing the reporter_config.slack block
from the previous lane; restore/copy the reporter_config.slack configuration
into this job so e2e-tests-c failures continue to notify `#knative-eventing-ci`,
ensuring the reporter_config and slack entries match the previous variant's
settings and reference the same channel and webhook settings.
In
`@ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml`:
- Around line 385-399: The new periodic job definitions (e.g.,
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-e2e-c)
are missing reporter_config.slack and thus drop Slack failure notifications;
restore the reporter config by adding the same reporter_config.slack block used
by the neighboring periodic jobs (copy the Slack webhook/channel/fields from the
jobs above) into each replacement 421 lane (and the similar 472-486, 559-573,
646-660 job blocks) so failures still post to `#knative-eventing-ci`.
---
Nitpick comments:
In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml`:
- Around line 6-9: The tag value
openshift_release_rhel-9-release-golang-1.24-openshift-4.20 targets OCP 4.20
while this config is for OCP 4.22; when enabling this "next" variant update the
tag field (the YAML key tag under
openshift_release_rhel-9-release-golang-1.24-openshift-4.20/name: release) to a
matching base image for 4.22 (for example replace golang-1.24-openshift-4.20
with golang-1.25-openshift-4.22 or another approved 4.22 base image) so the base
image and OCP target align.
In
`@ci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-presubmits.yaml`:
- Around line 127-179: The 422 variant job
pull-ci-openshift-knative-backstage-plugins-release-v1.17-422-images currently
only passes --target=[images] to ci-operator (and has run_if_changed:
^non-existing$); confirm whether --target=src should also be included for parity
with the 421-images job and, if so, add a second - --target=src entry to the
containers.args list so the job invokes both targets, otherwise leave as-is but
add a brief comment near run_if_changed explaining the omission is intentional.
In
`@ci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-postsubmits.yaml`:
- Around line 11-16: The labels block for the job named
branch-ci-openshift-knative-kn-plugin-func-release-v1.17-421-images is missing
the job-release label; add job-release: "4.21" to the labels section (alongside
ci-operator.openshift.io/is-promotion, ci-operator.openshift.io/variant, and
ci.openshift.io/generator) so it matches the other variant job that uses
job-release: "4.22" for consistent tracking and filtering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e97f07da-71aa-4257-95af-b6a3de4d4c32
📒 Files selected for processing (134)
Makefileci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__421.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__422.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__416.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__421.yamlci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__421.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__422.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__421.yamlci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing-hyperfoil-benchmark/openshift-knative-eventing-hyperfoil-benchmark-main__416.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21__416.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21__421.yamlci-operator/config/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing-istio/.config.prowgenci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__420.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__416.yamlci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__421.yamlci-operator/config/openshift-knative/eventing-kafka-broker/.config.prowgenci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__416.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__421.yamlci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__422.yamlci-operator/config/openshift-knative/eventing/.config.prowgenci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__422.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__416.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yamlci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__422.yamlci-operator/config/openshift-knative/kn-plugin-event/.config.prowgenci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17__421.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17__422.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21__421.yamlci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next__421.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__421.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__422.yamlci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21__421.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17__414.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17__421.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17__422.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21__416.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21__421.yamlci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21__422.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17__421.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17__422.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21__416.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21__421.yamlci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21__422.yamlci-operator/config/openshift-knative/serverless-operator/.config.prowgenci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__4.21-techpreview.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-aws-ovn.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-azure.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-gcp.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-hypershift.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-single-node.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421-vsphere.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__422.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__416.yamlci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__421.yamlci-operator/config/openshift-knative/serving/.config.prowgenci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__422.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__416.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__421.yamlci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__422.yamlci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/client/openshift-knative-client-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/eventing-hyperfoil-benchmark/openshift-knative-eventing-hyperfoil-benchmark-main-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-hyperfoil-benchmark/openshift-knative-eventing-hyperfoil-benchmark-main-presubmits.yamlci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-integrations/openshift-knative-eventing-integrations-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-periodics.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-periodics.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-periodics.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-periodics.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17-postsubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.17-presubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21-postsubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.21-presubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-postsubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-presubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-v1.21-presubmits.yamlci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yamlci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-postsubmits.yamlci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-presubmits.yamlci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37-postsubmits.yamlci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37-presubmits.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-periodics.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-postsubmits.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-presubmits.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-periodics.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-postsubmits.yamlci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-presubmits.yaml
💤 Files with no reviewable changes (2)
- ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml
- ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__420.yaml
Comment on lines
+289
to
+295
| cluster_claim: | ||
| architecture: amd64 | ||
| cloud: aws | ||
| owner: serverless-ci | ||
| product: ocp | ||
| timeout: 2h0m0s | ||
| version: "4.21" |
Contributor
There was a problem hiding this comment.
Extend the cluster-claim timeout beyond the job budget.
Each claim now expires after 2h0m0s (for example Line 294), but the main test step still allows 4h0m0s, and the post chain adds roughly another hour. These jobs can have their cluster reclaimed while the test or gather sequence is still running.
Also applies to: 417-423, 545-551, 673-679, 801-807, 929-935, 1057-1063, 1185-1191
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml`
around lines 289 - 295, The cluster_claim.timeout (the timeout field inside the
cluster_claim block) is too short (2h0m0s) and must be increased to exceed the
total job budget (main test step 4h0m0s plus ~1h post-gather); update the
timeout value in the cluster_claim blocks (the cluster_claim: -> timeout:
entries) to a safe value (for example 6h0m0s) so the cluster cannot be reclaimed
while tests/gather run; apply the same change to every occurrence of the
cluster_claim block mentioned in the review (the repeated cluster_claim timeout
entries at the other ranges).
Contributor
Author
There was a problem hiding this comment.
Isn't that the timeout for the cluster claim? (time to wait for the claim, not the timeout of the cluster duration)
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
@maschmid, you are correct — my review comment was mistaken. The timeout field in cluster_claim specifies how long ci-operator will wait for a cluster to become available from the pool. If no cluster is made available within that timeout, the execution fails. It is not a runtime budget for the cluster itself — once claimed, the cluster remains available for the full duration of the job regardless of this value.
I apologise for the incorrect flag. No changes are needed.
🌐 Web query:
OpenShift ci-operator cluster_claim timeout field meaning documentation
💡 Result:
In an OpenShift CI ci-operator cluster_claim stanza, the timeout field is the maximum amount of time ci-operator will wait to successfully claim a cluster from the target cluster pool.
- If a pool cluster is immediately available, the claim is fulfilled right away.
- If no cluster is available,
ci-operatorwaits (e.g., for a hibernating cluster to wake or for a new one to be created) untiltimeoutelapses. - If no cluster becomes available before
timeout, theci-operatorrun fails. [1]
Sources: OpenShift CI “CI Operator” docs (section “Testing with a Cluster from a Cluster Pool”). [1]
@maschmid, you are absolutely right — my review comment was incorrect. The timeout field in a cluster_claim block is the maximum amount of time ci-operator will wait to successfully claim a cluster from the target cluster pool — if no cluster is available before that timeout elapses, the run fails. It is not a runtime budget for the cluster; once claimed, the cluster remains available for the entire job duration regardless of this value.
Apologies for the noise. No changes are needed.
📝 Learnings were identified and not saved (knowledge base disabled). Enable
Comment on lines
+307
to
+313
| cluster_claim: | ||
| architecture: amd64 | ||
| cloud: aws | ||
| owner: serverless-ci | ||
| product: ocp | ||
| timeout: 2h0m0s | ||
| version: "4.21" |
Contributor
There was a problem hiding this comment.
Extend the cluster-claim timeout beyond the job budget.
Each claim now expires after 2h0m0s (for example Line 312), but the main test step still allows 4h0m0s, and the post chain adds roughly another hour. These jobs can have their cluster reclaimed while the test or gather sequence is still running.
Also applies to: 439-445, 571-577, 703-709, 835-841, 967-973, 1099-1105, 1231-1237
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml`
around lines 307 - 313, The cluster_claim timeout ("timeout" under the
cluster_claim block) is currently set to 2h0m0s and must be increased so the
claim does not expire before the main test + post-gather complete; update the
timeout value in the cluster_claim sections (the blocks containing cluster_claim
and timeout) to a value exceeding the job budget (e.g., >5h0m0s) so it covers
the 4h main test and ~1h post chain—apply this same change to every
cluster_claim occurrence noted in the file.
| release: | ||
| channel: fast | ||
| version: "4.20" | ||
| version: "4.21" |
Contributor
There was a problem hiding this comment.
Align builder base image with the 4.21 target release.
Line 47 and Line 68 move runtime/test targets to 4.21, but the Go builder image is still pinned to openshift-4.20 (Lines 6-9, 20, 29). This version skew can produce non-reproducible CI behavior across build vs test/promotion.
🔧 Proposed fix
- openshift_release_rhel-9-release-golang-1.25-openshift-4.20:
+ openshift_release_rhel-9-release-golang-1.25-openshift-4.21:
name: release
namespace: openshift
- tag: rhel-9-release-golang-1.25-openshift-4.20
+ tag: rhel-9-release-golang-1.25-openshift-4.21
@@
- openshift_release_rhel-9-release-golang-1.25-openshift-4.20:
+ openshift_release_rhel-9-release-golang-1.25-openshift-4.21:
as:
- $GO_BUILDER
@@
- openshift_release_rhel-9-release-golang-1.25-openshift-4.20:
+ openshift_release_rhel-9-release-golang-1.25-openshift-4.21:
as:
- $GO_BUILDERAlso applies to: 68-68
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next__421.yaml`
at line 47, The Go builder image is still pinned to "openshift-4.20" while
runtime/test targets are set to version: "4.21"; update all occurrences of the
Go builder image reference from "openshift-4.20" to "openshift-4.21" so the
builder base image aligns with the declared version (search for the current
builder image string "openshift-4.20" and replace it to match "4.21" where
"version: \"4.21\"" is used).
Comment on lines
+36
to
+39
| candidate: | ||
| product: ocp | ||
| stream: nightly | ||
| version: "4.22" |
Contributor
There was a problem hiding this comment.
Variant 422 is still provisioning a 4.16 cluster.
The file now targets OCP 4.22 at Lines 36-39 and advertises variant 422 at Line 83, but e2e-oncluster-test is still pinned to version: "4.16" on Line 61. That makes the generated __422 job validate the wrong cluster version unless the variant bump here was not intended.
Also applies to: 53-61, 83-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift-knative/kn-plugin-func/openshift-knative-kn-plugin-func-release-v1.17__422.yaml`
around lines 36 - 39, The e2e job is still pinned to OCP 4.16 while the
candidate/variant 422 and candidate.version are updated to "4.22"; update the
e2e-oncluster-test job's version field from "4.16" to "4.22" (and any other
occurrences of the old version within this file referenced in the diff) so the
generated __422 job validates against OCP 4.22—look for the candidate block, the
e2e-oncluster-test job, and any other version: "4.16" entries and make them
consistent with version: "4.22".
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-knative-serverless-operator-main-4.21-techpreview-olmv1-operator-e2e periodic-ci-openshift-knative-serverless-operator-main-421-vsphere-e2e-vsphere-continuous periodic-ci-openshift-knative-serverless-operator-main-421-single-node-e2e-sno-continuous periodic-ci-openshift-knative-serverless-operator-main-421-hypershift-e2e-hypershift-continuous periodic-ci-openshift-knative-serverless-operator-main-421-aws-ovn-e2e-aws-ovn-continuous |
Contributor
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-knative-serverless-operator-main-421-hypershift-e2e-hypershift-continuous |
Contributor
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-knative-serverless-operator-main-421-aws-ovn-e2e-aws-ovn-continuous |
Contributor
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@maschmid: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit