Adding otp-e2e tests on periodic jobs for hive

[miyadav]

/hold

WIP to see if any issues if there is periodic ran from main hive instead of OTP.

Summary by CodeRabbit

• Chores

  • Added CI base images used by workflows.
  • Extended CI cluster-profile allowlist to include the hive repo.
  • Added targeted Slack reporting for failures/errors/aborts of the new job.

• Tests

  • Added a new weekly periodic test to exercise long‑duration AWS installer scenarios and run extended end‑to‑end longrun tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eb7df3e5-fda4-42ab-8196-2007af535992

📥 Commits

Reviewing files that changed from the base of the PR and between f40d0a9 and dad51dd.

📒 Files selected for processing (2)

• ci-operator/config/openshift/hive/.config.prowgen
• ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml

✅ Files skipped from review due to trivial changes (1)

• ci-operator/config/openshift/hive/.config.prowgen

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml

---

Walkthrough

Adds a new periodic CI test and matching Prow periodic job for OpenShift Hive (AWS IPI long-duration), two new base_images, a cluster-profile allowlist update to include the Hive repo for the aws-qe profile, and a Slack reporter entry for test alerts.

Changes

Cohort / File(s)	Summary
Hive periodic config ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml	Added aws-ipi-f7-longduration-hive-sd-rosa periodic test (cron 0 6 * * 6), sets steps.cluster_profile: aws-qe, env vars (BASE_DOMAIN, FILTERS_ADDITIONAL, TEST_SCENARIOS, TEST_TIMEOUT), test.chain: openshift-e2e-test-qe-longrun, workflow: cucushift-installer-rehearse-aws-ipi, and added base_images entries tests-private and upi-installer.
Prow periodic job ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml	Added decorated periodic Prow job periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa scheduled 0 6 * * 6 on cluster: build07, runs ci-operator with --target=aws-ipi-f7-longduration-hive-sd-rosa --variant=periodic, mounts required secrets, serviceAccountName: ci-operator, and includes job/release labels and Slack reporting label.
Cluster profile allowlist ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml	Extended allowlist mapping under org: netobserv → profile: aws-qe to include the hive repository entry.
Prowgen Slack reporter ci-operator/config/openshift/hive/.config.prowgen	Added slack_reporter for #team-hive-alert-hcm-tests reporting failure, error, and aborted for job aws-ipi-f7-longduration-hive-sd-rosa (uses existing report_template).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'otp-e2e tests' but the actual changes implement 'aws-ipi-f7-longduration-hive-sd-rosa' tests using the 'openshift-e2e-test-qe-longrun' chain, not OTP end-to-end tests.	Update the title to accurately reflect the actual implementation, such as 'Adding aws-ipi-f7-longduration-hive-sd-rosa periodic test job for hive' or similar to match the actual changes.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML CI configuration files, not Ginkgo test code files, so test name validation is not applicable.
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test code quality is not applicable to this PR. The PR exclusively modifies YAML configuration files for CI/CD pipeline setup with no test code to review.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e test code; it only adds CI configuration YAML files to schedule existing test chains as periodic jobs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only CI/CD YAML configuration files for periodic jobs and Slack reporting. No new Ginkgo e2e test code is added, so SNO compatibility assessment is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Modified files are exclusively OpenShift CI/CD infrastructure configuration files (Prow periodic job definitions, ci-operator test configurations, and Slack notification settings). These files do not contain Kubernetes deployment manifests, operator code, or scheduling constraints affecting production workloads.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML CI/CD configuration files with no executable code, source code, or test implementations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Custom check applies only when new Ginkgo e2e tests are added. This PR adds only CI/CD configuration files with no new test code or Ginkgo patterns.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miyadav
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo, prucek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hive/OWNERS
• ci-operator/jobs/openshift/hive/OWNERS
• ci-operator/step-registry/cluster-profiles/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml`:
- Around line 2-84: This job (name:
periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa)
is missing a reporter_config block; add a reporter_config at the job level
mirroring the other Hive periodic jobs so failures are sent to Slack (include
the slack reporter settings: slack channel, cluster/cluster alias labels and the
secret reference for the Slack webhook), ensuring the reporter_config key and
its slack subkeys match the schema used by the other Hive periodics in this
file.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 79a62e74-be49-41cb-9e6a-88bfecac9d3a

📥 Commits

Reviewing files that changed from the base of the PR and between 67c97f7 and 08fec54.

📒 Files selected for processing (3)

• ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml
• ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml
• ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@miyadav: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hive-master-periodic-images	openshift/hive	presubmit	Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-openstack-weekly	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-pool-weekly	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-weekly	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-azure-weekly	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa	N/A	periodic	Periodic changed
periodic-ci-openshift-hive-master-periodic-e2e-gcp-weekly	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[miyadav]

/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa

[openshift-merge-bot]

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@miyadav: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[miyadav]

/unhold