-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add openshift-e2e-aws-disconnected workflow #77922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdbooth
wants to merge
1
commit into
openshift:main
Choose a base branch
from
openshift-cloud-team:aws-disconnected
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - vrutkovs | ||
| - deads2k | ||
| - technical-release-team-approvers | ||
| - jianlinliu | ||
| - yunjiang29 | ||
| - patrickdillon |
13 changes: 13 additions & 0 deletions
13
...tor/step-registry/ipi/aws/post/disconnected/ipi-aws-post-disconnected-chain.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "path": "ipi/aws/post/disconnected/ipi-aws-post-disconnected-chain.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "vrutkovs", | ||
| "deads2k", | ||
| "technical-release-team-approvers", | ||
| "jianlinliu", | ||
| "yunjiang29", | ||
| "patrickdillon" | ||
| ] | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
ci-operator/step-registry/ipi/aws/post/disconnected/ipi-aws-post-disconnected-chain.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| chain: | ||
| as: ipi-aws-post-disconnected | ||
| steps: | ||
| - ref: gather-aws-console | ||
| - ref: gather-installer-boostrap-logs-in-bastion | ||
| - ref: gather-mirror-registry | ||
| - chain: ipi-deprovision | ||
| - ref: aws-deprovision-security-group | ||
| - ref: aws-deprovision-stacks | ||
| - ref: aws-deprovision-users-and-policies | ||
| - ref: aws-deprovision-verification | ||
| documentation: |- | ||
| The ipi-aws-post-disconnected chain gathers artifacts and deprovisions | ||
| a disconnected OpenShift cluster on AWS, including the bastion host, | ||
| CloudFormation VPC stack, and static IAM users created during installation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - vrutkovs | ||
| - deads2k | ||
| - technical-release-team-approvers | ||
| - jianlinliu | ||
| - yunjiang29 | ||
| - patrickdillon |
13 changes: 13 additions & 0 deletions
13
...rator/step-registry/ipi/aws/pre/disconnected/ipi-aws-pre-disconnected-chain.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "path": "ipi/aws/pre/disconnected/ipi-aws-pre-disconnected-chain.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "vrutkovs", | ||
| "deads2k", | ||
| "technical-release-team-approvers", | ||
| "jianlinliu", | ||
| "yunjiang29", | ||
| "patrickdillon" | ||
| ] | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
ci-operator/step-registry/ipi/aws/pre/disconnected/ipi-aws-pre-disconnected-chain.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| chain: | ||
| as: ipi-aws-pre-disconnected | ||
| steps: | ||
| - ref: aws-provision-vpc-disconnected | ||
| - chain: aws-provision-bastionhost | ||
| - chain: mirror-images-payload | ||
| - ref: ipi-conf | ||
| - ref: ipi-conf-telemetry | ||
| - ref: ipi-conf-aws-custom-vpc | ||
| - ref: ipi-conf-manual-creds | ||
| - ref: ipi-conf-aws | ||
| - ref: ipi-conf-mirror | ||
| - ref: ipi-install-monitoringpvc | ||
| - ref: proxy-config-generate | ||
| - ref: aws-provision-cco-manual-users-static | ||
| - ref: ipi-conf-manual-creds-remove-unnecessary-creds | ||
| - chain: aws-provision-iam-user-minimal-permission | ||
| - ref: openshift-cluster-bot-rbac | ||
| - ref: ipi-install-hosted-loki | ||
| - ref: ipi-install-install-aws | ||
| - ref: ipi-install-times-collection | ||
| - ref: nodes-readiness | ||
| - ref: multiarch-validate-nodes | ||
| - as: disable-default-sources | ||
| from: cli | ||
| commands: |- | ||
| set -exuo pipefail | ||
| if test -f "${SHARED_DIR}/proxy-conf.sh"; then | ||
| source "${SHARED_DIR}/proxy-conf.sh" | ||
| fi | ||
| oc patch OperatorHub cluster --type json \ | ||
| -p '[{"op": "add", "path": "/spec/disableAllDefaultSources", "value": true}]' | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 100Mi | ||
| timeout: 5m0s | ||
| grace_period: 5m0s | ||
| env: | ||
| - name: MIRROR_IN_BASTION | ||
| default: "yes" | ||
| documentation: "Mirror images from the bastion host rather than the build farm." | ||
| - name: PUBLISH | ||
| default: "Internal" | ||
| documentation: "Cluster publish strategy for disconnected install." | ||
| - name: ADD_INGRESS_RECORDS_MANUALLY | ||
| default: "yes" | ||
| documentation: "Manually create ingress DNS records for private clusters." | ||
| - name: ZONES_COUNT | ||
| default: "2" | ||
| documentation: "Number of availability zones. Default 2 to avoid regions with fewer than 3 AZs." | ||
| documentation: |- | ||
| The ipi-aws-pre-disconnected chain provisions a fully disconnected | ||
| OpenShift cluster on AWS. It creates an isolated VPC with private subnets | ||
| and no direct internet access, a bastion host on the public subnet | ||
| providing a mirror registry, egress proxy, and SSH jump host, then | ||
| mirrors the release payload and installs the cluster using manual CCO | ||
| credentials. | ||
6 changes: 6 additions & 0 deletions
6
ci-operator/step-registry/openshift/e2e/aws/disconnected/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| approvers: | ||
| - deads2k | ||
| - dgoodwin | ||
| - stbenjam | ||
| - vrutkovs | ||
| - wking |
12 changes: 12 additions & 0 deletions
12
...stry/openshift/e2e/aws/disconnected/openshift-e2e-aws-disconnected-workflow.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "path": "openshift/e2e/aws/disconnected/openshift-e2e-aws-disconnected-workflow.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "deads2k", | ||
| "dgoodwin", | ||
| "stbenjam", | ||
| "vrutkovs", | ||
| "wking" | ||
| ] | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...step-registry/openshift/e2e/aws/disconnected/openshift-e2e-aws-disconnected-workflow.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| workflow: | ||
| as: openshift-e2e-aws-disconnected | ||
| steps: | ||
| allow_best_effort_post_steps: true | ||
| pre: | ||
| - chain: ipi-aws-pre-disconnected | ||
| test: | ||
| - ref: openshift-e2e-test | ||
| post: | ||
| - chain: gather-core-dump | ||
| - chain: ipi-aws-post-disconnected | ||
| documentation: |- | ||
| The openshift-e2e-aws-disconnected workflow executes the common end-to-end | ||
| test suite on a disconnected AWS cluster. The cluster is installed in a | ||
| private VPC with no direct internet access. A bastion host on the public | ||
| subnet provides a mirror registry, egress proxy, and SSH jump host. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove xtrace before sourcing proxy config to avoid secret leakage.
Line 27 enables
-x, and Line 29 sourcesproxy-conf.sh; this can print sensitive proxy values into job logs.🔒 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents