Skip to content

chore: update context path for maas-controller#77925

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ishitasequeira:update-maas-context-paths
Apr 17, 2026
Merged

chore: update context path for maas-controller#77925
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ishitasequeira:update-maas-context-paths

Conversation

@ishitasequeira
Copy link
Copy Markdown
Contributor

@ishitasequeira ishitasequeira commented Apr 16, 2026

update context path for maas-controller

Summary by CodeRabbit

  • Chores
    • Updated the build configuration for the maas-controller image to use an optimized Dockerfile path structure.

@openshift-ci openshift-ci Bot requested review from chaitanya1731 and noyitz April 16, 2026 15:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 659e0d28-c6e2-4e6b-b954-2c2868d94a98

📥 Commits

Reviewing files that changed from the base of the PR and between e0c42c3 and 83d7437.

📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/models-as-a-service/opendatahub-io-models-as-a-service-main.yaml

Walkthrough

A single build configuration file was updated to modify the Docker build context and Dockerfile path for the maas-controller image. The build context now starts from the repository root with the Dockerfile path adjusted accordingly, while the image output target remains unchanged.

Changes

Cohort / File(s) Summary
Build Configuration
ci-operator/config/opendatahub-io/models-as-a-service/opendatahub-io-models-as-a-service-main.yaml
Modified maas-controller build configuration: changed from context_dir: maas-controller/ + dockerfile_path: Dockerfile to context_dir: . + dockerfile_path: maas-controller/Dockerfile. Image target and promotion logic unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update context path for maas-controller' accurately summarizes the main change: updating the context path configuration for the maas-controller build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This custom check regarding stable and deterministic Ginkgo test names is not applicable to this PR. The PR modifies a CI/operator configuration YAML file that contains build and test workflow definitions for Docker images, not Ginkgo test definitions.
Test Structure And Quality ✅ Passed This custom check assesses Ginkgo test code quality, but the PR only modifies a CI/CD configuration YAML file with no test code changes.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration for container image building and contains no new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Pull request contains only CI/CD configuration changes with no new Ginkgo e2e tests, making the SNO Test Compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed CI configuration change updates Docker build context paths without affecting cluster scheduling or deployment manifests.
Ote Binary Stdout Contract ✅ Passed The pull request only modifies a YAML build configuration file with no code changes that could violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests, only modifies a CI operator configuration file to update Docker build context paths.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ishitasequeira: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-models-as-a-service-main-e2e-test-maas opendatahub-io/models-as-a-service presubmit Ci-operator config changed
pull-ci-opendatahub-io-models-as-a-service-main-images opendatahub-io/models-as-a-service presubmit Ci-operator config changed
pull-ci-opendatahub-io-models-as-a-service-main-pr-image-mirror-maas-api opendatahub-io/models-as-a-service presubmit Ci-operator config changed
pull-ci-opendatahub-io-models-as-a-service-main-pr-image-mirror-maas-controller opendatahub-io/models-as-a-service presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@chaitanya1731
Copy link
Copy Markdown
Contributor

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@chaitanya1731: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@chaitanya1731
Copy link
Copy Markdown
Contributor

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@chaitanya1731: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@chaitanya1731
Copy link
Copy Markdown
Contributor

We are not using e2e prow. so we can skip this test. LGTM

@chaitanya1731
Copy link
Copy Markdown
Contributor

/override ci/rehearse/opendatahub-io/models-as-a-service/main/e2e-test-maas

@chaitanya1731
Copy link
Copy Markdown
Contributor

/pj-rehearse ack
/lgtm

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@chaitanya1731: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 17, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

@chaitanya1731: chaitanya1731 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/rehearse/opendatahub-io/models-as-a-service/main/e2e-test-maas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaitanya1731, ishitasequeira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

@ishitasequeira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/models-as-a-service/main/e2e-test-maas 83d7437 link unknown /pj-rehearse pull-ci-opendatahub-io-models-as-a-service-main-e2e-test-maas

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 588b285 into openshift:main Apr 17, 2026
17 of 18 checks passed
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants