Skip to content

WINC-1869: replace WS2019 for WS2025 in azure-e2e job#77975

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jrvaldes:remove-azure-2019
Apr 17, 2026
Merged

WINC-1869: replace WS2019 for WS2025 in azure-e2e job#77975
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jrvaldes:remove-azure-2019

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Apr 17, 2026

This pull request updates the CI configuration for the Windows Machine Config Operator by removing all references to Windows Server 2019 end-to-end (e2e) Azure tests and associated periodic jobs, and migrating the remaining e2e tests to use Windows Server 2025. These changes ensure that only Windows Server 2025 is tested in the relevant release branches and that obsolete jobs are cleaned up.

Summary by CodeRabbit

  • Tests

    • Removed legacy Windows Server 2019 test job configurations across multiple release branches.
    • Updated Azure e2e test environment to use Windows Server 2025.
    • Removed duplicate periodic test job definitions.
  • Chores

    • Consolidated and updated CI/CD pipeline test configurations.

this commit removes Windows Server 2019 job references
and update to Windows Server 2025 from periodic to presubmit
in configuration files
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@jrvaldes jrvaldes changed the title wmco: replace WS2019 for WS2025 in azure-e2e job WINC-1869: replace WS2019 for WS2025 in azure-e2e job Apr 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 17, 2026

@jrvaldes: This pull request references WINC-1869 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "WMCO 10.22.0" instead.

Details

In response to this:

This pull request updates the CI configuration for the Windows Machine Config Operator by removing all references to Windows Server 2019 end-to-end (e2e) Azure tests and associated periodic jobs, and migrating the remaining e2e tests to use Windows Server 2025. These changes ensure that only Windows Server 2025 is tested in the relevant release branches and that obsolete jobs are cleaned up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b00317a-b1b2-44c3-9963-f4ff00a6a417

📥 Commits

Reviewing files that changed from the base of the PR and between de8e710 and 43cae01.

📒 Files selected for processing (7)
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.23.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-5.0.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-5.1.yaml
  • ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-periodics.yaml
  • ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22-periodics.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22-periodics.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22.yaml
  • ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-periodics.yaml

Walkthrough

Updates Windows Machine Config Operator CI pipeline configurations to deprecate Windows Server 2019 testing and standardize on Windows Server 2025. Changes include removing legacy 2019-based job definitions, deleting associated periodic cron jobs, and updating remaining test configurations to target the newer Windows Server version.

Changes

Cohort / File(s) Summary
Azure E2E 2019 job removal
ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml, ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22.yaml
Removed dual azure-e2e-operator job definitions: one targeting 2019 version and one scheduled cron job (0 2 * * 1) also using 2019. Both utilized openshift-org-azure cluster profile and ipi-azure-ovn-hybrid workflow.
Azure E2E 2025 version upgrade
ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.23.yaml, ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-5.0.yaml, ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-5.1.yaml
Updated WINDOWS_SERVER_VERSION environment variable from "2019" to "2025" in azure-e2e-operator test step configuration across 4.23, 5.0, and 5.1 release branches.
Periodic cron job removals
ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-periodics.yaml, ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.22-periodics.yaml
Deleted periodic-ci-openshift-windows-machine-config-operator-*-azure-e2e-operator-2025 job definitions (86 and 78 lines respectively) scheduled on cron 0 2 * * 1 targeting Azure cluster profiles with Windows 2019 configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing Windows Server 2019 with Windows Server 2025 in Azure e2e jobs, which is the primary objective across all modified CI configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI/CD configuration files, not Ginkgo test source code. No test names to evaluate against stability requirements.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality does not apply to this PR, which exclusively modifies CI configuration YAML files, not actual test code.
Microshift Test Compatibility ✅ Passed PR modifies only CI/CD configuration files without adding new Ginkgo e2e test code, so the check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains only YAML CI configuration changes for the Windows Machine Config Operator, with no new Ginkgo e2e test code added. The custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI operator job configuration files, not deployment manifests, operator code, or controllers that could introduce topology-aware scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check applies only to Go test binary code, and this PR contains exclusively CI configuration YAML file changes with no Go source code or test implementation modifications.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e test code. All modifications are CI/Prow configuration files (YAML) that define test scheduling and execution, not test source code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 17, 2026

@jrvaldes: This pull request references WINC-1869 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "WMCO 10.22.0" instead.

Details

In response to this:

This pull request updates the CI configuration for the Windows Machine Config Operator by removing all references to Windows Server 2019 end-to-end (e2e) Azure tests and associated periodic jobs, and migrating the remaining e2e tests to use Windows Server 2025. These changes ensure that only Windows Server 2025 is tested in the relevant release branches and that obsolete jobs are cleaned up.

Summary by CodeRabbit

  • Tests

  • Removed legacy Windows Server 2019 test job configurations across multiple release branches.

  • Updated Azure e2e test environment to use Windows Server 2025.

  • Removed duplicate periodic test job definitions.

  • Chores

  • Consolidated and updated CI/CD pipeline test configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jrvaldes: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-windows-machine-config-operator-release-5.1-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-4.22-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-5.0-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-4.23-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-release-5.0-azure-e2e-operator

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jrvaldes: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@mansikulkarni96
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 17, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 9f5fc93 into openshift:main Apr 17, 2026
18 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants