Skip to content

NO-JIRA: upkeep: add always run gather on edge clusters#77986

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:upkeep-always-gather-on-edge-clusters
Apr 17, 2026
Merged

NO-JIRA: upkeep: add always run gather on edge clusters#77986
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:upkeep-always-gather-on-edge-clusters

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented Apr 17, 2026

added always run flag for gather steps on tna/sno clusters added allow best effort to avoid failing the run when the post step fails

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configurations for bare metal deployment and OpenShift e2e test scenarios to modify step execution behavior, including enabling best-effort post-step execution in multiple workflows and disabling skip-on-success logic in others.

added always run flag for gather steps on tna/sno clusters
added allow best effort to avoid failing the run when the post step fails

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

added always run flag for gather steps on tna/sno clusters added allow best effort to avoid failing the run when the post step fails

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dhensel-rh and stbenjam April 17, 2026 17:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c8c88e1-1749-4228-9735-46d2a44464ee

📥 Commits

Reviewing files that changed from the base of the PR and between ce4eb48 and 10f5248.

📒 Files selected for processing (10)
  • ci-operator/step-registry/baremetalds/sno/baremetalds-sno-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/baremetalds-two-node-arbiter-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/e2e-openshift-test-private-tests/baremetalds-two-node-arbiter-e2e-openshift-test-private-tests-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/techpreview/baremetalds-two-node-arbiter-techpreview-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/upgrade/baremetalds-two-node-arbiter-upgrade-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/upgrade/day-2-workers/baremetalds-two-node-arbiter-upgrade-day-2-workers-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/workload-partitioning/baremetalds-two-node-arbiter-workload-partitioning-workflow.yaml
  • ci-operator/step-registry/openshift/e2e/aws/single-node/openshift-e2e-aws-single-node-workflow.yaml
  • ci-operator/step-registry/openshift/e2e/aws/single-node/recert/openshift-e2e-aws-single-node-recert-workflow.yaml
  • ci-operator/step-registry/openshift/e2e/aws/single-node/workers/openshift-e2e-aws-single-node-workers-workflow.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/step-registry/baremetalds/sno/baremetalds-sno-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/workload-partitioning/baremetalds-two-node-arbiter-workload-partitioning-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/techpreview/baremetalds-two-node-arbiter-techpreview-workflow.yaml
  • ci-operator/step-registry/baremetalds/two-node/arbiter/baremetalds-two-node-arbiter-workflow.yaml

Walkthrough

This pull request modifies CI operator workflow step configurations across baremetalds and OpenShift E2E testing workflows. Changes include removing the allow_skip_on_success flag from selected baremetalds workflows and adding the allow_best_effort_post_steps flag to multiple workflows for both baremetalds and OpenShift configurations.

Changes

Cohort / File(s) Summary
Baremetalds - Removed allow_skip_on_success
ci-operator/step-registry/baremetalds/sno/baremetalds-sno-workflow.yaml, ci-operator/step-registry/baremetalds/two-node/arbiter/baremetalds-two-node-arbiter-workflow.yaml, ci-operator/step-registry/baremetalds/two-node/arbiter/techpreview/baremetalds-two-node-arbiter-techpreview-workflow.yaml, ci-operator/step-registry/baremetalds/two-node/arbiter/workload-partitioning/baremetalds-two-node-arbiter-workload-partitioning-workflow.yaml
Removed the allow_skip_on_success step configuration flag from workflow definitions.
Baremetalds Two-Node Arbiter - Added allow_best_effort_post_steps
ci-operator/step-registry/baremetalds/two-node/arbiter/e2e-openshift-test-private-tests/baremetalds-two-node-arbiter-e2e-openshift-test-private-tests-workflow.yaml, ci-operator/step-registry/baremetalds/two-node/arbiter/upgrade/baremetalds-two-node-arbiter-upgrade-workflow.yaml, ci-operator/step-registry/baremetalds/two-node/arbiter/upgrade/day-2-workers/baremetalds-two-node-arbiter-upgrade-day-2-workers-workflow.yaml
Added allow_best_effort_post_steps: true to enable post-step execution on a best-effort basis.
OpenShift E2E AWS Single Node - Added allow_best_effort_post_steps
ci-operator/step-registry/openshift/e2e/aws/single-node/openshift-e2e-aws-single-node-workflow.yaml, ci-operator/step-registry/openshift/e2e/aws/single-node/recert/openshift-e2e-aws-single-node-recert-workflow.yaml, ci-operator/step-registry/openshift/e2e/aws/single-node/workers/openshift-e2e-aws-single-node-workers-workflow.yaml
Added allow_best_effort_post_steps: true to enable post-step execution on a best-effort basis.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding 'always run' flags for gather steps on edge clusters (baremetalds/SNO workflows).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Custom check for stable Ginkgo test names not applicable; PR modifies only CI/CD workflow YAML files without test definitions.
Test Structure And Quality ✅ Passed The custom check is not applicable to this pull request. The PR only contains modifications to YAML workflow configuration files, not Ginkgo test code.
Microshift Test Compatibility ✅ Passed PR modifies only CI/CD workflow YAML files without introducing any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies YAML workflow configuration files, not Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed Changes modify CI workflow configuration files, not deployment manifests or operator code with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML workflow configuration files in ci-operator/step-registry/. OTE Binary Stdout Contract check applies only to executable source code, not declarative configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Pull request modifies YAML workflow configurations only; no new Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-5.1-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-5.0-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.23-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.22-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.18-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.17-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.16-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.15-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.14-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.13-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.12-e2e-aws-ovn-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-aws-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.10-e2e-aws-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.9-e2e-aws-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.8-e2e-aws-single-node openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-console-operator-main-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-5.1-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-5.0-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.23-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.22-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.21-e2e-aws-ovn-single-node openshift/console-operator presubmit Registry content changed

A total of 687 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jaypoulz
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-bootstrap/release-5.1/e2e-metal-single-node-live-iso 10f5248 link unknown /pj-rehearse pull-ci-openshift-cluster-bootstrap-release-5.1-e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 17, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 884aac7 into openshift:main Apr 17, 2026
15 of 16 checks passed
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
added always run flag for gather steps on tna/sno clusters
added allow best effort to avoid failing the run when the post step fails

Signed-off-by: ehila <ehila@redhat.com>
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
added always run flag for gather steps on tna/sno clusters
added allow best effort to avoid failing the run when the post step fails

Signed-off-by: ehila <ehila@redhat.com>
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
added always run flag for gather steps on tna/sno clusters
added allow best effort to avoid failing the run when the post step fails

Signed-off-by: ehila <ehila@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants