Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @rachelvweber. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe changes update Azure ARO-RP CI/CD test configuration to rename E2E parallel test variants and introduce MIWI (Managed Identity with Workload Identity) support alongside existing CSP variants. New Boskos resource quotas are created to support MSI container lease management across integration, staging, and production environments. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rachelvweber The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml (1)
97-103:⚠️ Potential issue | 🟡 MinorMissing
optional: trueon the deve2e-parallel-cspentry.All other test entries in this file set
optional: true, and the previouse2e-parallelentry likely did too. If the omission here is intentional (i.e., the dev variant should actually gate PRs), disregard — otherwise add it for consistency.Proposed fix
- always_run: false as: e2e-parallel-csp + optional: true steps: cluster_profile: aro-classic-dev🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml` around lines 97 - 103, The e2e-parallel-csp job is missing the optional flag; update the job block that has "as: e2e-parallel-csp" (workflow: aro-classic-e2e, cluster_profile: aro-classic-dev) to include "optional: true" so it matches the other test entries and does not gate PRs unintentionally.
🧹 Nitpick comments (1)
ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yaml (1)
1-637: Prowgen-generated file—recommend regenerating via standard flow.This file carries the
ci.openshift.io/generator: prowgenlabel and is intended to be regenerated from the ci-operator config rather than hand-edited. Verification confirms the seven test targets in the config (e2e-parallel-csp,integration-e2e-parallel-csp,integration-e2e-parallel-miwi,prod-e2e-parallel-csp,prod-e2e-parallel-miwi,stage-e2e-parallel-csp,stage-e2e-parallel-miwi) all have matching presubmits with correct--targetvalues, trigger patterns, andoptional/always_runflags.The Boskos resource types
aro-classic-test-msi-containers-{int,stg,prod}required by the MIWI variants are already declared incore-services/prow/02_config/_boskos.yamlwith 50 numbered instances (0–49) each.Regenerate this file via
make jobsorci-operator-prowgento ensure byte-for-byte consistency with the canonical config and to guarantee any additional fields (e.g.,max_concurrency,pathAlias) are included if defined upstream.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yaml` around lines 1 - 637, This file is prowgen-generated and should not be hand-edited; regenerate it to restore canonical output: run the standard generation flow (e.g. make jobs or ci-operator-prowgen) to recreate Azure/ARO-RP presubmits so that the ci.openshift.io/generator: prowgen label, the seven targets (e2e-parallel-csp, integration-e2e-parallel-csp, integration-e2e-parallel-miwi, prod-e2e-parallel-csp, prod-e2e-parallel-miwi, stage-e2e-parallel-csp, stage-e2e-parallel-miwi), their --target args, trigger regexes, optional/always_run flags, and any missing fields like max_concurrency or pathAlias match the canonical ci-operator config and the Boskos resource declarations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml`:
- Around line 97-103: The e2e-parallel-csp job is missing the optional flag;
update the job block that has "as: e2e-parallel-csp" (workflow: aro-classic-e2e,
cluster_profile: aro-classic-dev) to include "optional: true" so it matches the
other test entries and does not gate PRs unintentionally.
---
Nitpick comments:
In `@ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yaml`:
- Around line 1-637: This file is prowgen-generated and should not be
hand-edited; regenerate it to restore canonical output: run the standard
generation flow (e.g. make jobs or ci-operator-prowgen) to recreate Azure/ARO-RP
presubmits so that the ci.openshift.io/generator: prowgen label, the seven
targets (e2e-parallel-csp, integration-e2e-parallel-csp,
integration-e2e-parallel-miwi, prod-e2e-parallel-csp, prod-e2e-parallel-miwi,
stage-e2e-parallel-csp, stage-e2e-parallel-miwi), their --target args, trigger
regexes, optional/always_run flags, and any missing fields like max_concurrency
or pathAlias match the canonical ci-operator config and the Boskos resource
declarations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ea088835-fd1f-46af-8a66-78104b27c89c
📒 Files selected for processing (4)
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yamlci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yamlcore-services/prow/02_config/_boskos.yamlcore-services/prow/02_config/generate-boskos.py
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/pj-rehearse pull-ci-Azure-ARO-RP-master-prod-e2e-parallel-miwi |
|
@rachelvweber: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rachelvweber: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Adding MIWI tests to aro e2e
Summary by CodeRabbit
Release Notes