Refactor openshift e2e aws capi workflow#78001
Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom Apr 20, 2026
Merged
Refactor openshift e2e aws capi workflow#78001openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Member
Author
|
/pj-rehearse ? |
Contributor
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new openshift-e2e-aws-techpreview-post-install workflow, retargets/renames many AWS e2e test aliases and presubmit jobs (e2e-aws-capi-techpreview → e2e-aws-operator → e2e-aws-techpreview-post-install), and introduces a wait-for-stable-cluster step with scripts/metadata/OWNERS. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub (PR)
participant Prow as Prow
participant CI as ci-operator
participant SR as Step Registry / Workflow
participant OC as oc (wait-for-stable-cluster)
participant E2E as e2e test runner
GH->>Prow: push / comment trigger
Prow->>CI: start job (--target=e2e-aws-techpreview-post-install)
CI->>SR: execute workflow (pre → test → post)
SR->>CI: run ipi-install (pre)
SR->>OC: invoke openshift-oc-wait-for-stable-cluster
OC->>SR: report stable / timeout
SR->>E2E: run openshift-e2e-test
SR->>CI: run post steps (gather, ipi-aws-post)
CI->>Prow: report job result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
@damdo: job(s): ? either don't exist or were not found to be affected, and cannot be rehearsed |
Member
Author
|
/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-aws-techpreview-post-install |
Contributor
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml`:
- Around line 1-21: The ref uses the generic CLI image but the command oc adm
wait-for-stable-cluster is only available in newer CLIs; change the ref to
require a 4.14+ CLI by pinning the image (e.g. replace "from: cli" with a 4.14+
tag such as "from: cli:4.14" or otherwise gate this ref to CLI images >=4.14) so
openshift-oc-wait-for-stable-cluster (commands:
openshift-oc-wait-for-stable-cluster-commands.sh) only runs with a CLI that
includes oc adm wait-for-stable-cluster; alternatively add a runtime
check/fallback in the commands script to skip or use another method when the CLI
is older.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ca8d2b05-4991-4351-b3a1-e0524cee8dd1
📒 Files selected for processing (92)
ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.13.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.14.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.17.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yamlci-operator/config/openshift-priv/cluster-capi-operator/openshift-priv-cluster-capi-operator-release-4.11.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.13.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.14.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.15.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.16.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.17.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.18.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.19.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.20.yamlci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-release-4.11.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/step-registry/openshift/e2e/aws/capi/OWNERSci-operator/step-registry/openshift/e2e/aws/capi/openshift-e2e-aws-capi-workflow.metadata.jsonci-operator/step-registry/openshift/e2e/aws/capi/openshift-e2e-aws-capi-workflow.yamlci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/OWNERSci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.metadata.jsonci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.yamlci-operator/step-registry/openshift/oc/wait-for-stable-cluster/OWNERSci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.shci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.metadata.jsonci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml
💤 Files with no reviewable changes (3)
- ci-operator/step-registry/openshift/e2e/aws/capi/OWNERS
- ci-operator/step-registry/openshift/e2e/aws/capi/openshift-e2e-aws-capi-workflow.metadata.json
- ci-operator/step-registry/openshift/e2e/aws/capi/openshift-e2e-aws-capi-workflow.yaml
damdo
force-pushed
the
refactor-openshift-e2e-aws-capi-workflow
branch
from
07ebdee to
78088d7
Compare
Member
Author
|
/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-aws-techpreview-post-install |
Contributor
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
damdo
force-pushed
the
refactor-openshift-e2e-aws-capi-workflow
branch
from
2ffd205 to
83cc34d
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/retest |
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yaml (1)
274-363:⚠️ Potential issue | 🟠 MajorUpdate the release-4.11 ci-operator config to use the new workflow.
At
ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yamlline 95, thee2e-aws-techpreview-post-installtest still referencesworkflow: openshift-e2e-aws-capi. This must be changed toworkflow: openshift-e2e-aws-techpreview-post-installto match the presubmit job definition.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yaml` around lines 274 - 363, The ci-operator config's test definition for e2e-aws-techpreview-post-install still sets workflow: openshift-e2e-aws-capi; update that key to workflow: openshift-e2e-aws-techpreview-post-install so the test configuration matches the presubmit job (ensure you edit the e2e-aws-techpreview-post-install test block and replace the workflow string accordingly).ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yaml (1)
90-108:⚠️ Potential issue | 🟠 Major
e2e-aws-operatorstill points to upgrade coverage on 4.20.Lines 90-108 retarget this presubmit to
--target=e2e-aws-operator, butci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yamlstill defines that target withworkflow: openshift-upgrade-aws. That makes/test e2e-aws-operatorrun the upgrade flow instead of the operator suite this rename implies, so 4.20 loses the intended operator presubmit unless the backing test definition is updated too.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yaml` around lines 90 - 108, The presubmit now sets --target=e2e-aws-operator but the ci-operator job definition in ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yaml still maps that target to workflow: openshift-upgrade-aws, so the upgrade flow runs instead of the operator suite; update the 4.20 ci-operator job definition so that the e2e-aws-operator target points to the correct operator workflow (replace workflow: openshift-upgrade-aws with the operator e2e workflow used by other releases or add a new target mapping that invokes the operator suite) ensuring the target name (--target=e2e-aws-operator) and workflow key are consistent with the intended operator presubmit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yaml`:
- Around line 274-363: The ci-operator config's test definition for
e2e-aws-techpreview-post-install still sets workflow: openshift-e2e-aws-capi;
update that key to workflow: openshift-e2e-aws-techpreview-post-install so the
test configuration matches the presubmit job (ensure you edit the
e2e-aws-techpreview-post-install test block and replace the workflow string
accordingly).
In
`@ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yaml`:
- Around line 90-108: The presubmit now sets --target=e2e-aws-operator but the
ci-operator job definition in
ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yaml
still maps that target to workflow: openshift-upgrade-aws, so the upgrade flow
runs instead of the operator suite; update the 4.20 ci-operator job definition
so that the e2e-aws-operator target points to the correct operator workflow
(replace workflow: openshift-upgrade-aws with the operator e2e workflow used by
other releases or add a new target mapping that invokes the operator suite)
ensuring the target name (--target=e2e-aws-operator) and workflow key are
consistent with the intended operator presubmit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 32f47b0f-fbf8-4e1f-a813-7cdd115d13dc
📒 Files selected for processing (85)
ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.14.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.17.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.14.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.15.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.16.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.17.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.18.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.19.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.20.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/OWNERSci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.metadata.jsonci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.yamlci-operator/step-registry/openshift/oc/wait-for-stable-cluster/OWNERSci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.shci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.metadata.jsonci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml
✅ Files skipped from review due to trivial changes (15)
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/OWNERS
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.17.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.metadata.json
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.20.yaml
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.metadata.json
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.15.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yaml
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.14.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/OWNERS
🚧 Files skipped from review as they are similar to previous changes (46)
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.17.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.19.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.16.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.18.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.14.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22-presubmits.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12-presubmits.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22-presubmits.yaml
Member
Author
|
/retest |
Configurable wrapper around oc adm wait-for-stable-cluster for use as a reusable step in CI workflows. Supports MINIMUM_STABLE_PERIOD and TIMEOUT env vars. Intended for use after cluster state changes such as enabling FeatureSets post-install.
Replace capi-conf-apply-feature-gate with ipi-install-post-featureset and openshift-oc-wait-for-stable-cluster. This uses the standard post-install FeatureSet enablement step and a proper cluster stability check instead of a custom script with hand-rolled operator waits.
…ew-post-install The old name implied this was CAPI-specific, but the workflow actually tests the day-1 TechPreview enablement path on a standard AWS cluster. The new name clearly distinguishes it from the day-0 variant (openshift-e2e-aws-techpreview) which installs with TechPreview from the start.
…echpreview-post-install Align the job name with the renamed workflow. The test enables TechPreview post-install, not CAPI specifically.
damdo
force-pushed
the
refactor-openshift-e2e-aws-capi-workflow
branch
from
83cc34d to
ba3f054
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.sh`:
- Around line 9-11: The failure message printed when the command check for "oc
adm wait-for-stable-cluster" fails should go to stderr instead of stdout; update
the error branch where the script tests "if ! oc adm wait-for-stable-cluster
--help &>/dev/null; then" to write the message to stderr (e.g., use echo "oc adm
wait-for-stable-cluster is not available in this release" >&2) and keep the exit
1 behavior intact so tooling receives the error signal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 48044f86-77d2-4e7a-8b30-cfc45b035243
📒 Files selected for processing (85)
ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.14.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.17.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yamlci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.14.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.15.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.16.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.17.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.18.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.19.yamlci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.20.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0-presubmits.yamlci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1-presubmits.yamlci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/OWNERSci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.metadata.jsonci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.yamlci-operator/step-registry/openshift/oc/wait-for-stable-cluster/OWNERSci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.shci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.metadata.jsonci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml
✅ Files skipped from review due to trivial changes (18)
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/OWNERS
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.16.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.16.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/OWNERS
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.metadata.json
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.metadata.json
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.18.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.14.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.22-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19-presubmits.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.15.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13-presubmits.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yaml
- ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-ref.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15-presubmits.yaml
🚧 Files skipped from review as they are similar to previous changes (46)
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-main.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.19.yaml
- ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.20.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.21.yaml
- ci-operator/config/openshift/cluster-api-operator/openshift-cluster-api-operator-release-4.17.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.0.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.22.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.20.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.23.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.23.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.16.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.17-presubmits.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.20.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.0.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.15.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.18.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-5.1-presubmits.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-5.1.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.19.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14-presubmits.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.15-presubmits.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.14.yaml
- ci-operator/step-registry/openshift/e2e/aws/techpreview/post-install/openshift-e2e-aws-techpreview-post-install-workflow.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.17-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.14-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.18-presubmits.yaml
- ci-operator/jobs/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.19-presubmits.yaml
- ci-operator/jobs/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.21-presubmits.yaml
Releases 4.11-4.13 use a CLI that may not include oc adm wait-for-stable-cluster, so keep them on the original openshift-e2e-aws-capi workflow with capi-conf-apply-feature-gate. Also add a runtime check to openshift-oc-wait-for-stable-cluster to fail gracefully when the subcommand is not available.
damdo
force-pushed
the
refactor-openshift-e2e-aws-capi-workflow
branch
from
ba3f054 to
9af3727
Compare
Contributor
|
[REHEARSALNOTIFIER]
A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.sh (1)
9-11:⚠️ Potential issue | 🟡 MinorWrite the unavailable-command error to stderr.
Line 10 is an error path; sending this to stderr makes CI/log parsing more reliable.
🔧 Proposed fix
if ! oc adm wait-for-stable-cluster --help &>/dev/null; then - echo "oc adm wait-for-stable-cluster is not available in this release" + echo "oc adm wait-for-stable-cluster is not available in this release" >&2 exit 1 fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.sh` around lines 9 - 11, The script currently prints the "oc adm wait-for-stable-cluster is not available in this release" message to stdout; change the error path in the conditional that checks oc adm wait-for-stable-cluster (the block containing the oc adm wait-for-stable-cluster --help check and the echo/exit) so the message is written to stderr (e.g., use echo ... >&2 or equivalent) to ensure CI/log parsers treat it as an error.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@ci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.sh`:
- Around line 9-11: The script currently prints the "oc adm
wait-for-stable-cluster is not available in this release" message to stdout;
change the error path in the conditional that checks oc adm
wait-for-stable-cluster (the block containing the oc adm wait-for-stable-cluster
--help check and the echo/exit) so the message is written to stderr (e.g., use
echo ... >&2 or equivalent) to ensure CI/log parsers treat it as an error.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 43fc8f89-eadf-4740-b57f-79f16112f7df
📒 Files selected for processing (7)
ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.13.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yamlci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yamlci-operator/step-registry/openshift/oc/wait-for-stable-cluster/openshift-oc-wait-for-stable-cluster-commands.sh
✅ Files skipped from review due to trivial changes (2)
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.13.yaml
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.11.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
- ci-operator/config/openshift/cluster-machine-approver/openshift-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yaml
- ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yaml
Contributor
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/pj-rehearse ack |
Contributor
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Member
Author
|
/assign @JoelSpeed @theobarberbany |
Contributor
|
/approve |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, JoelSpeed, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This was referenced Apr 20, 2026
Prucek
pushed a commit
to Prucek/release
that referenced
this pull request
Apr 29, 2026
* Add openshift-oc-wait-for-stable-cluster step to step-registry Configurable wrapper around oc adm wait-for-stable-cluster for use as a reusable step in CI workflows. Supports MINIMUM_STABLE_PERIOD and TIMEOUT env vars. Intended for use after cluster state changes such as enabling FeatureSets post-install. * Update openshift-e2e-aws-capi workflow to use shared steps Replace capi-conf-apply-feature-gate with ipi-install-post-featureset and openshift-oc-wait-for-stable-cluster. This uses the standard post-install FeatureSet enablement step and a proper cluster stability check instead of a custom script with hand-rolled operator waits. * Rename openshift-e2e-aws-capi workflow to openshift-e2e-aws-techpreview-post-install The old name implied this was CAPI-specific, but the workflow actually tests the day-1 TechPreview enablement path on a standard AWS cluster. The new name clearly distinguishes it from the day-0 variant (openshift-e2e-aws-techpreview) which installs with TechPreview from the start. * Rename cluster-machine-approver e2e-aws-capi-techpreview to e2e-aws-techpreview-post-install Align the job name with the renamed workflow. The test enables TechPreview post-install, not CAPI specifically. * Keep openshift-e2e-aws-capi workflow for releases 4.11-4.13 Releases 4.11-4.13 use a CLI that may not include oc adm wait-for-stable-cluster, so keep them on the original openshift-e2e-aws-capi workflow with capi-conf-apply-feature-gate. Also add a runtime check to openshift-oc-wait-for-stable-cluster to fail gracefully when the subcommand is not available.
BATMAN-JD
pushed a commit
to BATMAN-JD/release
that referenced
this pull request
May 1, 2026
* Add openshift-oc-wait-for-stable-cluster step to step-registry Configurable wrapper around oc adm wait-for-stable-cluster for use as a reusable step in CI workflows. Supports MINIMUM_STABLE_PERIOD and TIMEOUT env vars. Intended for use after cluster state changes such as enabling FeatureSets post-install. * Update openshift-e2e-aws-capi workflow to use shared steps Replace capi-conf-apply-feature-gate with ipi-install-post-featureset and openshift-oc-wait-for-stable-cluster. This uses the standard post-install FeatureSet enablement step and a proper cluster stability check instead of a custom script with hand-rolled operator waits. * Rename openshift-e2e-aws-capi workflow to openshift-e2e-aws-techpreview-post-install The old name implied this was CAPI-specific, but the workflow actually tests the day-1 TechPreview enablement path on a standard AWS cluster. The new name clearly distinguishes it from the day-0 variant (openshift-e2e-aws-techpreview) which installs with TechPreview from the start. * Rename cluster-machine-approver e2e-aws-capi-techpreview to e2e-aws-techpreview-post-install Align the job name with the renamed workflow. The test enables TechPreview post-install, not CAPI specifically. * Keep openshift-e2e-aws-capi workflow for releases 4.11-4.13 Releases 4.11-4.13 use a CLI that may not include oc adm wait-for-stable-cluster, so keep them on the original openshift-e2e-aws-capi workflow with capi-conf-apply-feature-gate. Also add a runtime check to openshift-oc-wait-for-stable-cluster to fail gracefully when the subcommand is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores