Skip to content

NTOP: fixing jobs time#78005

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eifrach:NROP_change_time
Apr 19, 2026
Merged

NTOP: fixing jobs time#78005
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eifrach:NROP_change_time

Conversation

@eifrach
Copy link
Copy Markdown
Contributor

@eifrach eifrach commented Apr 19, 2026

  • fix job time
  • add missing job

Summary by CodeRabbit

  • Chores
    • Added support for testing new OpenShift versions 4.16 and 4.18 in the compute-nrop test suite
    • Adjusted test execution schedules for existing OpenShift versions to optimize testing timelines

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@eifrach has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 42 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 42 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ef5e9c40-5fe2-44d3-a4d0-b753a52f1976

📥 Commits

Reviewing files that changed from the base of the PR and between ea98e46 and b9e84f1.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__compute-nrop.yaml
  • ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yaml

Walkthrough

These changes update CI operator test configurations for the eco-ci-cd OpenShift project, adding periodic test schedules for OpenShift versions 4.16 and 4.18, updating cron schedules for existing tests, and reorganizing test job definitions across version variants.

Changes

Cohort / File(s) Summary
CI/CD Test Scheduling
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__compute-nrop.yaml, ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yaml
Updated cron schedules for multiple existing test entries; added new periodic test jobs for OpenShift 4.16 and 4.18 versions; removed prod-4-14 test block and replaced it with prod-4-16; adjusted day-of-week and time values across stage/prod variants; added complete periodic job definitions with decoration config, refs, labels, and spec containers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adjusting cron schedules and adding new periodic jobs for NROP tests across multiple versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR modifies CI/CD configuration files (YAML-based OpenShift CI operator configs) with static test identifiers and cron schedules, not Ginkgo test source code. The custom check applies only to Ginkgo test titles in test source code, which are not present.
Test Structure And Quality ✅ Passed This PR modifies only YAML CI/CD configuration files, not Ginkgo test code, so the Ginkgo test code review check is not applicable.
Microshift Test Compatibility ✅ Passed Modified files are CI configuration YAML files defining job scheduling and parameters, not Ginkgo e2e test code. The check targets new test implementations, not CI configuration.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e test code. It only modifies YAML configuration files in ci-operator/ directories that schedule and configure test execution, updating cron schedules and adding periodic job definitions.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI/CD configuration files with cron schedules for tests. Custom check applies only to deployment manifests, operator code, or controllers with topology-aware scheduling constraints, which are not present here.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR as it only modifies YAML configuration files with no Go source code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only YAML configuration files for CI job scheduling, not new Ginkgo test code with IPv4 or connectivity assumptions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- fix job time
- add missing job

Signed-off-by: Eran Ifrach <eifrach@redhat.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eifrach: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.1-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.0-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.23-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.21-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.20-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.19-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.18-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.17-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.16-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.15-e2e-telco5g-cnftests openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-svt-master-reliability-v2-rosa-4.17-nightly-x86-reliability-v2-20h openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-reliability-v2-rosa-4.17-nightly-x86-reliability-v2-1h openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-reliability-v2-rosa_hcp-4.17-nightly-x86-reliability-v2-20h openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-reliability-v2-rosa_hcp-4.17-nightly-x86-reliability-v2-1h openshift/svt presubmit Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-5.1-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-5.0-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.23-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-metal-single-node-live-iso openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-5.1-e2e-metal-single-node-live-iso openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-5.0-e2e-metal-single-node-live-iso openshift/installer presubmit Registry content changed

A total of 1560 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-tests-cache-nightly
periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-tests-cache-nightly-arm
pull-ci-openshift-psap-fournos-main-fournos
pull-ci-openshift-psap-forge-main-fournos
pull-ci-openshift-psap-forge-main-jump-ci
pull-ci-openshift-psap-forge-main-jump-ci-plot

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eifrach
Copy link
Copy Markdown
Contributor Author

eifrach commented Apr 19, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eifrach: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Apr 19, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eifrach: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-16 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-18 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-20 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-21 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-14 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-21 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-20 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-14 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-16 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-19 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-18 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-19 N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eifrach
Copy link
Copy Markdown
Contributor Author

eifrach commented Apr 19, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eifrach: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 19, 2026
Copy link
Copy Markdown
Contributor

@shaior shaior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, shaior

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eifrach
Copy link
Copy Markdown
Contributor Author

eifrach commented Apr 19, 2026

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 19, 2026

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 01acd94 into openshift:main Apr 19, 2026
16 checks passed
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
- fix job time
- add missing job

Signed-off-by: Eran Ifrach <eifrach@redhat.com>
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
- fix job time
- add missing job

Signed-off-by: Eran Ifrach <eifrach@redhat.com>
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
- fix job time
- add missing job

Signed-off-by: Eran Ifrach <eifrach@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants