Skip to content

OTA-1978: core-services/prow/02_config/openshift/agentic-skills: Initialize directory#78069

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wking:agentic-skills-prow-config
Apr 20, 2026
Merged

OTA-1978: core-services/prow/02_config/openshift/agentic-skills: Initialize directory#78069
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wking:agentic-skills-prow-config

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Apr 20, 2026

Based on similar content for the similarly-new cluster-update-console-plugin repository which landed in de87d74 (#77093), but with the appropriate repo name (agentic-skills) and the current agentic-skills root owner/approvers.

Summary by CodeRabbit

  • Chores
    • Configured repository-level PR approval workflow with designated approvers and reviewers; enabled approve and lgtm plugin behaviors.
    • Added automated merge criteria: PRs must have approved, lgtm, verified, and valid-JIRA labels and are blocked from merging when specific do-not-merge or backport-related labels are present.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 20, 2026

@wking: This pull request references OTA-1978 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Based on similar content for the similarly-new cluster-update-console-plugin repository which landed in e87d744b63 (#77093), but with the appropriate repo name (agentic-skills) and the current agentic-skills root owner/approvers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d68fa8d-db38-4067-97e5-4138fe1348fa

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae7822 and d9cd3aa.

📒 Files selected for processing (3)
  • core-services/prow/02_config/openshift/agentic-skills/OWNERS
  • core-services/prow/02_config/openshift/agentic-skills/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
✅ Files skipped from review due to trivial changes (3)
  • core-services/prow/02_config/openshift/agentic-skills/OWNERS
  • core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
  • core-services/prow/02_config/openshift/agentic-skills/_pluginconfig.yaml

Walkthrough

Adds three new Prow configuration files for the openshift/agentic-skills repository: an OWNERS file, a repository-scoped _pluginconfig.yaml enabling approve and lgtm behaviors, and a _prowconfig.yaml Tide query defining required and disqualifying labels for merges.

Changes

Cohort / File(s) Summary
Agentic Skills Repository Setup
core-services/prow/02_config/openshift/agentic-skills/OWNERS, core-services/prow/02_config/openshift/agentic-skills/_pluginconfig.yaml, core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
New configuration files establishing Prow governance for openshift/agentic-skills: OWNERS designates harche and mrunalp as approvers/reviewers; _pluginconfig.yaml configures approve (require_self_approval: false) and lgtm (review_acts_as_lgtm: true) for the repo; _prowconfig.yaml adds a Tide query requiring approved, lgtm, verified, and jira/valid-reference labels and excluding several do-not-merge and other disqualifying labels.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: initializing the agentic-skills Prow configuration directory with OWNERS, plugin, and tide configs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR adds only Prow configuration files (YAML) with no Ginkgo test code or Go test files, making the unstable test name check not applicable.
Test Structure And Quality ✅ Passed PR contains only Prow configuration files with no Ginkgo test code, so the test quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR adds only Prow CI configuration files (OWNERS, _pluginconfig.yaml, _prowconfig.yaml) with no Ginkgo e2e test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This check is not applicable to this pull request. The PR adds Prow CI/CD configuration files (OWNERS, _pluginconfig.yaml, and _prowconfig.yaml) for the agentic-skills repository, not Ginkgo e2e tests. The shell script verification confirms no Ginkgo test patterns (It(), Describe(), Context(), When(), etc.) are present in any of the files being added. The SNO Test Compatibility check specifically applies when new Ginkgo test patterns are added, which is not the case here.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds Prow CI/CD configuration files (_pluginconfig.yaml, _prowconfig.yaml, OWNERS) which do not contain Kubernetes workload specifications or topology-dependent resources.
Ote Binary Stdout Contract ✅ Passed PR adds only Prow configuration files (OWNERS, _pluginconfig.yaml, _prowconfig.yaml) with no Go code or OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only Prow configuration files (OWNERS, _pluginconfig.yaml, _prowconfig.yaml) with no Ginkgo e2e test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@wking wking force-pushed the agentic-skills-prow-config branch from d0a74fa to 1ae7822 Compare April 20, 2026 22:16
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 20, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@core-services/prow/02_config/openshift/agentic-skills/OWNERS`:
- Line 2: The generated OWNERS header contains a stale source reference
"https://github.com/openshift/cluster-update-console-plugin" — update that
header line to point to the correct source repository for this repo (or remove
the fetched-from line entirely) so future syncs/regeneration checks are not
misled; modify the OWNERS header string accordingly to reflect the actual source
repo or omit the fetched-from metadata.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 81c8aa64-51c9-4049-8f6a-119067921800

📥 Commits

Reviewing files that changed from the base of the PR and between be1758d and d0a74fa.

📒 Files selected for processing (3)
  • core-services/prow/02_config/openshift/agentic-skills/OWNERS
  • core-services/prow/02_config/openshift/agentic-skills/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml

Comment thread core-services/prow/02_config/openshift/agentic-skills/OWNERS Outdated
@wking wking force-pushed the agentic-skills-prow-config branch from 1ae7822 to d9cd3aa Compare April 20, 2026 22:21
…ectory

Based on similar content for the similarly-new
cluster-update-console-plugin repository which landed in de87d74
(OTA-1896: Add a configuration for the
openshift/cluster-update-console-plugin repository, 2026-04-07, openshift#77093),
but with the appropriate repo name (agentic-skills) and the current
agentic-skills root owner/approvers.
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wking: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 2f11fbd into openshift:main Apr 20, 2026
12 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

@wking: Updated the following 3 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-agentic-skills-_pluginconfig.yaml using file core-services/prow/02_config/openshift/agentic-skills/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-agentic-skills-_prowconfig.yaml using file core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-agentic-skills-_prowconfig.yaml using file core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
Details

In response to this:

Based on similar content for the similarly-new cluster-update-console-plugin repository which landed in de87d74 (#77093), but with the appropriate repo name (agentic-skills) and the current agentic-skills root owner/approvers.

Summary by CodeRabbit

  • Chores
  • Configured repository-level PR approval workflow with designated approvers and reviewers; enabled approve and lgtm plugin behaviors.
  • Added automated merge criteria: PRs must have approved, lgtm, verified, and valid-JIRA labels and are blocked from merging when specific do-not-merge or backport-related labels are present.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wking wking deleted the agentic-skills-prow-config branch April 20, 2026 23:20
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
…ectory (openshift#78069)

Based on similar content for the similarly-new
cluster-update-console-plugin repository which landed in de87d74
(OTA-1896: Add a configuration for the
openshift/cluster-update-console-plugin repository, 2026-04-07, openshift#77093),
but with the appropriate repo name (agentic-skills) and the current
agentic-skills root owner/approvers.
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
…ectory (openshift#78069)

Based on similar content for the similarly-new
cluster-update-console-plugin repository which landed in de87d74
(OTA-1896: Add a configuration for the
openshift/cluster-update-console-plugin repository, 2026-04-07, openshift#77093),
but with the appropriate repo name (agentic-skills) and the current
agentic-skills root owner/approvers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants