Use pre-built CAPIO e2e image#78127
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughCI job configs updated to run E2E tests via Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/cluster-api/openshift-cluster-api-master.yaml (1)
64-65: Consider a shared step/chain to reduce config drift.These test stanzas are nearly identical; extracting to a reusable registry
ref/chainwould simplify maintenance across providers.Also applies to: 79-80, 93-94, 107-108, 121-122
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift/cluster-api/openshift-cluster-api-master.yaml` around lines 64 - 65, Multiple nearly identical pipeline steps use the same commands and image (commands: /test.sh and from: stable:cluster-capi-operator-e2e-tests); extract these into a single reusable step/chain (e.g., create a registry entry like ref: ci/shared/steps/capi-e2e or a chain named capi-e2e-tests) and replace each duplicated stanza with a reference to that shared ref/chain; ensure the new shared step preserves the environment, timeout and any labels/metadata and update all occurrences that currently use "commands: /test.sh" and "from: stable:cluster-capi-operator-e2e-tests" to reference the shared definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ci-operator/config/openshift/cluster-api/openshift-cluster-api-master.yaml`:
- Around line 64-65: Multiple nearly identical pipeline steps use the same
commands and image (commands: /test.sh and from:
stable:cluster-capi-operator-e2e-tests); extract these into a single reusable
step/chain (e.g., create a registry entry like ref: ci/shared/steps/capi-e2e or
a chain named capi-e2e-tests) and replace each duplicated stanza with a
reference to that shared ref/chain; ensure the new shared step preserves the
environment, timeout and any labels/metadata and update all occurrences that
currently use "commands: /test.sh" and "from:
stable:cluster-capi-operator-e2e-tests" to reference the shared definition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f171b8ba-fbcb-4087-901e-feb93d11070b
📒 Files selected for processing (6)
ci-operator/config/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-main.yamlci-operator/config/openshift/cluster-api-provider-nutanix/openshift-cluster-api-provider-nutanix-main.yamlci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yamlci-operator/config/openshift/cluster-api-provider-vsphere/openshift-cluster-api-provider-vsphere-master.yamlci-operator/config/openshift/cluster-api/openshift-cluster-api-master.yamlci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse |
|
@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml`:
- Around line 19-21: The PR currently contains a “For testing only, DNM” comment
and commented-out dockerfile lines (the commented block containing
"dockerfile_path: Dockerfile.e2e" and "to: cluster-capi-operator-e2e-tests");
remove the DNM text and either delete the commented-out Dockerfile.e2e lines if
they are obsolete or replace them with the intended configuration (or add a
clarifying inline note that this dockerfile_literal replaces the external
Dockerfile) so the manifest in openshift-cluster-capi-operator-main.yaml
accurately reflects the final desired state for merge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6186633a-ce35-419b-9f0f-cd4c6e578b77
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml
| # - dockerfile_path: Dockerfile.e2e | ||
| # to: cluster-capi-operator-e2e-tests | ||
| # For testing only, DNM |
There was a problem hiding this comment.
The "DNM" (Do Not Merge) comment indicates this PR is not ready for merge.
Line 21 explicitly states "For testing only, DNM" which contradicts the PR being submitted for review. Before merging:
- Remove the commented-out
Dockerfile.e2elines if they're no longer needed - Remove the "For testing only, DNM" comment
- Or clarify if this inline dockerfile_literal is intentionally replacing the external Dockerfile approach
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml`
around lines 19 - 21, The PR currently contains a “For testing only, DNM”
comment and commented-out dockerfile lines (the commented block containing
"dockerfile_path: Dockerfile.e2e" and "to: cluster-capi-operator-e2e-tests");
remove the DNM text and either delete the commented-out Dockerfile.e2e lines if
they are obsolete or replace them with the intended configuration (or add a
clarifying inline note that this dockerfile_literal replaces the external
Dockerfile) so the manifest in openshift-cluster-capi-operator-main.yaml
accurately reflects the final desired state for merge.
|
/pj-rehearse |
|
@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
needs-rebase
openshift-ci
Bot
removed
the
needs-rebase
|
/pj-rehearse |
|
@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview pull-ci-openshift-cluster-api-main-e2e-aws-capi-techpreview |
|
@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 35 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@mdbooth: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit