Skip to content

prowgen: migrate CSI and skip_operator_presubmits to ci-operator config#78232

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:prowgen-rehearsals-migration
Apr 24, 2026
Merged

prowgen: migrate CSI and skip_operator_presubmits to ci-operator config#78232
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:prowgen-rehearsals-migration

Conversation

@Prucek
Copy link
Copy Markdown
Member

@Prucek Prucek commented Apr 23, 2026

Summary

  • Move enable_secrets_store_csi_driver from .config.prowgen into ci-operator config's prowgen section (2 repos)
  • Move skip_operator_presubmits from .config.prowgen into ci-operator config's prowgen section (3 repos)
  • Remove migrated settings from .config.prowgen files (delete files that become empty)

CSI migration

Repo Action
openshift/ci-tools Added to main config, removed from .config.prowgen (keeps slack_reporter)
psalajova/test Added to master config, deleted .config.prowgen

skip_operator_presubmits migration

Repo Configs Action
opendatahub-io/opendatahub-operator main Deleted .config.prowgen
openshift/csi-operator 4.17-4.20 periodics Removed from .config.prowgen (keeps slack_reporter)
openshift/gcp-filestore-csi-driver-operator 4.17-4.20 periodics Removed from .config.prowgen (keeps slack_reporter)

Depends on: openshift/ci-tools#5120, openshift/ci-tools#5121

Test plan

  • Verify make jobs produces no diff after ci-tools PRs are merged
  • Generated prow job configs should be identical before and after

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Revised CI operator configurations across multiple projects: several periodic release configs now opt out of operator presubmit generation, while others remove that opt-out so presubmits will run on applicable branches.
    • Adjusted Secrets Store CSI Driver settings: some pipeline configs now enable it, while others remove the explicit enablement to rely on defaults.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1187aca9-e71a-4808-a1fb-74fbcea9b5ea

📥 Commits

Reviewing files that changed from the base of the PR and between 6723fd4 and dc18ad5.

📒 Files selected for processing (16)
  • ci-operator/config/opendatahub-io/opendatahub-operator/.config.prowgen
  • ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
  • ci-operator/config/openshift/ci-tools/.config.prowgen
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
  • ci-operator/config/openshift/csi-operator/.config.prowgen
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.17__periodics.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.18__periodics.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.19__periodics.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.20__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/.config.prowgen
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.17__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.18__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.19__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.20__periodics.yaml
  • ci-operator/config/psalajova/test/.config.prowgen
  • ci-operator/config/psalajova/test/psalajova-test-master.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/config/psalajova/test/.config.prowgen
  • ci-operator/config/opendatahub-io/opendatahub-operator/.config.prowgen
  • ci-operator/config/openshift/ci-tools/.config.prowgen
  • ci-operator/config/openshift/csi-operator/.config.prowgen
✅ Files skipped from review due to trivial changes (3)
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.17__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.18__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/.config.prowgen
🚧 Files skipped from review as they are similar to previous changes (7)
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.18__periodics.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.17__periodics.yaml
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.19__periodics.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.19__periodics.yaml
  • ci-operator/config/psalajova/test/psalajova-test-master.yaml
  • ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.20__periodics.yaml

Walkthrough

Moves prowgen flags (skip_operator_presubmits, enable_secrets_store_csi_driver) from project-level .config.prowgen files into specific CI operator YAMLs and adds new top-level prowgen sections in multiple periodic/main configs.

Changes

Cohort / File(s) Summary
opendatahub-operator
ci-operator/config/opendatahub-io/opendatahub-operator/.config.prowgen, ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
Removed skip_operator_presubmits from .config.prowgen; added prowgen.skip_operator_presubmits: true to the main YAML.
ci-tools
ci-operator/config/openshift/ci-tools/.config.prowgen, ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
Deleted enable_secrets_store_csi_driver from .config.prowgen; added prowgen.enable_secrets_store_csi_driver: true to the main YAML.
openshift csi-operator
ci-operator/config/openshift/csi-operator/.config.prowgen, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.17__periodics.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.18__periodics.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.19__periodics.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.20__periodics.yaml
Removed skip_operator_presubmits rules from .config.prowgen; added prowgen.skip_operator_presubmits: true to each listed periodic release YAML.
gcp-filestore-csi-driver-operator
ci-operator/config/openshift/gcp-filestore-csi-driver-operator/.config.prowgen, ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.17__periodics.yaml, ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.18__periodics.yaml, ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.19__periodics.yaml, ci-operator/config/openshift/gcp-filestore-csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.20__periodics.yaml
Removed skip_operator_presubmits entries from .config.prowgen; added prowgen.skip_operator_presubmits: true to each periodic release YAML.
psalajova/test
ci-operator/config/psalajova/test/.config.prowgen, ci-operator/config/psalajova/test/psalajova-test-master.yaml
Deleted enable_secrets_store_csi_driver from .config.prowgen; added prowgen.enable_secrets_store_csi_driver: true to the master YAML.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: migrating prowgen configuration settings (CSI driver and skip_operator_presubmits) from .config.prowgen files to ci-operator config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files with no test code or Ginkgo test name changes.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this pull request. This PR exclusively modifies CI/CD configuration files (.config.prowgen files and YAML ci-operator configuration files) to migrate prowgen settings. No Ginkgo test files or Go test code are being modified.
Microshift Test Compatibility ✅ Passed This PR is not applicable to the MicroShift Test Compatibility check because it does not add any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request contains no Ginkgo e2e test additions or modifications. The PR exclusively modifies CI/CD configuration files in the ci-operator/config directory. Since the custom check is designed to flag SNO compatibility issues when new Ginkgo e2e tests are added, and this PR contains no such test code changes, the check is not applicable and passes by default.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI/CD configuration files (.config.prowgen and ci-operator YAML) used by Prowgen tool and ci-operator infrastructure. Changes migrate prowgen configuration settings without adding pod scheduling constraints, affinity rules, topology assumptions, or workload specifications affecting OpenShift cluster topology compatibility.
Ote Binary Stdout Contract ✅ Passed This PR exclusively modifies YAML configuration files and does not contain any changes to Go code, OTE binaries, or executable binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only YAML configuration file modifications with no new Ginkgo e2e tests added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Move enable_secrets_store_csi_driver and skip_operator_presubmits
settings from .config.prowgen files into ci-operator config's prowgen
section.

CSI migration (2 repos):
- openshift/ci-tools
- psalajova/test

skip_operator_presubmits migration (3 repos):
- opendatahub-io/opendatahub-operator (main)
- openshift/csi-operator (4.17-4.20 periodics)
- openshift/gcp-filestore-csi-driver-operator (4.17-4.20 periodics)

Depends on openshift/ci-tools#5120 and openshift/ci-tools#5121.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Prucek Prucek force-pushed the prowgen-rehearsals-migration branch from 6723fd4 to dc18ad5 Compare April 24, 2026 07:06
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ci-tools-main-breaking-changes openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-checkconfig openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-codegen openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e-oo openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-format openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-frontend-checks openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-images openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-integration openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-lint openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-security openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-unit openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-prow openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-vendor openshift/ci-tools presubmit Ci-operator config changed
pull-ci-psalajova-test-master-test-credentials psalajova/test presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-images opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-e2e opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-rhoai-e2e opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
periodic-ci-openshift-gcp-filestore-csi-driver-operator-release-4.20-periodics-periodic-e2e-gcp-filestore-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.20-periodics-periodic-e2e-smb-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.17-periodics-periodic-e2e-aws-efs-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.20-periodics-periodic-e2e-azure-file-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.20-periodics-periodic-e2e-aws-efs-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.17-periodics-periodic-e2e-azure-file-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-csi-operator-release-4.18-periodics-periodic-e2e-smb-csi N/A periodic Ci-operator config changed

A total of 34 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Prucek
Copy link
Copy Markdown
Member Author

Prucek commented Apr 24, 2026

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prucek
Copy link
Copy Markdown
Member Author

Prucek commented Apr 24, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@Prucek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/ci-tools/main/e2e-oo dc18ad5 link unknown /pj-rehearse pull-ci-openshift-ci-tools-main-e2e-oo
ci/rehearse/openshift/ci-tools/main/breaking-changes dc18ad5 link unknown /pj-rehearse pull-ci-openshift-ci-tools-main-breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9b8e835 into openshift:main Apr 24, 2026
17 of 19 checks passed
tbuskey pushed a commit to tbuskey/release that referenced this pull request Apr 24, 2026
…ig (openshift#78232)

Move enable_secrets_store_csi_driver and skip_operator_presubmits
settings from .config.prowgen files into ci-operator config's prowgen
section.

CSI migration (2 repos):
- openshift/ci-tools
- psalajova/test

skip_operator_presubmits migration (3 repos):
- opendatahub-io/opendatahub-operator (main)
- openshift/csi-operator (4.17-4.20 periodics)
- openshift/gcp-filestore-csi-driver-operator (4.17-4.20 periodics)

Depends on openshift/ci-tools#5120 and openshift/ci-tools#5121.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Prucek added a commit to Prucek/release that referenced this pull request Apr 29, 2026
…ig (openshift#78232)

Move enable_secrets_store_csi_driver and skip_operator_presubmits
settings from .config.prowgen files into ci-operator config's prowgen
section.

CSI migration (2 repos):
- openshift/ci-tools
- psalajova/test

skip_operator_presubmits migration (3 repos):
- opendatahub-io/opendatahub-operator (main)
- openshift/csi-operator (4.17-4.20 periodics)
- openshift/gcp-filestore-csi-driver-operator (4.17-4.20 periodics)

Depends on openshift/ci-tools#5120 and openshift/ci-tools#5121.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
…ig (openshift#78232)

Move enable_secrets_store_csi_driver and skip_operator_presubmits
settings from .config.prowgen files into ci-operator config's prowgen
section.

CSI migration (2 repos):
- openshift/ci-tools
- psalajova/test

skip_operator_presubmits migration (3 repos):
- opendatahub-io/opendatahub-operator (main)
- openshift/csi-operator (4.17-4.20 periodics)
- openshift/gcp-filestore-csi-driver-operator (4.17-4.20 periodics)

Depends on openshift/ci-tools#5120 and openshift/ci-tools#5121.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants