NO-JIRA: Mirror also postgresql-15 and postgresql-16 for disconnected env

[mgencur]

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84087

A similar fix was done for older versions some time ago in 6947813

Summary by CodeRabbit

• Chores
  • Added support for PostgreSQL 15 and 16 image mirrors in deployment configuration.

[openshift-ci-robot]

@mgencur: This pull request references Jira Issue OCPBUGS-84087, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84087

A similar fix was done for older versions some time ago in 6947813

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The hypershift-mce-agent-create-agentserviceconfig-commands.sh script's deploy_image_digest_mirror_set function was updated to include additional image digest mirror mappings for PostgreSQL 15 and 16, redirecting registry pulls from Red Hat's registry to a configured mirror destination.

Changes

Cohort / File(s)	Summary
PostgreSQL Image Mirrors ci-operator/step-registry/hypershift/mce/agent/create/agentserviceconfig/hypershift-mce-agent-create-agentserviceconfig-commands.sh	Added imageDigestMirrors mappings for rhel9/postgresql-15 and rhel9/postgresql-16, directing pulls from registry.redhat.io/rhel9/... to mirror destinations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR modifies a shell script for CI/CD infrastructure, not a Ginkgo test file. The check is not applicable.
Test Structure And Quality	✅ Passed	The PR modifies only a shell script file that adds PostgreSQL image mirror configurations. No Go test files or Ginkgo test code is present in the changes.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests; it only modifies a bash CI/CD configuration script to add PostgreSQL image mirror mappings.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only a shell script for CI operations with no Ginkgo e2e tests, making the custom check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The ImageDigestMirrorSet change adds PostgreSQL image mirrors without introducing pod scheduling constraints, affinity rules, or topology-specific assumptions across all OpenShift topologies.
Ote Binary Stdout Contract	✅ Passed	The PR modifies a shell script for CI/CD configuration, not OTE binary code that outputs JSON to stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Pull request modifies shell script for container image mirroring configuration, not Ginkgo e2e tests. No test code patterns found.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding PostgreSQL 15 and 16 image mirrors for disconnected environments, which directly matches the changeset modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

[openshift-merge-bot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-origin-release-4.16-e2e-agent-disconnected-ovn-dualstack-metal3	openshift/origin	presubmit	Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-ipv4-metal3	openshift/origin	presubmit	Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-dualstack-metal3	openshift/origin	presubmit	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-metal-ds-hypershift-agent-mce-guest-f28-destructive	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-metal-ds-hypershift-agent-mce-n3minor-guest-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-metal-ds-agent-hypershift-mce-inplace-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-metal-ds-hypershift-agent-mce-disconnected-mgmt-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-metal-ds-hypershift-agent-mce-disconnected-mgmt-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-metal-ds-hypershift-agent-mce-n2minor-mgmt-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-metal-ds-hypershift-agent-mce-disconnected-guest-f14-des	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-metal-ds-hypershift-agent-mce-guest-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-eus-upgrade-from-4.14-metal-ds-agent-hypershift-mce-inplace-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-eus-upgrade-from-4.16-metal-ds-agent-hypershift-mce-compact-full-inplace-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-metal-ds-hypershift-agent-mce-mgmt-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.16-metal-ds-agent-hypershift-mce-inplace-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-metal-ds-hypershift-agent-mce-mgmt-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-4.20-upgrade-from-stable-4.20-metal-ds-agent-hypershift-mce-inplace-f60	N/A	periodic	Registry content changed

A total of 162 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

[openshift-merge-bot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	de936a0	link	unknown	/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mgencur]

/jira refresh

[openshift-ci-robot]

@mgencur: This pull request references Jira Issue OCPBUGS-84087, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mgencur: This pull request explicitly references no jira issue.

Details

In response to this:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84087

A similar fix was done for older versions some time ago in 6947813

Summary by CodeRabbit

• Chores
• Added support for PostgreSQL 15 and 16 image mirrors in deployment configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mgencur]

/pj-rehearse ack

[openshift-merge-bot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[enxebre]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/mce/agent/create/agentserviceconfig/OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mehabhalodiya]

I see the job run you triggered 4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance still failed.

Would you like to make more changes or rerun it? I think we can merge this once we get a green run, WDYT?

[mgencur]

@mehabhalodiya Thanks for the heads up. This is a different issue and I know what's happening there. I was fixing this earlier this year and will send another PR with the new fix.
Note: this is only a test setup issue.

[mgencur]

@mehabhalodiya Fixed in #78321 , PTAL