[release-4.21] OCPBUGS-84252: Add techpreview disruptive-longrunning jobs to the 4.21#78277
[release-4.21] OCPBUGS-84252: Add techpreview disruptive-longrunning jobs to the 4.21#78277QiWang19 wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: Qi Wang <qiwan@redhat.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughExtends OpenShift CI configuration by adding multiple new disruptive longrunning E2E test entries for TechPreview mode across various cloud platforms (AWS, Azure, GCP, vSphere, Equinix Metal) in the nightly test configuration, and significantly updates periodic job definitions with shard-based scheduling and interval-based execution parameters. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
QiWang19
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@QiWang19: This pull request references Jira Issue OCPBUGS-83803, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
QiWang19
changed the title
|
@QiWang19: This pull request references Jira Issue OCPBUGS-84252, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
QiWang19
changed the title
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml (1)
196341-196368:⚠️ Potential issue | 🟠 MajorDon't effectively disable this periodic with a yearly cron.
cron: 0 0 1 1 *will runperiodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-dualstackonly once per year. Unless this suite is being intentionally parked, this drops regular dualstack coverage for 4.21. Please restore a normal cadence here, or make the disablement explicit in a way that won't look accidental.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml` around lines 196341 - 196368, The periodic job periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-dualstack is configured with a yearly cron (cron: 0 0 1 1 *), which effectively disables regular runs; change the cron to the intended cadence (e.g., nightly "0 0 * * *" or weekly "0 0 * * 0" depending on desired frequency) or, if you truly intend to park the job, replace the schedule with an explicit disabled signal (add a clear comment and set ci.openshift.io/no-builds: "true" or remove the job) so the intent is unambiguous. Ensure you update the cron field in the job spec and keep the job name periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-dualstack unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml`:
- Around line 1889-1900: The job block that sets TEST_SUITE:
openshift/disruptive-longrunning is missing an explicit TEST_TYPE, causing the
AWS disruption workflow (openshift-e2e-aws-disruption) to default to
suite-conformance; add TEST_TYPE: suite to this job's env so it matches the
other family and runs in suite mode (update the env map where TEST_SUITE is
defined to include TEST_TYPE set to "suite").
---
Outside diff comments:
In `@ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml`:
- Around line 196341-196368: The periodic job
periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-dualstack is
configured with a yearly cron (cron: 0 0 1 1 *), which effectively disables
regular runs; change the cron to the intended cadence (e.g., nightly "0 0 * * *"
or weekly "0 0 * * 0" depending on desired frequency) or, if you truly intend to
park the job, replace the schedule with an explicit disabled signal (add a clear
comment and set ci.openshift.io/no-builds: "true" or remove the job) so the
intent is unambiguous. Ensure you update the cron field in the job spec and keep
the job name
periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-dualstack
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 359a7386-4893-4ecd-9062-cf76d5c1cef6
📒 Files selected for processing (2)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yamlci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml
| - as: e2e-aws-disruptive-longrunning-techpreview | ||
| interval: 120h | ||
| shard_count: 2 | ||
| steps: | ||
| cluster_profile: openshift-org-aws | ||
| env: | ||
| FEATURE_SET: TechPreviewNoUpgrade | ||
| TEST_SUITE: openshift/disruptive-longrunning | ||
| observers: | ||
| enable: | ||
| - observers-resource-watch | ||
| workflow: openshift-e2e-aws-disruption |
There was a problem hiding this comment.
Set explicit TEST_TYPE: suite for the new AWS disruptive-longrunning techpreview job.
Line 1896 sets TEST_SUITE: openshift/disruptive-longrunning, but TEST_TYPE is not set. The same job family at Line 1884 uses TEST_TYPE: suite, and the AWS disruption workflow defaults to suite-conformance; this can run the wrong mode.
Proposed fix
- as: e2e-aws-disruptive-longrunning-techpreview
interval: 120h
shard_count: 2
steps:
cluster_profile: openshift-org-aws
env:
FEATURE_SET: TechPreviewNoUpgrade
TEST_SUITE: openshift/disruptive-longrunning
+ TEST_TYPE: suite
+ TEST_REQUIRES_SSH: "yes"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - as: e2e-aws-disruptive-longrunning-techpreview | |
| interval: 120h | |
| shard_count: 2 | |
| steps: | |
| cluster_profile: openshift-org-aws | |
| env: | |
| FEATURE_SET: TechPreviewNoUpgrade | |
| TEST_SUITE: openshift/disruptive-longrunning | |
| observers: | |
| enable: | |
| - observers-resource-watch | |
| workflow: openshift-e2e-aws-disruption | |
| - as: e2e-aws-disruptive-longrunning-techpreview | |
| interval: 120h | |
| shard_count: 2 | |
| steps: | |
| cluster_profile: openshift-org-aws | |
| env: | |
| FEATURE_SET: TechPreviewNoUpgrade | |
| TEST_SUITE: openshift/disruptive-longrunning | |
| TEST_TYPE: suite | |
| TEST_REQUIRES_SSH: "yes" | |
| observers: | |
| enable: | |
| - observers-resource-watch | |
| workflow: openshift-e2e-aws-disruption |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml`
around lines 1889 - 1900, The job block that sets TEST_SUITE:
openshift/disruptive-longrunning is missing an explicit TEST_TYPE, causing the
AWS disruption workflow (openshift-e2e-aws-disruption) to default to
suite-conformance; add TEST_TYPE: suite to this job's env so it matches the
other family and runs in suite mode (update the env map where TEST_SUITE is
defined to include TEST_TYPE set to "suite").
|
/pj-rehearse |
|
@QiWang19: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Add the same kind of techpreview longrunning techpreview jobs as #75016, but for 4.21
Summary by CodeRabbit