Skip to content

Add loading of local context for prom-label-proxy#78331

Open
simonpasquier wants to merge 1 commit intoopenshift:mainfrom
simonpasquier:update-prom-label-proxy
Open

Add loading of local context for prom-label-proxy#78331
simonpasquier wants to merge 1 commit intoopenshift:mainfrom
simonpasquier:update-prom-label-proxy

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

@simonpasquier simonpasquier commented Apr 24, 2026

The goal is to pass environment variables to the CI job at the same time we update the downstream fork.

Summary by CodeRabbit

  • Chores
    • Internal CI/CD configuration updates to improve test execution workflows.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2c538180-b12f-4607-99f8-954e1421ed8b

📥 Commits

Reviewing files that changed from the base of the PR and between 8986451 and 412bae2.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/prom-label-proxy/openshift-prom-label-proxy-main.yaml

Walkthrough

A CI configuration file for the OpenShift prom-label-proxy project was updated to conditionally source an .ci-operator.rc file before executing existing test commands in the vendor and test-unit test stages.

Changes

Cohort / File(s) Summary
CI Configuration Update
ci-operator/config/openshift/prom-label-proxy/openshift-prom-label-proxy-main.yaml
Added conditional shell logic to source .ci-operator.rc file (if it exists) before running make unused && git diff --exit-code and make test commands in the vendor and test-unit stages respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding loading of local context for prom-label-proxy via sourcing .ci-operator.rc in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI operator configuration YAML files without any Ginkgo test definitions in Go source code, so check is not applicable and passes by default.
Test Structure And Quality ✅ Passed This check is not applicable as the PR modifies CI operator configuration YAML files, not Ginkgo test code.
Microshift Test Compatibility ✅ Passed The custom check for MicroShift test compatibility is not applicable to this PR. The PR modifies CI/CD configuration files (YAML) that define how tests are invoked, not actual Ginkgo e2e test code. No new Ginkgo e2e tests are being added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only modifies CI operator configuration YAML for existing test steps.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration test commands, not deployment manifests, operator code, or controllers that would introduce scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check applies to Go source code, but this PR modifies only CI configuration YAML files, not Go code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies CI/CD configuration files, not new Ginkgo e2e test code. The custom check applies only when new Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from jan--f and slashpai April 24, 2026 13:45
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-prom-label-proxy-main-test-unit openshift/prom-label-proxy presubmit Ci-operator config changed
pull-ci-openshift-prom-label-proxy-main-vendor openshift/prom-label-proxy presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simonpasquier
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant