Skip to content

feat(GCP-431): pass network service account to v2 GKE create chain#78662

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
cblecker:gcp-431-network-sa-v2-create-chain
May 1, 2026
Merged

feat(GCP-431): pass network service account to v2 GKE create chain#78662
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
cblecker:gcp-431-network-sa-v2-create-chain

Conversation

@cblecker
Copy link
Copy Markdown
Member

@cblecker cblecker commented Apr 30, 2026

Summary

Test plan

  • Rehearse /test e2e-v2-gke on a hypershift PR that touches GCP code paths and verify the create-hostedcluster step no longer fails with required flag(s) "network-service-account" not set

Summary by CodeRabbit

  • New Features
    • Network service account configuration now available for GCP hosted cluster provisioning, allowing specification of network service accounts during cluster creation.

The v2 GKE e2e workflow (hypershift-gcp-gke-e2e-v2) creates a hosted
cluster directly via the hypershift CLI in the hypershift-gcp-create
chain. Since openshift/hypershift#7824 made --network-service-account a
required flag, the chain must read the network SA saved to SHARED_DIR by
hypershift-gcp-hosted-cluster-setup and forward it to the CLI.

This is a follow-up to openshift#77415, which fixed the same
issue for the v1 (hypershift-gcp-run-e2e) flow.

Assisted-by: Claude:claude-opus-4-6[1m]
@cblecker
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-gke pull-ci-openshift-hypershift-main-e2e-v2-gke

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 10b6f498-522f-4582-85de-c995c02cfb4a

📥 Commits

Reviewing files that changed from the base of the PR and between 1d73cfc and 85695af.

📒 Files selected for processing (1)
  • ci-operator/step-registry/hypershift/gcp/create/hypershift-gcp-create-chain.yaml

Walkthrough

The GCP HyperShift cluster creation CI step is updated to read a network-sa value from the shared directory and pass it to the hypershift create cluster gcp command via a new --network-service-account flag.

Changes

Cohort / File(s) Summary
GCP HyperShift Create Configuration
ci-operator/step-registry/hypershift/gcp/create/hypershift-gcp-create-chain.yaml
Reads network-sa value from SHARED_DIR and forwards it to the cluster creation command via the new --network-service-account flag to extend service account inputs during hosted cluster provisioning.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: passing network service account to the v2 GKE create chain, which matches the file modification in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies a YAML CI operator configuration file, not Ginkgo test files. No test titles or dynamic test name patterns are present.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code structure is not applicable to this PR as only YAML configuration files are modified, not Ginkgo test code.
Microshift Test Compatibility ✅ Passed PR modifies only a YAML CI/CD pipeline configuration file, not a Ginkgo e2e test file. The MicroShift compatibility check applies only to new Ginkgo e2e tests, which are absent from this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only CI/CD configuration, not Ginkgo e2e tests, so the custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI/CD step registry YAML to pass a CLI flag to hypershift, introducing no in-cluster scheduling constraints or deployment manifest changes.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI/CD configuration files, not Go test code, so OTE Binary Stdout Contract violations cannot occur.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies a CI operator chain configuration file to pass a network service account parameter to the hypershift CLI command.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from devguyio and jimdaga April 30, 2026 18:29
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@cblecker
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-gke pull-ci-openshift-hypershift-main-e2e-v2-gke

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cblecker
Copy link
Copy Markdown
Member Author

/assign @apahim @cristianoveiga

@cristianoveiga
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2026
@apahim
Copy link
Copy Markdown
Contributor

apahim commented May 1, 2026

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apahim, cblecker, cristianoveiga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Copy Markdown
Member Author

cblecker commented May 1, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit e18f6f9 into openshift:main May 1, 2026
11 checks passed
@cblecker cblecker deleted the gcp-431-network-sa-v2-create-chain branch May 1, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants