feat(GCP-431): pass network service account to v2 GKE create chain#78662
Conversation
The v2 GKE e2e workflow (hypershift-gcp-gke-e2e-v2) creates a hosted cluster directly via the hypershift CLI in the hypershift-gcp-create chain. Since openshift/hypershift#7824 made --network-service-account a required flag, the chain must read the network SA saved to SHARED_DIR by hypershift-gcp-hosted-cluster-setup and forward it to the CLI. This is a follow-up to openshift#77415, which fixed the same issue for the v1 (hypershift-gcp-run-e2e) flow. Assisted-by: Claude:claude-opus-4-6[1m]
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-gke pull-ci-openshift-hypershift-main-e2e-v2-gke |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe GCP HyperShift cluster creation CI step is updated to read a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-gke pull-ci-openshift-hypershift-main-e2e-v2-gke |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign @apahim @cristianoveiga |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apahim, cblecker, cristianoveiga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
hypershift-gcp-gke-e2e-v2) creates a hosted cluster directly via the hypershift CLI in thehypershift-gcp-createchain--network-service-accounta required flag, the chain must read thenetwork-sasaved toSHARED_DIRbyhypershift-gcp-hosted-cluster-setupand forward it to the CLIhypershift-gcp-run-e2e) flowTest plan
/test e2e-v2-gkeon a hypershift PR that touches GCP code paths and verify thecreate-hostedclusterstep no longer fails withrequired flag(s) "network-service-account" not setSummary by CodeRabbit