CNTRLPLANE-3352: remove verify-workflows Prow job for hypershift main

[bryan-cox]

Summary

• Removes the verify-workflows Prow presubmit job for openshift/hypershift on the main branch
• This job is no longer needed because GHA workflows now use reusable workflow callers that reference definitions via @main, so PRs always run the latest workflow version without needing to rebase

Context

• CNTRLPLANE-3352: Add reusable GHA workflow definitions hypershift#8386 added dormant reusable workflow files
• CNTRLPLANE-3352: Convert GHA callers to use reusable workflows @main hypershift#8387 converted all 9 callers to use @main refs
• Release branch configs (4.23, 5.0, 5.1) retain verify-workflows since they don't use reusable workflows yet

Test plan

• make jobs WHAT=openshift/hypershift regenerated successfully
• Only main config and presubmits changed (release branches untouched)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Removed CI workflow validation step that previously checked whether workflow files were current relative to the merge base. This simplifies the pipeline configuration without affecting core functionality.

[openshift-ci-robot]

@bryan-cox: This pull request references CNTRLPLANE-3352 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Removes the verify-workflows Prow presubmit job for openshift/hypershift on the main branch
• This job is no longer needed because GHA workflows now use reusable workflow callers that reference definitions via @main, so PRs always run the latest workflow version without needing to rebase

Context

• CNTRLPLANE-3352: Add reusable GHA workflow definitions hypershift#8386 added dormant reusable workflow files
• CNTRLPLANE-3352: Convert GHA callers to use reusable workflows @main hypershift#8387 converted all 9 callers to use @main refs
• Release branch configs (4.23, 5.0, 5.1) retain verify-workflows since they don't use reusable workflows yet

Test plan

• make jobs WHAT=openshift/hypershift regenerated successfully
• Only main config and presubmits changed (release branches untouched)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f56f9376-69e3-41cc-afd8-acebc513dae1

📥 Commits

Reviewing files that changed from the base of the PR and between 0384648 and 78721f3.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

💤 Files with no reviewable changes (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

---

Walkthrough

The verify-workflows CI test step is removed from the OpenShift HyperShift main pipeline configuration. This step previously validated that workflow files were neither missing from nor outdated relative to the upstream main branch.

Changes

Cohort / File(s)	Summary
CI Configuration ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml	Removal of the verify-workflows test step (43 lines deleted), eliminating the workflow-file freshness validation check from the CI pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically summarizes the main change: removing the verify-workflows Prow job for hypershift main branch, which aligns perfectly with the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies CI/CD configuration YAML, not Ginkgo test files. No Go test code or dynamic test names present.
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test code quality is not applicable to this PR. The PR only modifies CI/CD configuration files (YAML) and contains no Ginkgo test code or test implementations to evaluate.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e test code is being added in this PR. MicroShift Test Compatibility check only applies to newly added test code, making it inapplicable here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR is a CI/CD configuration modification that removes the verify-workflows Prow presubmit job, with no new Ginkgo e2e tests added.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR only removes a CI pipeline verification step from a Prow configuration file and does not introduce, modify, or add any deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR modifies only YAML configuration files (CI-operator Prow job removal), containing zero Go source code changes. The OTE Binary Stdout Contract check targets Go source code violations and is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR is a CI configuration change only, removing a Prow presubmit job. No new Ginkgo e2e tests are introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@bryan-cox: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[cblecker]

/lgtm
/hold

So I investigated this, and the one possible issue: it is difficult to test changes to the actions from a PR branch if they are all running from @main. If this is acceptable, then feel free to pull the hold.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS [bryan-cox,cblecker]
• ci-operator/jobs/openshift/hypershift/OWNERS [bryan-cox,cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csrwng]

@cblecker in order to test changes to the actions, we will need to temporarily reference the local files in the branch, verify that they work and then revert those changes.

/hold cancel

[bryan-cox]

/hold cancel

@cblecker thanks for the tag and investigation! @csrwng and I briefly discussed that on Slack.

To test changes to a workflow, one would need to test it within the PR by overriding the job from main and then reverting the change once they were satisfied with testing. That seems more palatable than everyone having to rebase their PR constantly.

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.