MGMT-24194: add required vmaas E2E presubmit tests to osac-operator#78716
MGMT-24194: add required vmaas E2E presubmit tests to osac-operator#78716omer-vishlitzky wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references MGMT-24194 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughCI operator configuration for the OSAC operator: adds base image references, new image build steps (operator and installer-with-pr), updates releases to OCP nightly 4.20, and expands tests with multiple packet-assisted e2e scenarios using the osac-project-ofcir-baremetal-component workflow. ChangesOSAC Operator CI Pipeline Setup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 8 minutes and 6 seconds. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omer-vishlitzky The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml (1)
85-243: ⚡ Quick winConsider deduplicating the repeated
envpayload to reduce drift risk.
ASSISTED_CONFIGandCOMPONENT_IMAGE_NAMEare duplicated across all eight required jobs. Centralizing the shared map (for example via YAML merge/anchor) would make future updates safer and smaller.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml` around lines 85 - 243, The env block containing ASSISTED_CONFIG and COMPONENT_IMAGE_NAME is duplicated across multiple jobs (e.g., the jobs as: e2e-metal-vmaas-compute-instance-api-fields, e2e-metal-vmaas-compute-instance-cli-fields, etc.); refactor by extracting the shared env into a single YAML anchor or reusable map and reference it from each job to eliminate repetition—create a top-level anchor (e.g., &shared_env) for ASSISTED_CONFIG and COMPONENT_IMAGE_NAME and replace each job's duplicated env with an alias (*shared_env) or use a YAML merge key, ensuring TEST remains per-job where different.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml`:
- Around line 85-243: The env block containing ASSISTED_CONFIG and
COMPONENT_IMAGE_NAME is duplicated across multiple jobs (e.g., the jobs as:
e2e-metal-vmaas-compute-instance-api-fields,
e2e-metal-vmaas-compute-instance-cli-fields, etc.); refactor by extracting the
shared env into a single YAML anchor or reusable map and reference it from each
job to eliminate repetition—create a top-level anchor (e.g., &shared_env) for
ASSISTED_CONFIG and COMPONENT_IMAGE_NAME and replace each job's duplicated env
with an alias (*shared_env) or use a YAML merge key, ensuring TEST remains
per-job where different.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1171eb23-12e6-44bd-9fc6-f9615c86b567
⛔ Files ignored due to path filters (1)
ci-operator/jobs/osac-project/osac-operator/osac-project-osac-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
|
/retest |
|
/retest |
|
/pj-rehearse pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-api-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-cli-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-creation pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-delete-during-provision pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart-negative pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-subnet-lifecycle pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-virtual-network-lifecycle |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add 8 required vmaas E2E presubmit tests that run on every osac-operator PR. Tests build a modified osac-installer image with the PR's manifests and container image swapped in.
omer-vishlitzky
force-pushed
the
MGMT-24194-osac-operator
branch
from
ca2e0d4 to
9eb317a
Compare
|
/pj-rehearse pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-api-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-cli-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-creation pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-delete-during-provision pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart-negative pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-subnet-lifecycle pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-virtual-network-lifecycle |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-api-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-cli-fields pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-creation pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-delete-during-provision pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-compute-instance-restart-negative pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-subnet-lifecycle pull-ci-osac-project-osac-operator-main-e2e-metal-vmaas-virtual-network-lifecycle |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
Summary
https://redhat.atlassian.net/browse/MGMT-24194
Add 8 required vmaas E2E presubmit tests to osac-operator. Tests build a modified osac-installer image with the PR's manifests and container image swapped in.
Depends on
Test plan
Summary by CodeRabbit
New Features
Tests