MGMT-24194: add required vmaas E2E presubmit tests to fulfillment-service#78717
MGMT-24194: add required vmaas E2E presubmit tests to fulfillment-service#78717omer-vishlitzky wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references MGMT-24194 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughCI configuration for the fulfillment-service adds base image mappings, new image build targets (fulfillment-service-pr, osac-installer-with-pr) including a dockerfile_literal stage, updates promotion/release metadata to include OCP 4.20, and expands the e2e-metal test matrix with multiple bare-metal jobs that use the PR images and OPENSHIFT_VERSION=4.20. ChangesFulfillment Service CI Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes 🚥 Pre-merge checks | ✅ 10 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 7/10 reviews remaining, refill in 14 minutes and 5 seconds. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml`:
- Line 121: The workflow name referenced ("workflow:
osac-project-ofcir-baremetal-component") does not exist in the step-registry and
will block presubmits; either change each job that uses that workflow to the
existing workflow name "osac-project-ofcir-baremetal" or ensure the missing
"osac-project-ofcir-baremetal-component" workflow is added to the step-registry
(e.g., via the pending PR), updating all occurrences where "workflow:
osac-project-ofcir-baremetal-component" appears so they match a registered
workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: af68b941-46e0-45d8-9822-db3f5a487d38
⛔ Files ignored due to path filters (2)
ci-operator/jobs/osac-project/fulfillment-service/osac-project-fulfillment-service-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/osac-project/fulfillment-service/osac-project-fulfillment-service-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml
| OPENSHIFT_VERSION=4.20 | ||
| COMPONENT_IMAGE_NAME: ghcr.io/osac-project/fulfillment-service | ||
| TEST: test_compute_instance_creation.py | ||
| workflow: osac-project-ofcir-baremetal-component |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether the referenced workflow exists in this branch.
# Expected:
# - At least one hit for `as: osac-project-ofcir-baremetal-component` if reference is valid here.
# - If no hit, this PR must stay blocked on the dependency PR merge.
rg -n --type=yaml '^\s*as:\s*osac-project-ofcir-baremetal-component\s*$' ci-operator/step-registry
rg -n --type=yaml '^\s*as:\s*osac-project-ofcir-baremetal\s*$' ci-operator/step-registryRepository: openshift/release
Length of output: 196
Workflow osac-project-ofcir-baremetal-component does not exist and will block these presubmits.
Line 121 (and the same workflow lines in the other 7 jobs) references osac-project-ofcir-baremetal-component, but only osac-project-ofcir-baremetal exists in the step-registry. These jobs cannot execute until the -component variant is registered (likely via PR #78715).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml`
at line 121, The workflow name referenced ("workflow:
osac-project-ofcir-baremetal-component") does not exist in the step-registry and
will block presubmits; either change each job that uses that workflow to the
existing workflow name "osac-project-ofcir-baremetal" or ensure the missing
"osac-project-ofcir-baremetal-component" workflow is added to the step-registry
(e.g., via the pending PR), updating all occurrences where "workflow:
osac-project-ofcir-baremetal-component" appears so they match a registered
workflow.
|
/retest |
|
/pj-rehearse pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-api-fields pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-cli-fields pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-creation pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-delete-during-provision pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-restart pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-restart-negative pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-subnet-lifecycle pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-virtual-network-lifecycle |
Add 8 required vmaas E2E presubmit tests that run on every fulfillment-service PR. Tests build the fulfillment-service container image and osac CLI from the PR source, plus a modified osac-installer image with the PR's manifests swapped in.
omer-vishlitzky
force-pushed
the
MGMT-24194-fulfillment-service
branch
from
9d2144b to
fcca8cc
Compare
|
/pj-rehearse pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-api-fields pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-cli-fields pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-creation pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-delete-during-provision pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-restart pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-compute-instance-restart-negative pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-subnet-lifecycle pull-ci-osac-project-fulfillment-service-main-e2e-metal-vmaas-virtual-network-lifecycle |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
Summary
https://redhat.atlassian.net/browse/MGMT-24194
Add 8 required vmaas E2E presubmit tests to fulfillment-service. Tests build the fulfillment-service container image and osac CLI from the PR source, plus a modified osac-installer image with the PR's manifests swapped in.
Depends on
Test plan
Summary by CodeRabbit
Tests
Chores