Skip to content

NO_ISSUE: drop temp CI jobs and add members to osac-cicd#78723

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
omer-vishlitzky:osac-cicd-cleanup
May 4, 2026
Merged

NO_ISSUE: drop temp CI jobs and add members to osac-cicd#78723
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
omer-vishlitzky:osac-cicd-cleanup

Conversation

@omer-vishlitzky
Copy link
Copy Markdown
Contributor

@omer-vishlitzky omer-vishlitzky commented May 3, 2026

Drop placeholder temp test jobs from osac-aap and osac-operator CI configs.
Add danmanor, eranco74, omer-vishlitzky to the osac-cicd OWNERS alias.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD access aliases by adding three team entries.
    • Removed redundant temporary test steps from two CI pipelines to simplify workflows.
    • Added image build targets and promotion rules so two components are now built and promoted to the latest tag.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1991d815-ec73-48ba-9619-66fa0be99930

📥 Commits

Reviewing files that changed from the base of the PR and between 2e7eb9d and 718bafa.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/osac-project/osac-operator/osac-project-osac-operator-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/osac-project/osac-operator/osac-project-osac-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • OWNERS_ALIASES
  • ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
✅ Files skipped from review due to trivial changes (1)
  • OWNERS_ALIASES
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
  • ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml

Walkthrough

Appends three users to the osac-cicd OWNERS alias and updates two ci-operator job configs to add images and promotion entries while removing temporary tests stanzas.

Changes

OWNERS Alias Update

Layer / File(s) Summary
Team Membership
OWNERS_ALIASES
Appends danmanor, eranco74, and omer-vishlitzky to the aliases: osac-cicd list.

CI Operator: add images & promotion, remove tests (jobs for osac-aap and osac-operator)

Layer / File(s) Summary
Images / Build Target
ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml, ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
Adds images build entries (osac-aap: dockerfile_literal: "FROM src"to: osac-aap; osac-operator: build from Containerfileto: osac-operator).
Promotion
ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml, ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
Adds promotion rules to promote built images to name: latest in namespace osac-project.
Test Removal / Wiring
ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml, ci-operator/config/osac-project/osac-operator/osac-project-osac-operator-main.yaml
Removes the temporary tests stanza that previously ran echo "Test" using from: src.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing temporary CI test jobs and adding members to the osac-cicd alias group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes CI configuration YAML and OWNERS files only; no Ginkgo test definitions with potentially dynamic test names are present.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test structure is not applicable to this PR as only YAML configuration and OWNERS_ALIASES files are modified with no Go test code present.
Microshift Test Compatibility ✅ Passed This PR modifies CI configuration files and OWNERS_ALIASES only; no new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies CI configuration files and team membership only; no new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only OWNERS_ALIASES and CI operator build configurations, not deployment manifests or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check targets Go source code violations. This PR modifies only configuration files (OWNERS_ALIASES and YAML CI operator configs) with no Go source code or executable binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR removes temporary test jobs and updates CI/CD configuration files, not adding new Ginkgo e2e tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@omer-vishlitzky, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: you must define at least one test or image build in 'tests' or 'images'
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot openshift-merge-bot Bot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels May 3, 2026
@omer-vishlitzky
Copy link
Copy Markdown
Contributor Author

/retest

…ers to osac-cicd

Remove placeholder temp test jobs from osac-aap and osac-operator CI configs.
Replace with image builds. Add danmanor, eranco74, omer-vishlitzky to osac-cicd.
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@omer-vishlitzky: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-osac-project-osac-operator-main-images osac-project/osac-operator presubmit Presubmit changed
pull-ci-osac-project-osac-aap-main-images osac-project/osac-aap presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026
@omer-vishlitzky
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 4, 2026
@bear-redhat
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, bear-redhat, jhernand, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

@omer-vishlitzky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit a6d74f0 into openshift:main May 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants