MPIIT: Use ExitTrap--PostProcessPrep for ODF test mapping#78752
MPIIT: Use ExitTrap--PostProcessPrep for ODF test mapping#78752oharan2 wants to merge 3 commits intoopenshift:mainfrom
Conversation
WalkthroughThe PR updates REPORTPORTAL_CMP environment values in two test configs/ref and replaces in-script yq-based JUnit mapping with a MAP_TESTS-gated flow that conditionally fetches+evals a shared post-processing script and installs an EXIT trap to run cleanup then the shared post-processor; otherwise the EXIT trap only runs cleanup. ChangesTest Result Processing Centralization
Sequence Diagram(s)sequenceDiagram
participant TestScript as Interop Test Script
participant Shared as ExitTrap--PostProcessPrep.sh
participant CI as CI Runner / Filesystem
TestScript->>CI: run tests, produce ${CLUSTER_PATH}/junit.xml
alt MAP_TESTS=true
TestScript->>Shared: curl + eval shared script
TestScript->>TestScript: set LP_IO__ET_PPP__NEW_TS_NAME = REPORTPORTAL_CMP...
CI-->>TestScript: on EXIT -> run cleanup then ExitTrap--PostProcessPrep
TestScript->>Shared: ExitTrap--PostProcessPrep processes junit and writes to ${SHARED_DIR}
else MAP_TESTS!=true
CI-->>TestScript: on EXIT -> run cleanup only
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oharan2 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/interop-tests/ocs-tests/interop-tests-ocs-tests-commands.sh`:
- Around line 119-122: The eval call that downloads and executes
ExitTrap--PostProcessPrep.sh from refs/heads/main is unpinned; replace the
mutable branch URL in the curl (the line containing eval
"$(...ExitTrap--PostProcessPrep.sh)") with a URL that references an immutable
commit SHA (i.e. replace refs/heads/main with the repository commit SHA path for
ExitTrap--PostProcessPrep.sh), so the script is fetched from a specific commit;
obtain the appropriate commit SHA from the repo, update the URL, and keep the
same curl flags and eval invocation so behavior is unchanged but pinned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 5c045845-3646-4734-8864-5285b347dc5b
📒 Files selected for processing (3)
ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__ocp-4.22-lp-interop.yamlci-operator/step-registry/interop-tests/ocs-tests/interop-tests-ocs-tests-commands.shci-operator/step-registry/interop-tests/ocs-tests/interop-tests-ocs-tests-ref.yaml
|
[REHEARSALNOTIFIER]
A total of 31 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-red-hat-storage-ocs-ci-master-ocp-4.22-lp-interop-odf-aws-fips |
|
@oharan2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@oharan2: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Main changes:
Summary by CodeRabbit