COS-4080: openshift/os: add RHCOS 10 node image build#78929
COS-4080: openshift/os: add RHCOS 10 node image build#78929c4rt0 wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds RHEL CoreOS 10 to CI configs: a new base image ChangesRHEL CoreOS 10 Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@c4rt0, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
joelcapitao
left a comment
There was a problem hiding this comment.
We should also build the rhel-coreos-10-extensions like rhel-coreos-extensions (RHEL9).
Also, you need to run make jobs to re-generate the Prow jobs and commit the diff. It will clear the ci/prow/generated-config failure
|
Title should likely be in this format for the bot: |
|
/retitle COS-4080: openshift/os: add RHCOS 10 node image build |
|
@c4rt0: This pull request references COS-4080 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Thanks for the above comments @joelcapitao && @travier The pj/rehearse is looking for coreos_rhel-coreos-base_10.2 on quay.io/openshift/ci which is not there. AFAIK this isn't something related to tis PR. I tried finding current tags in the CI image stream but failed due to permission restrictions |
|
Just to add to the above - I will squash the first and last commit of this PR once I clarify what else needs to be addressed here. |
|
I think you need to add it to |
Add RHEL 10.2 node image and extensions build to CI for openshift/os master, release-5.0, and release-5.1. Also add rhel-coreos-base:10.2 to the CI image mirroring config. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse more |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
|
/pj-rehearse |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: c4rt0, joelcapitao The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-os-release-5.0-images |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-os-master-images |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-os-release-5.1-images |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse auto-ack |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
I feel like the |
|
@c4rt0: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hmmm, all of the rehearsals fail. Am I correct in thinking that this will only suceed after this PR merges? Does the rehearsal run against the cluster, which doesn't know about 10.2 yet? |
|
I believe that's a valid assumption (based on some feedback) /pj-rehearse ack |
|
@c4rt0: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add RHEL 10.2 node image build alongside the existing RHEL 9.8 in the openshift/os CI configs. Currently only the RHEL 9.8 node image is built.
Adds a second base_images entry (rhel-coreos-base:10.2) and a second images entry to build rhel-coreos-10 in:
Aditionally disabling 5.1 in the second commit.
Overview
This PR updates OpenShift CI configs in the openshift/os area to add RHEL CoreOS (RHCOS) / RHEL 10.2 node image builds so CI will validate el10 node images alongside the existing el9 builds.
Practical changes
Files changed (CI/config + mirroring):
Impact / notes for reviewers