ocp-virt-validation-checkup: add 4.22 jobs#79041
ocp-virt-validation-checkup: add 4.22 jobs#79041orenc1 wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: Oren Cohen <ocohen@redhat.com>
WalkthroughTwo new CI operator configuration files for OpenShift Virtualization validation checkup targeting release 4.22 are added, defining build image sources, resource defaults, test workflows (unit and e2e-aws), and a periodic weekly Azure e2e test job with CNV installation and validation execution steps. ChangesOpenShift CNV Validation Checkup Release 4.22 CI Setup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml`:
- Line 79: The job currently masks test failures by appending "|| true" to the
"make ci-validate" invocation; remove the "|| true" so that "make ci-validate"
returns a failing exit code when validations fail (restore proper failure
propagation for the periodic). Locate the invocation string "make ci-validate ||
true" in the job spec and change it to "make ci-validate" (or otherwise let the
shell exit non-zero), keeping the existing comment about CNV-71660 if you want
to track the issue separately.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 59fa969f-f290-4a01-bad8-4f0ff58a626c
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22.yamlci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml
| commands: | | ||
| export CSV_NAME=$(oc get csv -n openshift-cnv -o json | jq -r '.items[] | select(.metadata.name | startswith("kubevirt-hyperconverged")).metadata.name') | ||
| export OCP_VIRT_VALIDATION_IMAGE=$(oc get csv -n ${TARGET_NAMESPACE} $CSV_NAME -o json | jq -r '.spec.relatedImages[] | select(.name | contains("ocp-virt-validation-checkup")).image') | ||
| make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true" |
There was a problem hiding this comment.
Don’t mask validation failures with || true.
Line [79] turns real test failures into green jobs, which removes the periodic’s regression signal.
Suggested change
- make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true"
+ make ci-validate📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true" | |
| make ci-validate |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml`
at line 79, The job currently masks test failures by appending "|| true" to the
"make ci-validate" invocation; remove the "|| true" so that "make ci-validate"
returns a failing exit code when validations fail (restore proper failure
propagation for the periodic). Locate the invocation string "make ci-validate ||
true" in the job spec and change it to "make ci-validate" (or otherwise let the
shell exit non-zero), keeping the existing comment about CNV-71660 if you want
to track the issue separately.
|
/pj-rehearse |
|
@orenc1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| releases: | ||
| latest: | ||
| release: | ||
| channel: stable |
There was a problem hiding this comment.
is stable channel already available for OCP4.22?
| BASE_DOMAIN: cnv-devel.azure.devcluster.openshift.com | ||
| COMPUTE_NODE_TYPE: Standard_D4s_v5 | ||
| ODF_BACKEND_STORAGE_CLASS: managed-csi | ||
| ODF_OPERATOR_CHANNEL: stable-4.21 |
There was a problem hiding this comment.
is stable-4.21 available? main is using stable-4.20 I believe because it was not available at the time the job was created
There was a problem hiding this comment.
ODF 4.21 is now generally available, yes
rlobillo
left a comment
rlobillo
left a comment
There was a problem hiding this comment.
Thanks for proposing this! two minor concerns about the versioning of OCP and ODF.
|
@orenc1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
This PR adds CI/CD infrastructure support for the OpenShift Virtualization validation checkup repository (
ocp-virt-validation-checkup) on the OpenShift 4.22 release branch. It enables both pull request testing and periodic scheduled testing for CNV validation.Changes
Two new CI operator configuration files were added:
openshift-cnv-ocp-virt-validation-checkup-release-4.22.yaml(54 lines)make testcnv-e2e-ipi-awsworkflow with CNV deployment and validation checkup executionopenshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml(105 lines)e2e-azure) scheduled for Sundays at 8 PMipi-azureworkflow with Azure virtualization cluster profileBoth configurations follow the established pattern used for 4.19, 4.20, and 4.21 release branches. The configurations are source files that generate actual Prow job definitions used by OpenShift's CI infrastructure.