pf-status-relay-operator: FBC migration and operator log capture

[karampok]

Summary

• Migrate operator bundle to file-based catalog by adding skip_building_index: true, resolving deprecation warning emitted by ci-operator:

  WARN: Building index images is deprecated and will be removed from ci-operator soon.
  See https://docs.ci.openshift.org/how-tos/testing-operator-sdk-operators/#moving-to-file-based-catalog
  

  The ci-index-operator-bundle presubmit is replaced by ci-bundle-operator-bundle. The e2e-validation test already uses OO_BUNDLE so no test changes are needed.

• Capture controller-manager logs in e2e-validation artifacts. Operator pod logs were absent from CI artifacts because the namespace is cleaned up before gather-extra collection reaches it. Logs are now dumped to ARTIFACT_DIR after the deployment is confirmed Available.

Test plan

• ci-bundle-operator-bundle presubmit passes (replaces ci-index-operator-bundle)
• e2e-validation passes and operator-controller-manager.log appears in artifacts

Summary by CodeRabbit

• Chores
  • CI updated to capture operator controller-manager logs after deployment to improve test artifact collection and troubleshooting.
  • CI adjusted operator bundle handling to skip building an index during the bundle phase to streamline pipeline behavior.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karampok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/pf-status-relay-operator/OWNERS [karampok]
• ci-operator/jobs/openshift/pf-status-relay-operator/OWNERS [karampok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[karampok]

/pj-rehearse

[openshift-merge-bot]

@karampok: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 117812c4-6ac8-44fe-b4fc-ed391c6cb3b3

📥 Commits

Reviewing files that changed from the base of the PR and between 0e9ff83 and b3d723f.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml

---

Walkthrough

Updates the OpenShift CI config for pf-status-relay-operator: sets skip_building_index: true for operator bundle substitution and adds a post-deployment oc logs step in the e2e-validation job to persist controller-manager logs to ${ARTIFACT_DIR}/operator-controller-manager.log.

Changes

CI Pipeline Configuration

Layer / File(s)	Summary
Bundle Build Configuration ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml	Under operator.bundles for the operator-bundle substitution, adds skip_building_index: true.
Test Flow / Post-deployment ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml	In tests: e2e-validation, appends an oc logs command after an oc wait to write all container logs from the pf-status-relay-operator-controller-manager deployment to ${ARTIFACT_DIR}/operator-controller-manager.log and tolerates failures with `

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically summarizes the main changes: FBC migration (skip_building_index) and operator log capture (controller-manager logs).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML CI configuration files. No Ginkgo tests present. Check applies to Ginkgo test code, not CI configs.
Test Structure And Quality	✅ Passed	This PR modifies CI configuration (YAML) files only, not Ginkgo test code. The check is not applicable as it expects to review test code structure, but no test code is present in the PR changes.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies CI/CD configuration file (YAML) to add log capture and FBC migration settings. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added. Changes are limited to CI configuration: skip_building_index flag and log capture command in YAML. SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes are limited to CI operator configuration (build flags and log capture commands). No deployment manifests, operator code, or controllers are modified. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	This PR only modifies CI configuration (YAML files) in the openshift/release repository. No Go source code or OTE test binaries are affected. The check is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies CI/CD configuration (YAML) for operator bundle building and log capture. The check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@karampok: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-pf-status-relay-operator-main-ci-bundle-operator-bundle	openshift/pf-status-relay-operator	presubmit	Presubmit changed
pull-ci-openshift-pf-status-relay-operator-main-e2e-validation	openshift/pf-status-relay-operator	presubmit	Ci-operator config changed
pull-ci-openshift-pf-status-relay-operator-main-images	openshift/pf-status-relay-operator	presubmit	Ci-operator config changed
pull-ci-openshift-pf-status-relay-operator-main-security	openshift/pf-status-relay-operator	presubmit	Ci-operator config changed
pull-ci-openshift-pf-status-relay-operator-main-unit	openshift/pf-status-relay-operator	presubmit	Ci-operator config changed
pull-ci-openshift-pf-status-relay-operator-main-verify-deps	openshift/pf-status-relay-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[karampok]

/pj-rehearse

[openshift-merge-bot]

@karampok: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@karampok: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.