CNF-22982: Update ci for recert#79046
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@fontivan: This pull request references CNF-22982 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (9)
WalkthroughThis PR updates CI operator configurations for the recert project by upgrading the build root image from Go 1.22/OpenShift 4.19 to Go 1.25/OpenShift 5.0 in main, and adding a standardized ChangesCI Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fontivan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-v0.yaml (1)
43-54:⚠️ Potential issue | 🔴 Critical | ⚡ Quick win
always_run: trueandskip_if_only_changedare mutually exclusive — this config will fail validation.According to the OpenShift CI operator docs,
run_if_changed,skip_if_only_changed, andalways_run: trueare mutually exclusive. Bothcargo-checkandcargo-clippysetalways_run: truewhile simultaneously specifyingskip_if_only_changed, which is an invalid combination that will cause prowgen/ci-operator config validation to reject or misprocess these jobs.To honour the PR's intent of skipping trivial-only changes,
always_runshould be flipped tofalseon both jobs:🐛 Proposed fix
-- always_run: true +- always_run: false as: cargo-check commands: cargo check container: from: recert-check skip_if_only_changed: ^(?:.*/)?(?:\.gitignore|\.tekton/.*|\.konflux/.*|.*\.md|OWNERS|OWNERS_ALIASES|LICENSE)$ -- always_run: true +- always_run: false as: cargo-clippy commands: cargo clippy container: from: recert-check skip_if_only_changed: ^(?:.*/)?(?:\.gitignore|\.tekton/.*|\.konflux/.*|.*\.md|OWNERS|OWNERS_ALIASES|LICENSE)$🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-v0.yaml` around lines 43 - 54, The jobs cargo-check and cargo-clippy currently set always_run: true while also specifying skip_if_only_changed, which is invalid; update both job definitions (the blocks identified by "as: cargo-check" and "as: cargo-clippy") to set always_run: false so they use skip_if_only_changed as intended and pass ci-operator/prowgen validation.
🧹 Nitpick comments (1)
ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.21.yaml (1)
108-127: 💤 Low value
e2e-aws-ovn-single-node-recert-openshift-e2e-test-qeis missingskip_if_only_changed.All other
always_run: falsetests in this file received the new pattern, but this job did not. The practical impact is low sincealways_run: falsemeans it only runs when manually requested, andskip_if_only_changedcannot suppress a manual/testinvocation. Still, adding the pattern would keep it consistent with the rest of the file and with the other release-branch configs.✏️ Proposed addition for consistency
- always_run: false as: e2e-aws-ovn-single-node-recert-openshift-e2e-test-qe + skip_if_only_changed: ^(?:.*/)?(?:\.gitignore|\.tekton/.*|\.konflux/.*|.*\.md|OWNERS|OWNERS_ALIASES|LICENSE)$ steps:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.21.yaml` around lines 108 - 127, Add the missing skip_if_only_changed setting to the job definition for e2e-aws-ovn-single-node-recert-openshift-e2e-test-qe (the job with workflow openshift-e2e-aws-single-node-recert); specifically, insert skip_if_only_changed: true at the same level as steps/cluster_profile/env/observers/test so the job follows the same pattern used by other always_run: false jobs in this file and will be skipped when only non-test files change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-v0.yaml`:
- Around line 43-54: The jobs cargo-check and cargo-clippy currently set
always_run: true while also specifying skip_if_only_changed, which is invalid;
update both job definitions (the blocks identified by "as: cargo-check" and "as:
cargo-clippy") to set always_run: false so they use skip_if_only_changed as
intended and pass ci-operator/prowgen validation.
---
Nitpick comments:
In
`@ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.21.yaml`:
- Around line 108-127: Add the missing skip_if_only_changed setting to the job
definition for e2e-aws-ovn-single-node-recert-openshift-e2e-test-qe (the job
with workflow openshift-e2e-aws-single-node-recert); specifically, insert
skip_if_only_changed: true at the same level as
steps/cluster_profile/env/observers/test so the job follows the same pattern
used by other always_run: false jobs in this file and will be skipped when only
non-test files change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ff78d537-dc9f-46e1-ba73-2765be9a5d82
⛔ Files ignored due to path filters (9)
ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-v0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (9)
ci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-main.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.14.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.16.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.18.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.19.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.20.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.21.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-release-4.22.yamlci-operator/config/rh-ecosystem-edge/recert/rh-ecosystem-edge-recert-v0.yaml
fontivan
force-pushed
the
sskeard/cnf-22982-update-ci-triggers-recert
branch
from
0c310e5 to
00a924a
Compare
|
/pj-rehearse max |
|
@fontivan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc @by2waysprojects |
- update the ci jobs to not trigger if the changes are trivial or unrelated (gitignore, tekton, konflux, owners, markdown, license) - update image root for main to be OCP 5.0 Assisted-by: Cursor/auto AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0 For more information on AI attribution statements, see: https://aiattribution.github.io/
- the renovate.json file should not cause any prow tests to run as it is only used for Mintmaker configuration Assisted-by: Cursor/auto AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0 For more information on AI attribution statements, see: https://aiattribution.github.io/
fontivan
force-pushed
the
sskeard/cnf-22982-update-ci-triggers-recert
branch
from
00a924a to
85a1759
Compare
|
/cc @danmanor |
|
/pj-rehearse |
|
@fontivan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse auto-ack |
|
@fontivan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@fontivan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Assisted-by: Cursor/auto
AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0
For more information on AI attribution statements, see: https://aiattribution.github.io/
This PR updates the CI configuration for the recert component across all active release branches (4.14 through 4.22, plus main and v0) to prevent unnecessary CI job executions for trivial, non-code changes.
Primary Changes:
Skip trivial file changes: Added a standardized
skip_if_only_changedregex pattern to test job definitions across all recert CI configuration files. This pattern excludes runs when changes affect only non-functional files such as.gitignore,.tekton/,.konflux/, Markdown files,OWNERS/OWNERS_ALIASES, andLICENSE. The pattern is applied consistently to multiple job types including cargo-based tests (check, test, clippy), E2E serial/parallel tests, baremetalds tests, and infrastructure validation flows (IBU, IBI, IPC E2E flows).Updated OCP version for main: The build image root in the main branch configuration was updated from
rhel-9-release-golang-1.22-openshift-4.19torhel-9-release-golang-1.25-openshift-5.0, aligning the main branch CI with OCP 5.0 tooling requirements.Scope:
All changes are isolated to CI operator configuration for the rh-ecosystem-edge/recert component, affecting how Prow triggers test jobs without modifying the underlying code or test logic itself. The same skip pattern is applied uniformly across release branches 4.14, 4.16, 4.18, 4.19, 4.20, 4.21, 4.22, main, and v0, ensuring consistent CI behavior across branches.