Skip to content

SPLAT-2754/WIP: aws: create job for public-ipv4-pool#79125

Draft
mtulio wants to merge 1 commit into
openshift:mainfrom
mtulio:SPLAT-2754
Draft

SPLAT-2754/WIP: aws: create job for public-ipv4-pool#79125
mtulio wants to merge 1 commit into
openshift:mainfrom
mtulio:SPLAT-2754

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented May 11, 2026

Overview

This PR adds a new scheduled test job to the OpenShift 4.22 nightly release CI pipeline to validate AWS public IPv4 pool functionality. The job is currently in draft status and blocked by a CI infrastructure bug related to cluster profile filtering.

Changes

Added a monthly scheduled E2E test job (e2e-aws-public-ipv4-pool) to the OpenShift nightly 4.22 release configuration that:

  • Runs on AWS cluster infrastructure using the aws-3-quota-slice lease
  • Tests against a specific public IPv4 pool (ipv4pool-ec2-0768267342e327ea9)
  • Executes the standard OpenShift E2E test workflow

This ensures the public IPv4 pool feature is continuously validated in each release cycle.

Status

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 11, 2026

@mtulio: This pull request references SPLAT-2754 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Keeping this as draft as it is blocked by a bug on CI filtering the cluster_profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Walkthrough

A new scheduled E2E test job named e2e-aws-public-ipv4-pool was added to the OpenShift nightly 4.22 release configuration, configured to run monthly on AWS infrastructure with a specified public IPv4 pool identifier.

Changes

Cohort / File(s) Summary
E2E Test Job Configuration
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
Added new monthly scheduled E2E job e2e-aws-public-ipv4-pool with AWS cluster profile, IPv4 pool configuration, and openshift-e2e-aws workflow execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • sosiouxme
  • bradmwilliams
  • petr-muller
  • mfbonfigli
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding an AWS job for public-ipv4-pool testing. It is concise, specific, and directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds a CI job configuration, not Ginkgo test code. The job name "e2e-aws-public-ipv4-pool" is stable and deterministic. This check does not apply to CI configuration files.
Test Structure And Quality ✅ Passed Check not applicable: PR adds CI job configuration (YAML), not Ginkgo test code. Check requires reviewing test structure in Go files, which this PR doesn't modify.
Microshift Test Compatibility ✅ Passed PR adds a CI job configuration for an existing workflow, not new Ginkgo tests. The check for MicroShift test compatibility applies only to new test code definitions, not CI job configurations.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds a CI job configuration, not new Ginkgo test code. The check applies only to new tests (It(), Describe(), etc.), which are absent here.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds CI test job config, not deployment manifests or operator code. Check applies to production workloads, not CI test definitions.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check applies to Go test implementations. This PR only modifies YAML CI configuration files with no test code changes, making the check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI job configuration (YAML), not Ginkgo test code. Custom check applies to "new Ginkgo e2e tests" (It, Describe, Context). No test code changes detected.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@mtulio mtulio changed the title SPLAT-2754: aws: create job for public-ipv4-pool WIP/SPLAT-2754: aws: create job for public-ipv4-pool May 11, 2026
@mtulio mtulio changed the title WIP/SPLAT-2754: aws: create job for public-ipv4-pool SPLAT-2754/WIP: aws: create job for public-ipv4-pool May 11, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mtulio: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Keeping this as draft as it is blocked by a bug on CI filtering the cluster_profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/release/.config.prowgen`:
- Around line 853-872: The YAML list under excluded_variants contains a
malformed entry where the ci-4.15-related item and ci-4.16 were accidentally
concatenated; fix the excluded_variants list by splitting that merged string
into two separate list items (one for the existing
ci-4.15-upgrade-from-stable-4.14-from-stable-4.13 entry and a new "- ci-4.16"
entry) so each variant is its own dash-prefixed line; edit the excluded_variants
block to ensure proper YAML list formatting and that "ci-4.16" is on its own
line starting with a dash.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7222aad2-df19-44be-95c0-f169a355dcd8

📥 Commits

Reviewing files that changed from the base of the PR and between b9e28fc and 901929b.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/release/.config.prowgen
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

Comment thread ci-operator/config/openshift/release/.config.prowgen
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mtulio, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[204]: invalid cluster profile "aws-1"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented May 13, 2026

blocked by #79093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants