prowgen: remove no-op multi_arch from .config.prowgen#79173
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (12)
WalkthroughThis PR removes the top-level ChangesConfiguration cleanup: remove multi_arch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
mshort55
left a comment
There was a problem hiding this comment.
I approve the fleetshift repo changes. Thank you!
Clean up multi_arch field and remove empty configuration files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
710a302 to
a2236fc
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@Prucek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, mshort55, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Clean up multi_arch field and remove empty configuration files. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…enshift#79219) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
multi_archfield from all.config.prowgenfiles — it is not part of theProwgenstruct and is silently ignored by prowgen.config.prowgenfiles that had no other content besidesmulti_archmulti_archlines from 10 files that still have other fields (e.g.,slack_reporter)Context
The
multi_archfield exists on individual image build items in ci-operator config (images.items[].multi_arch), but it was never a recognized field in.config.prowgen. These entries are no-ops that were added by users assuming they had an effect at the prowgen level.Test plan
ci/prow/generated-configpasses (no job generation changes expected since multi_arch was a no-op)ci/prow/ci-operator-configpasses🤖 Generated with Claude Code
Summary
This PR removes a no-op top-level multi_arch field from .config.prowgen files across multiple OpenShift component repositories and related projects. The field was never part of the Prowgen struct and was silently ignored by prowgen, so these entries were effectively inert and potentially misleading.
What changed in practical terms
Scope of changes
Rationale
Test plan / impact