Skip to content

prowgen: remove no-op multi_arch from .config.prowgen#79173

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:remove-multi-arch-prowgen
May 13, 2026
Merged

prowgen: remove no-op multi_arch from .config.prowgen#79173
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:remove-multi-arch-prowgen

Conversation

@Prucek
Copy link
Copy Markdown
Member

@Prucek Prucek commented May 12, 2026

Summary

  • Remove the multi_arch field from all .config.prowgen files — it is not part of the Prowgen struct and is silently ignored by prowgen
  • Delete 18 .config.prowgen files that had no other content besides multi_arch
  • Strip multi_arch lines from 10 files that still have other fields (e.g., slack_reporter)

Context

The multi_arch field exists on individual image build items in ci-operator config (images.items[].multi_arch), but it was never a recognized field in .config.prowgen. These entries are no-ops that were added by users assuming they had an effect at the prowgen level.

Test plan

  • ci/prow/generated-config passes (no job generation changes expected since multi_arch was a no-op)
  • ci/prow/ci-operator-config passes

🤖 Generated with Claude Code

Summary

This PR removes a no-op top-level multi_arch field from .config.prowgen files across multiple OpenShift component repositories and related projects. The field was never part of the Prowgen struct and was silently ignored by prowgen, so these entries were effectively inert and potentially misleading.

What changed in practical terms

  • Cleans up prowgen configuration used to generate Prow job/notification configuration for many component repositories and infra projects. This is purely a configuration cleanup — it does not change image build multi-arch behavior (which is governed by ci-operator image config) nor is it expected to change generated Prow jobs.
  • After this change, prowgen-config files no longer contain the unused top-level multi_arch key, reducing confusion about what prowgen recognizes.

Scope of changes

  • Removed multi_arch entirely from 28 .config.prowgen files across repositories (deleting the files in 18 cases where that was the only content, and stripping the multi_arch line from 10 files that also contain other config such as slack_reporter).
  • Repositories / areas affected include various Velero plugins, OADP components, migration tooling (migtools), fleetshift projects, openshift/* components (machine-config-operator, multiarch-tuning-operator, velero, loki, kueue-operator, ci-tools), stolostron image-builder, and related project directories (outrigger-project, etc.). Files containing Slack reporter configuration retain those sections unchanged except for removal of the multi_arch line.

Rationale

  • multi_arch is valid in ci-operator image entries (images.items[].multi_arch) but was never implemented/recognized in .config.prowgen; these entries were therefore no-ops inserted under an incorrect assumption. Removing them clarifies intent and avoids confusion.

Test plan / impact

  • Run ci/prow/generated-config and ci/prow/ci-operator-config as proposed — no Prow job generation changes are expected.
  • No runtime or build behavior changes expected for CI or component repositories beyond cleaned configuration files.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b856ca6f-2f33-4b25-a6f5-212c02d6ea5c

📥 Commits

Reviewing files that changed from the base of the PR and between 710a302 and a2236fc.

📒 Files selected for processing (12)
  • ci-operator/config/fleetshift/fleetshift-poc/.config.prowgen
  • ci-operator/config/fleetshift/fleetshift-user-interface/.config.prowgen
  • ci-operator/config/migtools/filebrowser/.config.prowgen
  • ci-operator/config/migtools/kubevirt-datamover-controller/.config.prowgen
  • ci-operator/config/migtools/kubevirt-datamover-plugin/.config.prowgen
  • ci-operator/config/migtools/oadp-cli/.config.prowgen
  • ci-operator/config/migtools/oadp-non-admin/.config.prowgen
  • ci-operator/config/migtools/oadp-vm-file-restore/.config.prowgen
  • ci-operator/config/migtools/oadp-vmdp/.config.prowgen
  • ci-operator/config/oadp-qe/oadp-operator/.config.prowgen
  • ci-operator/config/openshift-eng/agent-qe-infra/.config.prowgen
  • ci-operator/config/openshift-eng/baremetal-qe-infra/.config.prowgen
💤 Files with no reviewable changes (12)
  • ci-operator/config/migtools/oadp-vmdp/.config.prowgen
  • ci-operator/config/oadp-qe/oadp-operator/.config.prowgen
  • ci-operator/config/migtools/oadp-non-admin/.config.prowgen
  • ci-operator/config/migtools/oadp-vm-file-restore/.config.prowgen
  • ci-operator/config/fleetshift/fleetshift-user-interface/.config.prowgen
  • ci-operator/config/fleetshift/fleetshift-poc/.config.prowgen
  • ci-operator/config/migtools/kubevirt-datamover-controller/.config.prowgen
  • ci-operator/config/openshift-eng/agent-qe-infra/.config.prowgen
  • ci-operator/config/migtools/kubevirt-datamover-plugin/.config.prowgen
  • ci-operator/config/openshift-eng/baremetal-qe-infra/.config.prowgen
  • ci-operator/config/migtools/filebrowser/.config.prowgen
  • ci-operator/config/migtools/oadp-cli/.config.prowgen

Walkthrough

This PR removes the top-level multi_arch entry from multiple ci-operator .config.prowgen files (mostly single-line deletions). A small subset also adjusts slack_reporter.job_names entries in their configs.

Changes

Configuration cleanup: remove multi_arch

Layer / File(s) Summary
Remove multi_arch top-level key
ci-operator/config/fleetshift/*, ci-operator/config/migtools/*, ci-operator/config/oadp-qe/*, ci-operator/config/openshift-eng/*, ci-operator/config/openshift/*, ci-operator/config/outrigger-project/*, ci-operator/config/stolostron/*
Deleted multi_arch: true / multi_arch: yes from all listed .config.prowgen files (single-line removals across many projects).
Slack reporter job-name adjustments
ci-operator/config/openshift/machine-config-operator/.config.prowgen, ci-operator/config/openshift/multiarch-tuning-operator/.config.prowgen, ci-operator/config/outrigger-project/multiarch-tuning-operator/.config.prowgen
Updated slack_reporter.job_names lists (added/moved e2e-aws-ovn-upgrade-ocl or e2e-aws-ovn-proxy-mto-origin entries) alongside the multi_arch removals.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the no-op multi_arch field from .config.prowgen files across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only .config.prowgen CI configuration files, not Ginkgo test files. No test code exists in these changes, so the stable test names check does not apply.
Test Structure And Quality ✅ Passed PR is about removing multi_arch fields from .config.prowgen configuration files. No Ginkgo test code is present in this PR, making the custom check inapplicable.
Microshift Test Compatibility ✅ Passed PR modifies only CI/Prowgen configuration files and does not add new Ginkgo e2e tests. The MicroShift Test Compatibility check is not applicable without new test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains no new Ginkgo e2e tests. All changes are to .config.prowgen CI configuration files. The SNO Test Compatibility check does not apply to non-test code changes.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI/CD configuration files (.config.prowgen) only, not deployment manifests, operator code, or controllers. Topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed Check not applicable. PR contains only YAML configuration file modifications with zero Go code changes. The OTE Binary Stdout Contract check applies to Go test binaries, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only removes configuration entries from .config.prowgen files. The IPv6/disconnected network check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 12, 2026
@Prucek Prucek marked this pull request as draft May 12, 2026 10:58
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2026
Copy link
Copy Markdown
Contributor

@mshort55 mshort55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the fleetshift repo changes. Thank you!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
Clean up multi_arch field and remove empty configuration files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Prucek Prucek force-pushed the remove-multi-arch-prowgen branch from 710a302 to a2236fc Compare May 13, 2026 06:50
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@Prucek Prucek marked this pull request as ready for review May 13, 2026 06:50
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@openshift-ci openshift-ci Bot requested review from aleskandro and eemcmullan May 13, 2026 06:51
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, mshort55, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Prucek,danilo-gemoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c90324a into openshift:main May 13, 2026
13 checks passed
openshift-merge-bot Bot pushed a commit that referenced this pull request May 13, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 13, 2026
Clean up multi_arch field and remove empty configuration files.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 13, 2026
…enshift#79219)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants