Skip to content

CNTRLPLANE-3441: Remove aws-ipi-ovn-hypershift n-minor skew tests from openshift-tests…#79229

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mgencur:remove_cp_dp_compat
May 21, 2026
Merged

CNTRLPLANE-3441: Remove aws-ipi-ovn-hypershift n-minor skew tests from openshift-tests…#79229
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mgencur:remove_cp_dp_compat

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented May 13, 2026

…-private

Remove n1minor, n2minor, and n3minor guest and mgmt periodic tests from 4.21, 4.22, and 5.0 amd64-nightly configs. These version skew tests are redundant with the skew testing in openshift/hypershift.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3441
See JIRA for why they're being removed.

Summary

This PR removes redundant version-skew tests from the openshift-tests-private CI configuration across three release versions. Specifically, it eliminates the n1minor, n2minor, and n3minor guest and management periodic test entries for aws-ipi-ovn-hypershift from the amd64-nightly test streams for OpenShift 4.21, 4.22, and 5.0.

Changes

The removal affects three CI configuration files:

  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml

Each file has approximately 170 lines removed corresponding to the n-minor version-skew test variants (both -mgmt and -guest configurations across multiple F-series variants).

Rationale

These version-skew tests are being removed because equivalent testing coverage for version compatibility already exists in the openshift/hypershift repository, making these tests redundant in the openshift-tests-private configuration.

…-private

Remove n1minor, n2minor, and n3minor guest and mgmt periodic tests
from 4.21, 4.22, and 5.0 amd64-nightly configs. These version skew
tests are redundant with the skew testing in openshift/hypershift.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Walkthrough

Three OpenShift CI test manifests (releases 4.21, 4.22, and 5.0) are updated by removing deprecated hypershift OVN test jobs (aws-ipi-ovn-hypershift-n{1,2,3}minor variants) and adding new test job entries (aws-ipi-ovn-hypershift-shared-vpc-guest/mgmt, aws-ipi-ovn-ipsec, aws-ipi-ovn-winc).

Changes

CI Test Manifest Job Updates

Layer / File(s) Summary
Hypershift test job replacement across release manifests
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml, ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml, ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
Remove aws-ipi-ovn-hypershift-n{1,2,3}minor-{mgmt,guest} test job entries across F14/F28 variants for releases 4.21, 4.22, and 5.0. Add new aws-ipi-ovn-hypershift-shared-vpc-{guest,mgmt}, aws-ipi-ovn-ipsec, and aws-ipi-ovn-winc test job entries to replace them.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive No result was produced after verification. Marking as INCONCLUSIVE. Re-run the check or adjust instructions to produce a final result.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed Custom check requires review of Ginkgo test code. This PR only modifies CI/CD YAML configuration files that schedule tests, not the actual test code itself. Not applicable.
Microshift Test Compatibility ✅ Passed PR removes test job configurations from CI YAML files and adds no new Ginkgo e2e tests. The MicroShift Test Compatibility check applies only to new test code, not CI configuration changes.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are only to CI configuration YAML files that remove (not add) test job entries. The SNO compatibility check only applies when new tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies Prow CI test configuration files, not deployment manifests or operator code. Custom check applies only to scheduling constraints in Kubernetes resources.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check verifies OTE binary code for stdout issues. This PR only modifies YAML CI configuration files, not OTE source code. Check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI operator YAML configuration files. No new Ginkgo e2e test code is added. The check applies only when new tests are added, not applicable here.
Title check ✅ Passed The title accurately describes the main change: removing aws-ipi-ovn-hypershift n-minor skew tests from openshift-tests configuration files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mgencur mgencur changed the title Remove aws-ipi-ovn-hypershift n-minor skew tests from openshift-tests… CNTRLPLANE-3441: Remove aws-ipi-ovn-hypershift n-minor skew tests from openshift-tests… May 13, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2026

@mgencur: This pull request references CNTRLPLANE-3441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

…-private

Remove n1minor, n2minor, and n3minor guest and mgmt periodic tests from 4.21, 4.22, and 5.0 amd64-nightly configs. These version skew tests are redundant with the skew testing in openshift/hypershift.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3441
See JIRA for why they're being removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from memodi and oliver-smakal May 13, 2026 09:15
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Copy link
Copy Markdown
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mffiedler
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@jiezhao16
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiezhao16, jparrill, mffiedler, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented May 20, 2026

/test config

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2cc3bda and 2 for PR HEAD 825dbb9 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit be66659 into openshift:main May 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants