Fix daily status Slack links to include STS jobs by dustman9000 · Pull Request #79247 · openshift/release

dustman9000 · 2026-05-13T14:22:51Z

The report_template for rosa-ci-daily-status had hardcoded Prow filter links using the old *rosa-hcp-e2e-nightly* pattern, which only showed HCP jobs. Updated to *rosa-*e2e-nightly* to include both HCP and STS nightly jobs.

Moved reporter_config from hand-edited generated file to source ci-operator config so it survives make jobs.

This PR updates the ROSA E2E ci-operator config (openshift-online/rosa-e2e) to make the daily Slack status reporter durable in source and to ensure nightly STS jobs are included in the report links.

What changed

Added a persistent reporter_config to the rosa-ci-daily-status test in ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml (moved from a hand-edited generated file into the source ci-operator config).
- channel: #wg-rosa-ci-enhancement
- job_states_to_report: success, failure, error
- report_template: templated Slack message that adapts for success vs non-success and appends links (full Prow report, ROSA E2E periodics, OCM FVT, HCP and STS nightly job filters, and Sippy).
Updated the Prow filter patterns in the report template so nightly job links include both HCP and STS nightly jobs (the template now references broader rosa-* patterns rather than only the HCP-only pattern).

Impact

Daily Slack summaries for ROSA will now include STS nightly results alongside HCP, giving a more complete view of nightly conformance.
Moving reporter_config into the source ci-operator config prevents the reporter settings from being lost when regenerating jobs with make jobs, reducing the need for manual edits.

coderabbitai · 2026-05-13T14:23:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7adb67a9-ed86-400b-a81b-5b32dad7eb28

📥 Commits

Reviewing files that changed from the base of the PR and between f778ae3 and ac4352d.

📒 Files selected for processing (1)

ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml

Walkthrough

Adds a reporter_config to the rosa-ci-daily-status CI job in the ROSA E2E config, specifying a Slack channel, job_states_to_report (success, failure, error), and a report_template that conditionally formats messages and appends multiple Prow/Sippy links.

Changes

ROSA E2E CI Slack Reporting

Layer / File(s)	Summary
Slack reporter configuration `ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`	Adds `reporter_config` to `rosa-ci-daily-status` with keys: `channel` (`#wg-rosa-ci-enhancement`), `job_states_to_report` (`success`, `failure`, `error`), and a `report_template` that branches on `.Status.State` and includes links (full Prow report, ROSA E2E periodic jobs, OCM FVT ROSA jobs, HCP/Classic nightly jobs, Sippy).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

openshift/release#79215: Also updates the ROSA E2E daily Slack report configuration and link content.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

ravitri
gdbranco

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating Slack links in the daily status report to include STS jobs alongside HCP jobs by modifying the Prow filter pattern.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR only modifies CI configuration YAML files and contains no Ginkgo test code. The custom check for stable test names is not applicable to configuration changes.
Test Structure And Quality	✅ Passed	The PR modifies only CI configuration YAML files to update Slack reporting config. No Ginkgo test code is added or modified in this PR. The custom check for test quality is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies CI operator config (YAML file). Custom check applies only when new Ginkgo tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only CI/CD configuration (YAML file), not test code. No new Ginkgo e2e tests are added, making the SNO compatibility check inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies a CI test configuration file, not deployment manifest or controller code. The reporter_config addition is for Slack reporting only and introduces no scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies only a YAML CI configuration file. The OTE binary stdout contract check does not apply to CI configuration changes; no source code is modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add Ginkgo e2e tests. It only modifies CI operator configuration YAML files. The custom check is only applicable when new Ginkgo e2e tests (It(), Describe(), etc.) are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-13T14:23:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift-online/rosa-e2e/OWNERS~~ [dustman9000]
~~ci-operator/jobs/openshift-online/rosa-e2e/OWNERS~~ [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dustman9000 · 2026-05-13T15:13:48Z

/retest

bmeng · 2026-05-13T23:31:22Z

      report_template: |-
        {{if eq .Status.State "success"}}:large_green_circle: *ROSA CI Daily Status:* all jobs passing{{else}}:red_circle: *ROSA CI Daily Status:* failures detected{{end}} (<{{.Status.URL}}|Full report>)
-        <https://prow.ci.openshift.org/?type=periodic&job=*rosa-hcp-e2e-nightly*|ROSA E2E> | <https://prow.ci.openshift.org/?type=periodic&job=*ocm-fvt*rosa*|OCM FVT> | <https://prow.ci.openshift.org/?type=periodic&job=*main-nightly-*e2e-rosa-hcp-ovn|HCP Conformance> | <https://prow.ci.openshift.org/?type=periodic&job=*main-nightly-*e2e-rosa-sts-ovn|Classic STS Conformance>
+        <https://prow.ci.openshift.org/?type=periodic&job=*rosa-*e2e-nightly*|ROSA E2E> | <https://prow.ci.openshift.org/?type=periodic&job=*ocm-fvt*rosa*|OCM FVT> | <https://prow.ci.openshift.org/?type=periodic&job=*main-nightly-*e2e-rosa-hcp-ovn|HCP Conformance> | <https://prow.ci.openshift.org/?type=periodic&job=*main-nightly-*e2e-rosa-sts-ovn|Classic STS Conformance>


the job name for rosa-e2e would not be nightly once the change in #79215 merged

bmeng · 2026-05-13T23:31:34Z

/hold

Move reporter_config from hand-edited generated file to source ci-operator config so it survives make jobs. Update Prow filter from *rosa-hcp-e2e-nightly* to *rosa-*e2e-nightly* to include both HCP and STS nightly jobs.

Run make ci-operator-config to match canonical format.

PR openshift#79215 renamed periodic jobs from nightly to stable/candidate channel groups. Update the daily status Prow filter link from *rosa-*e2e-nightly* to *rosa-e2e-main-periodics-rosa-* to match all rosa-e2e periodic jobs regardless of channel group.

dustman9000 · 2026-05-14T14:53:18Z

Rebased onto main (which now includes #79215) and updated the ROSA E2E Prow filter link.

PR #79215 renamed the periodic jobs from nightly to stable/candidate channel groups, so the old filter *rosa-*e2e-nightly* no longer matches. Updated to *rosa-e2e-main-periodics-rosa-* which matches all rosa-e2e periodic jobs regardless of channel group (stable, candidate, nightly for 5.0).

@bmeng please /hold cancel when you get a chance.

openshift-merge-bot · 2026-05-14T14:56:19Z

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-online-rosa-e2e-main-rosa-ci-daily-status	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

dustman9000 · 2026-05-14T15:27:41Z

/retest

dustman9000 · 2026-05-14T15:50:05Z

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-rosa-ci-daily-status

openshift-merge-bot · 2026-05-14T15:50:07Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-05-14T16:02:48Z

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-rosa-ci-daily-status	`ac4352d`	link	unknown	`/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-rosa-ci-daily-status`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dustman9000 · 2026-05-14T16:03:39Z

/pj-rehearse ack

openshift-merge-bot · 2026-05-14T16:03:41Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci Bot requested review from bmeng and ravitri May 13, 2026 14:23

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026

bmeng reviewed May 13, 2026

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026

dustman9000 added 3 commits May 14, 2026 07:47

Fix daily status Slack links to include STS jobs

c8ce02c

Move reporter_config from hand-edited generated file to source ci-operator config so it survives make jobs. Update Prow filter from *rosa-hcp-e2e-nightly* to *rosa-*e2e-nightly* to include both HCP and STS nightly jobs.

Normalize report_template YAML formatting

9cb6485

Run make ci-operator-config to match canonical format.

dustman9000 force-pushed the fix/daily-status-slack-links branch from f778ae3 to ac4352d Compare May 14, 2026 14:53

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2026

dustman9000 closed this May 18, 2026

Conversation

dustman9000 commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

dustman9000 commented May 13, 2026

Uh oh!

bmeng May 13, 2026

Choose a reason for hiding this comment

Uh oh!

bmeng commented May 13, 2026

Uh oh!

dustman9000 commented May 14, 2026

Uh oh!

openshift-merge-bot Bot commented May 14, 2026

Uh oh!

dustman9000 commented May 14, 2026

Uh oh!

dustman9000 commented May 14, 2026

Uh oh!

openshift-merge-bot Bot commented May 14, 2026

Uh oh!

openshift-ci Bot commented May 14, 2026

Uh oh!

dustman9000 commented May 14, 2026

Uh oh!

openshift-merge-bot Bot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dustman9000 commented May 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading