Skip to content

freshening OLM QE user lists for labels#79271

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grokspawn:china-cry
May 13, 2026
Merged

freshening OLM QE user lists for labels#79271
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grokspawn:china-cry

Conversation

@grokspawn
Copy link
Copy Markdown
Contributor

@grokspawn grokspawn commented May 13, 2026

Recently the user lists were updated, but as of yet no new folks were identified to replace them, so this PR just removes the folks who aren't available anymore. 😢

Freshening OLM QE user lists for labels

This PR removes four unavailable users from OpenShift CI's Prow authorization configurations for the OLM (Operator Lifecycle Manager) ecosystem projects. The changes affect label approval permissions across three operator framework repositories:

  • cluster-olm-operator — the base OLM cluster operator
  • operator-framework-olm — the OLM runtime
  • operator-framework-operator-controller — the operator controller

Practical impact: The removed users (jianzhangbjz, kuiwang02, Xia-Zhao-rh) are no longer authorized to approve or apply restricted labels in pull requests to these repositories. Only bandrade remains authorized for these operations. This prevents unavailable team members from being listed as approvers for OLM-related CI workflows, ensuring the approval chains reflect current team availability. As noted in the PR description, replacements for the departed users have not yet been identified, so these entries are being deleted pending future assignments.

Signed-off-by: grokspawn <jordan@nimblewidget.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d40240d2-f1ff-4e58-b1d7-1173e7deb8a4

📥 Commits

Reviewing files that changed from the base of the PR and between 910a89c and 5a89824.

📒 Files selected for processing (3)
  • core-services/prow/02_config/openshift/cluster-olm-operator/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/operator-framework-olm/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/operator-framework-operator-controller/_pluginconfig.yaml
💤 Files with no reviewable changes (3)
  • core-services/prow/02_config/openshift/operator-framework-olm/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/cluster-olm-operator/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/operator-framework-operator-controller/_pluginconfig.yaml

Walkthrough

The PR removes three users (jianzhangbjz, kuiwang02, Xia-Zhao-rh) from restricted label approval permissions in Prow plugin configurations across three OpenShift repositories, retaining only bandrade as an allowed user for label operations.

Changes

Restricted Label User Permissions Update

Layer / File(s) Summary
User removal from restricted label allowlists
core-services/prow/02_config/openshift/cluster-olm-operator/_pluginconfig.yaml, core-services/prow/02_config/openshift/operator-framework-olm/_pluginconfig.yaml, core-services/prow/02_config/openshift/operator-framework-operator-controller/_pluginconfig.yaml
Three users (jianzhangbjz, kuiwang02, Xia-Zhao-rh) are removed from allowed_users lists under restricted label configurations in each repository's Prow plugin config, leaving only bandrade. Additional jianzhangbjz entries are also removed from secondary restricted-labels sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'freshening OLM QE user lists for labels' directly and accurately describes the main change—removing unavailable users from OLM QE configuration lists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only Prow YAML configuration files (not test files). The check targets Ginkgo test names, which are not present in this PR. Check is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only YAML configuration files (Prow plugin settings), not Ginkgo test code. The custom check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR only modifies Prow configuration YAML files to remove users from OLM QE team lists. No new Ginkgo e2e tests are added. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies Prow YAML configuration files removing users from allowed_users lists. No Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Prow CI/CD configuration files managing user label permissions. No deployment manifests, operator code, controllers, or scheduling constraints are involved.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML configuration files for Prow. Check targets stdout in process-level code. No executable code present, so check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Check not applicable. PR only modifies YAML Prow plugin configurations for user permissions. No Ginkgo e2e tests or Go code added. Custom check targets e2e tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@grokspawn: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bandrade
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bandrade, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8ab2381 into openshift:main May 13, 2026
12 checks passed
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants