Skip to content

NO-JIRA: feat: add override plugin for edge-tooling#79285

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:add-override-function
May 14, 2026
Merged

NO-JIRA: feat: add override plugin for edge-tooling#79285
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:add-override-function

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented May 14, 2026

This PR enables the Prow override plugin for the openshift-eng/edge-tooling repository by adding it to the plugin list in the repository's Prow configuration.

The override plugin is a Prow feature that allows authorized users to bypass certain status checks and proceed with pull request merges when needed. For the edge-tooling repository, this enables developers to override blocking checks in exceptional cases where necessary, improving operational flexibility for that project's CI/CD workflow.

The change is minimal—a single line addition to the plugin configuration file—but enables new functionality for the edge-tooling project's pull request handling within the OpenShift CI infrastructure.

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a6f8f80d-c375-49eb-a6be-6f2c871309a6

📥 Commits

Reviewing files that changed from the base of the PR and between dc82967 and 134ba56.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml

Walkthrough

A single override plugin is added to the Prow plugin configuration list for the openshift-eng/edge-tooling repository.

Changes

Prow Plugin Configuration Update

Layer / File(s) Summary
Override plugin addition
core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml
The override plugin is registered in the plugins list for the openshift-eng/edge-tooling Prow configuration, positioned between existing lgtm and trigger/verify-owners entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding an override plugin for the edge-tooling repository, which aligns with the file modification shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a YAML configuration file (_pluginconfig.yaml), not Ginkgo test code. No test name declarations are present in this PR.
Test Structure And Quality ✅ Passed This PR modifies only a YAML prow plugin configuration file, not Ginkgo test code. The custom check for test structure/quality is not applicable.
Microshift Test Compatibility ✅ Passed This PR only modifies a Prow plugin configuration YAML file, adding the 'override' plugin entry. No Ginkgo e2e tests or Go test code are added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds only Prow plugin configuration (YAML) for edge-tooling, not Ginkgo e2e tests. The custom check applies only to PRs with new e2e tests, making it not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed Change is a Prow CI/CD plugin configuration file, not a deployment manifest, operator code, or controller. The topology-aware scheduling check does not apply to Prow configuration files.
Ote Binary Stdout Contract ✅ Passed PR only modifies a YAML plugin configuration file with no executable code. OTE Binary Stdout Contract check applies only to process-level code, which is not present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds a Prow plugin configuration file and utility test changes, not Ginkgo e2e tests. The IPv6/disconnected network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@openshift-ci openshift-ci Bot requested review from agullon and jeff-roche May 14, 2026 04:12
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d672489 into openshift:main May 14, 2026
12 checks passed
@eggfoobar eggfoobar deleted the add-override-function branch May 14, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants