Skip to content

ci: drop IBM Z heavy-build periodic; run full parallel suite in conforrmance#79292

Open
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:remove-heavy-build-z
Open

ci: drop IBM Z heavy-build periodic; run full parallel suite in conforrmance#79292
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:remove-heavy-build-z

Conversation

@ibm-adarsh
Copy link
Copy Markdown
Contributor

@ibm-adarsh ibm-adarsh commented May 14, 2026

Remove the separate ocp-heavy-build-ovn-remote-libvirt-s390x periodic jobs
from openshift/multiarch nightly configs (4.12–4.16) and regenerate Prow
periodics.

Delete the libvirt conf logic that excluded bandwidth-heavy build/image tests
from conformance-parallel on s390x (≤4.16) or materialized them as a dedicated
test list for heavy-build jobs.

Remove the heavy-build TEST_TYPE branch and heavy_build helper from the
libvirt e2e test step, since that job type is no longer used.

Rationale: Z conformance parallel jobs should run the full openshift/
conformance/parallel suite without a split heavy-build lane.

Summary

This PR removes the separate heavy-build periodic jobs for IBM Z (s390x) from OpenShift's multiarch nightly CI pipeline and consolidates s390x conformance testing into the standard parallel test suite without an exclusions-based split.

Changes

CI Job Configuration (nightly releases 4.12–4.16)

  • Removed the ocp-heavy-build-ovn-remote-libvirt-s390x periodic job definition from each release's multiarch nightly configuration
  • Each job removal eliminates its scheduled cron trigger, cluster profile assignment (libvirt-s390x-2 or libvirt-s390x-vpn), and TEST_TYPE=heavy-build environment variable
  • The corresponding standard conformance jobs (ocp-e2e-ovn-remote-libvirt-s390x) on s390x now run with TEST_TYPE=conformance-parallel without restrictions

Test Execution Scripts

  • openshift-e2e-libvirt-conf-commands.sh: Removed the previous s390x "yellow zone" logic that redirected heavy-build runs to an excluded tests list for branches 4.16 and below; replaced with multi-architecture cluster-specific exclusions only for mixed-arch compute nodes
  • openshift-e2e-libvirt-test-commands.sh: Removed the heavy_build() helper function and its associated TEST_TYPE=heavy-build case dispatch, eliminating the separate test execution path for heavy-build jobs

Impact

s390x conformance testing on libvirt now runs the complete openshift/conformance/parallel test suite without test filtering or separate heavy-build lanes, consolidating the CI pipeline for this architecture.

…rmance

Signed-off-by: Adarsh Kumar Yadav <adarsh.kumar.yadav1@ibm.com>
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

Hi @ibm-adarsh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibm-adarsh
Once this PR has been reviewed and has the lgtm label, please assign sherine-k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a52b6f38-3698-464e-8bce-f94e5304fd86

📥 Commits

Reviewing files that changed from the base of the PR and between 849b963 and 68f5657.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (7)
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.12.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.13.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.14.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.15.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.16.yaml
  • ci-operator/step-registry/openshift/e2e/libvirt/conf/openshift-e2e-libvirt-conf-commands.sh
  • ci-operator/step-registry/openshift/e2e/libvirt/test/openshift-e2e-libvirt-test-commands.sh
💤 Files with no reviewable changes (7)
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.13.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.15.yaml
  • ci-operator/step-registry/openshift/e2e/libvirt/test/openshift-e2e-libvirt-test-commands.sh
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.12.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.16.yaml
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.14.yaml
  • ci-operator/step-registry/openshift/e2e/libvirt/conf/openshift-e2e-libvirt-conf-commands.sh

Walkthrough

This PR removes the ocp-heavy-build-ovn-remote-libvirt-s390x CI job definition from multiarch nightly configurations for OpenShift versions 4.12–4.16 and removes corresponding heavy-build test type support from libvirt test execution scripts, replacing s390x-specific yellow-zone logic with heterogeneous cluster handling.

Changes

Heavy-Build Functionality Removal

Layer / File(s) Summary
Heavy-build job removal from nightly configurations
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.{12,13,14,15,16}.yaml
The ocp-heavy-build-ovn-remote-libvirt-s390x job definition is deleted from all five nightly version configurations. Version 4.14 additionally updates the regular e2e job to include TEST_TYPE: conformance-parallel and NODE_TUNING: "true" environment settings, consolidating behavior previously split across separate jobs.
Test execution and configuration cleanup
ci-operator/step-registry/openshift/e2e/libvirt/conf/openshift-e2e-libvirt-conf-commands.sh, ci-operator/step-registry/openshift/e2e/libvirt/test/openshift-e2e-libvirt-test-commands.sh
The conf script removes s390x yellow-zone exclusion handling (applicable to branches 4.16 and below) and replaces it with heterogeneous cluster multi-architecture exclusion logic keyed by TEST_TYPE=conformance-parallel and cluster type matching. The test script removes the heavy_build() helper function and its corresponding heavy-build case in the test-type dispatch, consolidating all heavy-build execution into the conformance-parallel path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • neisw
  • wking
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removal of IBM Z heavy-build periodic jobs and running full parallel suite in conformance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI config and test scripts only, not Ginkgo test code. No test names are defined or modified.
Test Structure And Quality ✅ Passed PR modifies CI/CD configuration YAML and bash shell scripts only. No Ginkgo test code is added or modified. The custom check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed Custom check is not applicable. This PR removes CI jobs and helper script logic, but does not add any new Ginkgo e2e tests. The MicroShift compatibility check only applies when new tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It removes CI job definitions and updates test infrastructure scripts. The custom check is only applicable when new tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed Check is not applicable. PR modifies only CI test infrastructure (job configs and test scripts), not production deployment manifests, operator code, or controllers.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is not applicable to this PR. The PR only modifies YAML CI configuration files and shell scripts, not Go OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check does not apply: PR removes CI job definitions and test infrastructure (no net additions to code). The check applies only when new Ginkgo e2e tests are added, which this PR does not do.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch remove-heavy-build-z

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ibm-adarsh, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 849b963476539c95e4515be5604ec35786e01521 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot requested review from alkleinrh and andymcc May 14, 2026 09:44
@ibm-adarsh
Copy link
Copy Markdown
Contributor Author

Variant Cron When it ran
nightly-4.12 0 0 25 12 * Dec 25, 00:00 UTC — once per year
nightly-4.13 0 0 2 1 * Jan 2, 00:00 UTC — once per year
nightly-4.14 0 0 10 1 * Jan 10, 00:00 UTC — once per year
nightly-4.15 0 0 18 1 * Jan 18, 00:00 UTC — once per year
nightly-4.16 0 0 26 1 * Jan 26, 00:00 UTC — once per year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant