Add disconnected validation step to ocp-virt-validation-checkup CI jobs#79293
Add disconnected validation step to ocp-virt-validation-checkup CI jobs#79293rlobillo wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a disconnected validation CI path: a new ChangesDisconnected Validation Checkup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main__periodics.yaml (1)
102-105: ⚡ Quick winScope the
podmanshim to supported verbs only.While the disconnected target likely uses only
podman login, the current shim forwards all subcommands to skopeo. Skopeo supports only a limited set of verbs (login, copy, inspect); if the target later callspodman pull,podman push, or other unsupported commands, the shim will silently fail instead of erroring. Restrict the wrapper to explicitly handleloginand reject unknown verbs with a clear error message.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main__periodics.yaml` around lines 102 - 105, The inline shell shim podman() currently forwards all verbs to skopeo; replace it with a scoped wrapper that only allows the supported verb(s): check the first argument inside the podman() function (e.g., "$1") and if it equals "login" call skopeo login with the same arguments, otherwise print a clear error message to stderr and exit with a non-zero status; keep the existing command -v checks and export -f podman so the function is available.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main__periodics.yaml`:
- Around line 102-105: The inline shell shim podman() currently forwards all
verbs to skopeo; replace it with a scoped wrapper that only allows the supported
verb(s): check the first argument inside the podman() function (e.g., "$1") and
if it equals "login" call skopeo login with the same arguments, otherwise print
a clear error message to stderr and exit with a non-zero status; keep the
existing command -v checks and export -f podman so the function is available.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 62968f6b-3ea1-4b61-9209-9142fe4f1a32
📒 Files selected for processing (2)
ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main.yamlci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main__periodics.yaml
|
/pj-rehearse |
|
@rlobillo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…heckup CI jobs Add src-disconnected image (src + skopeo) and podman wrapper script for disconnected validation in CI environments without podman. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rlobillo
force-pushed
the
self-validation-disconnected
branch
from
0f04172 to
b991376
Compare
|
/pj-rehearse pull-ci-openshift-cnv-ocp-virt-validation-checkup-main-e2e-aws |
|
@rlobillo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rlobillo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@rlobillo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
run-validation-checkup-disconnectedinline test step to the presubmit (e2e-aws) and periodic (e2e-azure) CI jobs forocp-virt-validation-checkuppodman→skopeoshell wrapper since CI pods lackpodmanChanges
ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main.yamlrun-validation-checkup-disconnectedstep toe2e-awspresubmitci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-main__periodics.yamlrun-validation-checkup-disconnectedstep toe2e-azureperiodicWhat this PR does / why we need it
The
make ci-validate-disconnectedtarget runs the validation checkup in a simulated disconnected environment (mirrors images to internal registry, applies ITMS+IDMS withNeverContactSource). This already works locally but had no CI coverage.Presubmit (e2e-aws): Uses
dependenciesblock for locally-built image, 1 env var (STORAGE_CLASS), 3h timeout.Periodic (e2e-azure): Uses CSV-based dynamic image resolution (no
dependencies), 6 env vars, 3h timeout.Both steps include a
podman→skopeowrapper for CI compatibility.Test plan
make updatesucceeds without errors/test e2e-awsto verify end-to-endpodmanwrapper delegates toskopeoforlogincalls🔨 Generated by The Automation Forge
Summary
This PR updates the OpenShift CNV ocp-virt-validation-checkup OpenShift CI configs to add a disconnected-environment validation step that runs after the existing connected validation on the same cluster (no new cluster provisioning).
Changes
Adds a new test step run-validation-checkup-disconnected to:
Adds image build variant src-disconnected that starts FROM src and installs skopeo (so skopeo is available inside the test container).
Technical details
Files touched