Skip to content

test pr chnages#79294

Draft
mohitsharma-web wants to merge 4 commits into
openshift:mainfrom
mohitsharma-web:test-pr-chnages
Draft

test pr chnages#79294
mohitsharma-web wants to merge 4 commits into
openshift:mainfrom
mohitsharma-web:test-pr-chnages

Conversation

@mohitsharma-web
Copy link
Copy Markdown

@mohitsharma-web mohitsharma-web commented May 14, 2026

What this PR changes (practical impact)

This PR updates the OpenShift CI configuration for the multiarch repository's nightly upgrade job matrix that validates upgrades from nightly 4.20 → nightly 4.21. It adjusts test environment resource sizing and DNS/workflow settings for heterogeneous and libvirt-based upgrade jobs used by CI.

  • Affected repo: openshift/multiarch (ci-operator job configuration)
  • Affected CI area: nightly multi-architecture upgrade tests (ci-operator config for upgrade validation)

Key changes

  • GCP heterogeneous upgrade (ocp-e2e-upgrade-gcp-ovn-multi-x-ax)

    • Increased ADDITIONAL_WORKER_VM_TYPE from t2a-standard-2 → t2a-standard-4 (more ARM worker resources for mixed-arch upgrade testing).
    • OCP_ARCH remains amd64 and the job continues to use the openshift-org-gcp cluster_profile.
  • GCP single-arch ARM upgrade (ocp-e2e-upgrade-gcp-ovn-multi-a-a)

    • COMPUTE_NODE_TYPE is set to t2a-standard-4 for arm64 compute nodes.
  • libvirt/remote upgrade jobs

    • The libvirt s2s UPI upgrade job (ocp-ovn-remote-s2s-libvirt-multi-p-p) now sets USE_EXTERNAL_DNS: "true" and uses the openshift-e2e-libvirt-upi workflow.
    • The separate libvirt VPN test (ocp-ovn-remote-libvirt-multi-z-z) also sets USE_EXTERNAL_DNS: "true".
    • A previously-present capability entry (power-s2s-dns) was removed from the s2s/libvirt entries.
  • Metadata

    • zz_generated_metadata.variant set to nightly-4.21-upgrade-from-nightly-4.20 to identify this upgrade scenario.

Other notes

  • Changes are limited to CI job YAML (no code/public API changes).

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

Hi @mohitsharma-web. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 72c13d7a-df3f-4f2a-b835-43cb38a00415

📥 Commits

Reviewing files that changed from the base of the PR and between 2dec375 and 81d5e06.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21-upgrade-from-nightly-4.20.yaml

Walkthrough

Updated multi-arch OpenShift nightly-upgrade CI config: changed the ARM additional worker VM from t2a-standard-2 to t2a-standard-4 and removed COMPUTE_NODE_REPLICAS; removed power-s2s-dns capability from a libvirt entry; added USE_EXTERNAL_DNS: "true", set workflow to openshift-e2e-libvirt-upi, and added variant metadata.

Changes

Multi-arch CI Test Configuration Updates

Layer / File(s) Summary
GCP heterogeneous upgrade test overrides
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21-upgrade-from-nightly-4.20.yaml
In ocp-e2e-upgrade-gcp-ovn-multi-x-ax: ADDITIONAL_WORKER_VM_TYPE changed from t2a-standard-2 to t2a-standard-4; the COMPUTE_NODE_REPLICAS: "2" env override was removed.
Libvirt remote s2s test entry and metadata
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21-upgrade-from-nightly-4.20.yaml
In ocp-ovn-remote-s2s-libvirt-multi-p-p: removed power-s2s-dns from capabilities; added USE_EXTERNAL_DNS: "true" to env; switched workflow to openshift-e2e-libvirt-upi; set zz_generated_metadata.variant to nightly-4.21-upgrade-from-nightly-4.20.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The pull request title 'test pr chnages' is vague and generic, using non-descriptive terms that don't convey meaningful information about the actual changes to the CI configuration. Replace the title with a descriptive summary of the main changes, such as 'Update ARM worker VM type and DNS configuration in multiarch upgrade tests' to clearly communicate the changeset purpose.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a CI configuration YAML file with no Ginkgo test code. The custom check for stable Ginkgo test names is not applicable to CI operator configuration files.
Test Structure And Quality ✅ Passed PR modifies CI configuration YAML, not Ginkgo test code. Custom check for test quality is not applicable to configuration files.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration YAML, not Ginkgo e2e test code. No new tests are added that would require MicroShift compatibility assessment.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. All 22 changed files are CI configuration YAML files and shell scripts with no Go source code or test code.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI test configuration file, not deployment manifests, operator code, or controllers. The check is not applicable.
Ote Binary Stdout Contract ✅ Passed Check not applicable. PR modifies CI configuration files and step-registry scripts, not OTE binary test source code. OTE contract applies to test binaries in openshift-tests repos.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI configuration YAML. No new Ginkgo e2e test code (It(), Describe(), Context(), etc.) is added. Custom check only applies to new test implementations, not CI config changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KeerthanaAP
Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
@KeerthanaAP
Copy link
Copy Markdown
Contributor

/test all

interval: 72h
steps:
cluster_profile: openshift-org-gcp
cluster_profile: gcp-arm64
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitsharma-web Can you revert this change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its done

interval: 72h
steps:
cluster_profile: openshift-org-gcp
cluster_profile: gcp-arm64
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitsharma-web Can you revert this change

ADDITIONAL_WORKER_ARCHITECTURE: aarch64
ADDITIONAL_WORKER_VM_TYPE: t2a-standard-2
COMPUTE_NODE_REPLICAS: "2"
ADDITIONAL_WORKER_VM_TYPE: t2a-standard-4
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitsharma-web Can you revert this change

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mohitsharma-web
Once this PR has been reviewed and has the lgtm label, please assign prb112 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mohitsharma-web: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-main-nightly-4.21-upgrade-from-nightly-4.20-ocp-e2e-upgrade-gcp-ovn-multi-x-ax N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-main-nightly-4.21-upgrade-from-nightly-4.20-ocp-ovn-remote-s2s-libvirt-multi-p-p N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mohitsharma-web
Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.21-upgrade-from-nightly-4.20-ocp-ovn-remote-s2s-libvirt-multi-p-p

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mohitsharma-web: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@mohitsharma-web: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ordered-prow-config 2dec375 link true /test ordered-prow-config
ci/prow/ci-operator-config 2dec375 link true /test ci-operator-config
ci/rehearse/periodic-ci-openshift-multiarch-main-nightly-4.21-upgrade-from-nightly-4.20-ocp-ovn-remote-s2s-libvirt-multi-p-p 81d5e06 link unknown /pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.21-upgrade-from-nightly-4.20-ocp-ovn-remote-s2s-libvirt-multi-p-p

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants